mediawiki.html: Add broken tests for numbers and booleans

* The following are broken right now:

mw.html.element( 'p', {}, 500 );
> Error: mw.html.element: Invalid type of contents
(custom error by mw.html.element)

mw.html.element( 'option', { selected: foo === bar }, 'label' );
> TypeError: Undefined method .replace

(bug 30774) - mediawiki.html: Add support for numbers and booleans

diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
index eb6ee2a..1220ce1 100644 (file)
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -170,7 +170,7 @@ test( 'mw.loader.bug29107' , function() {
 });
 
 test( 'mw.html', function() {
-       expect(7);
+       expect(11);
 
        raises( function(){
                mw.html.escape();
@@ -184,11 +184,41 @@ test( 'mw.html', function() {
 
        equal( mw.html.element( 'div' ), '<div/>', 'html.element DIV (simple)' );
 
-       equal( mw.html.element( 'div',
-                       { id: 'foobar' } ),
+       equal(
+               mw.html.element(
+                       'div', {
+                               id: 'foobar'
+                       }
+               ),
                '<div id="foobar"/>',
                'html.element DIV (attribs)' );
 
+       equal( mw.html.element( 'p', null, 12 ), '<p>12</p>', 'Numbers are valid content and should be casted to a string' );
+
+       equal( mw.html.element( 'p', { title: 12 }, '' ), '<p title="12"></p>', 'Numbers are valid attribute values' );
+
+       equal(
+               mw.html.element(
+                       'option', {
+                               value: 'foo',
+                               selected: true
+                       }, 'Foo'
+               ),
+               '<option value="foo" selected="selected">Foo</option>',
+               'Attributes may have boolean values. True copies the attribute name to the value.'
+       );
+
+       equal(
+               mw.html.element(
+                       'option', {
+                               value: 'foo',
+                               selected: false
+                       }, 'Foo'
+               ),
+               '<option value="foo">Foo</option>',
+               'Attributes may have boolean values. False keeps the attribute from output.'
+       );
+
        equal( mw.html.element( 'div',
                        null, 'a' ),
                '<div>a</div>',