Make FindOrphanedFiles handle bad file titles

Change-Id: Idb926097b6159c9c442ee6f427f1da60c5c5d2eb

diff --git a/maintenance/findOrphanedFiles.php b/maintenance/findOrphanedFiles.php
index a1e274c..41650bd 100644 (file)
--- a/maintenance/findOrphanedFiles.php
+++ b/maintenance/findOrphanedFiles.php
@@ -136,7 +136,11 @@ class FindOrphanedFiles extends Maintenance {
                foreach ( array_diff( $curNames, $curNamesFound ) as $name ) {
                        $file = $repo->newFile( $name );
                        // Print name and public URL to ease recovery
-                       $this->output( $name . "\n" . $file->getCanonicalUrl() . "\n\n" );
+                       if ( $file ) {
+                               $this->output( $name . "\n" . $file->getCanonicalUrl() . "\n\n" );
+                       } else {
+                               $this->error( "Cannot get URL for bad file title '$name'" );
+                       }
                }
 
                foreach ( array_diff( $oldNames, $oldNamesFound ) as $name ) {