* Fix 1.5 regression: weird, backwards diff links on new pages in enhanced RC

  are now suppressed as before.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index bfa7b44..bc396f0 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -596,6 +596,9 @@ of MediaWiki:Newpagetext) to &action=edit, if page is new.
 * (bug 2857) fixed parsing of lists in <pre> sections
 * Now sorting interwiki links by iw_prefix and avoiding duplicates
 * (bug 796) Trackback support
+* Fix 1.5 regression: weird, backwards diff links on new pages in enhanced RC
+  are now suppressed as before.
+
 
 === Caveats ===
 

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 3d194c4..b224c0a 100644 (file)
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -475,14 +475,15 @@ class ChangesList {
                } else {
                        $rcIdQuery = '';
                }
-               if ( ( $rc_type == RC_NEW && $rc_this_oldid == 0 ) || $rc_type == RC_LOG || $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
-                       $curLink = $message['cur'];
+               $query = $curIdEq."&diff=$rc_this_oldid&oldid=$rc_last_oldid";
+               $aprops = ' tabindex="'.$baseRC->counter.'"';
+               $curLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $message['cur'], $query, '' ,'' , $aprops );
+               if( $rc_type == RC_NEW || $rc_type == RC_LOG || $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
+                       if( $rc_type != RC_NEW ) {
+                               $curLink = $message['cur'];
+                       }
                        $diffLink = $message['diff'];
                } else {
-               #       $query = $curIdEq.'&diff=0&oldid='.$rc_this_oldid;
-                       $query = $curIdEq."&diff=$rc_this_oldid&oldid=$rc_last_oldid";
-                       $aprops = ' tabindex="'.$baseRC->counter.'"';
-                       $curLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $message['cur'], $query, '' ,'' , $aprops );
                        $diffLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $message['diff'], $query . $rcIdQuery, '' ,'' , $aprops );
                }