(bug 7890) Don't list redirects to special pages in Special:BrokenRedirects

There could be some issues here, since a redirect to a special page that doesn't exist *is* "broken", but I don't think we have a clear, clean means of excluding these at present...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 59a7fe9..681a8f2 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -386,6 +386,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Fix syntax error in translations of magic words in Romanian language
 * (bug 8737) Fix warnings caused by incorrect use of `/dev/null` when piping
   process error output under Windows
+* (bug 7890) Don't list redirects to special pages in Special:BrokenRedirects
 
 == API changes since 1.10 ==
 

diff --git a/includes/SpecialBrokenRedirects.php b/includes/SpecialBrokenRedirects.php
index 9b3f809..1fb4835 100644 (file)
--- a/includes/SpecialBrokenRedirects.php
+++ b/includes/SpecialBrokenRedirects.php
@@ -35,7 +35,8 @@ class BrokenRedirectsPage extends PageQueryPage {
                           FROM $redirect AS rd
                    JOIN $page p1 ON (rd.rd_from=p1.page_id)
                      LEFT JOIN $page AS p2 ON (rd_namespace=p2.page_namespace AND rd_title=p2.page_title )
-                               WHERE p2.page_namespace IS NULL";
+                                 WHERE rd_namespace >= 0
+                                   AND p2.page_namespace IS NULL";
                return $sql;
        }