Cleanup for r37830 & earlier ($wgDirectoryMode default to wfMkdirParents()):

Just check is_null() here. is_int() isn't necessarily safe, as numbers frequently get passed around in what are really strings. :)

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 86bbdc6..488e94e 100644 (file)
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -1781,7 +1781,7 @@ function wfMkdirParents( $fullDir, $mode = null ) {
        if( file_exists( $fullDir ) )
                return true;
        // If not defined or isn't an int, set to default
-       if ( !$mode || !is_int($mode) ) {
+       if ( is_null( $mode ) ) {
                $mode = $wgDirectoryMode;
        }