Remove action=history from submit on HistoryAction

* Not needed, and not used. Is internally converted to "view" as much as possible.
* Fixes bug 33587
* See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6
* Other diff links from MediaWiki don't do this either

diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index 5e4e608..e8d0b15 100644 (file)
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -228,6 +228,7 @@ production.
   all pages.
 * Files with IPTC blocks we can't read no longer prevent extraction of exif
   or other metadata.
+* (bug 33587) Remove action "historysubmit" from history pages.
 
 === API changes in 1.19 ===
 * (bug 19838) siprop=interwikimap can now use the interwiki cache.

diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php
index aa1ec45..8a34aa4 100644 (file)
--- a/includes/actions/HistoryAction.php
+++ b/includes/actions/HistoryAction.php
@@ -407,7 +407,6 @@ class HistoryPager extends ReverseChronologicalPager {
                $s = Html::openElement( 'form', array( 'action' => $wgScript,
                        'id' => 'mw-history-compare' ) ) . "\n";
                $s .= Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) . "\n";
-               $s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
 
                $s .= '<div>' . $this->submitButton( $this->msg( 'compareselectedversions' )->text(),
                        array( 'class' => 'historysubmit' ) ) . "\n";