Cleanup search placeholder black/gray text mess
authorjrobson <jrobson@wikimedia.org>
Wed, 5 Feb 2014 20:09:36 +0000 (12:09 -0800)
committerOri.livneh <ori@wikimedia.org>
Thu, 27 Feb 2014 09:52:59 +0000 (09:52 +0000)
Document all these cryptic selectors
Drop -webkit support - not necessary
Follow up to: Ief9a5a178058eb01ab032cfae8639b0fc52c47a4
Note: For the record, I think all these rules should die
but if they are not going to they should at least be documented!
Change-Id: I3bb2d9fc4f8502cbf36356a9bc6e3034d2d47ab1

skins/vector/components/search.less

index ec0b2fa..365995d 100644 (file)
@@ -55,18 +55,21 @@ div#simpleSearch {
 
                // These rules MAY NOT be merged because of how CSS requires browsers
                // to parse unrecognized selectors!
+               // Note these rules ensure that placeholder text can be distinguished from
+               // standard text. In browsers which make this distinction clear these rules
+               // are not necessary.
+               // For inputs that use jquery.placeholder.js e.g. IE9-
                &.placeholder {
                        color: #999;
                }
+               // Distinguish placeholder text in IE10+
                &:-ms-input-placeholder {
                        color: #999;
                }
+               // Distinguish placeholder text in Firefox 18-
                &:-moz-placeholder {
                        color: #999;
                }
-               &::-webkit-input-placeholder {
-                       color: #999;
-               }
 
                // Undo the styles Webkit browsers apply to type=search fields,
                // we provide our own