Remove weird, confusing, unreachable code
authorCatrope <roan.kattouw@gmail.com>
Tue, 24 Jul 2012 20:29:04 +0000 (13:29 -0700)
committerCatrope <roan.kattouw@gmail.com>
Tue, 24 Jul 2012 20:33:28 +0000 (13:33 -0700)
The removed code was doing first-order dependency resolution if a single
module was passed in as a string.

This is crazy because:
* passing in 'foo' triggered it but passing in ['foo'] didn't
* dependency resolution is resolve()'s responsibility
* all callers were passing in arrays produced by resolve(), so this code
  was never reached

Change-Id: I081e2bf90cead63437e495006c78254cf65e3847

resources/mediawiki/mediawiki.js

index deb7795..2332930 100644 (file)
@@ -880,15 +880,6 @@ var mw = ( function ( $, undefined ) {
                                // Allow calling by single module name
                                if ( typeof dependencies === 'string' ) {
                                        dependencies = [dependencies];
-                                       if ( registry[dependencies[0]] !== undefined ) {
-                                               // Cache repetitively accessed deep level object member
-                                               regItemDeps = registry[dependencies[0]].dependencies;
-                                               // Cache to avoid looped access to length property
-                                               regItemDepLen = regItemDeps.length;
-                                               for ( n = 0; n < regItemDepLen; n += 1 ) {
-                                                       dependencies[dependencies.length] = regItemDeps[n];
-                                               }
-                                       }
                                }
 
                                // Add ready and error callbacks if they were given