Normalise categorymembers to take ascending/descending for direction, also adding...
authorReedy <reedy@wikimedia.org>
Tue, 10 Apr 2012 13:01:30 +0000 (14:01 +0100)
committerReedy <reedy@wikimedia.org>
Tue, 10 Apr 2012 13:02:22 +0000 (14:02 +0100)
Change-Id: I50c770b8d48548988a71bcf62b76a9c43fc1622f

includes/api/ApiQueryCategoryMembers.php

index 4b19b7e..fb1237f 100644 (file)
@@ -107,7 +107,7 @@ class ApiQueryCategoryMembers extends ApiQueryGeneratorBase {
                        $this->addWhereFld( 'page_namespace', $params['namespace'] );
                }
 
-               $dir = $params['dir'] == 'asc' ? 'newer' : 'older';
+               $dir = in_array( $params['dir'], array( 'asc', 'ascending', 'newer' ) ) ? 'newer' : 'older';
 
                if ( $params['sort'] == 'timestamp' ) {
                        $this->addWhereRange( 'cl_timestamp',
@@ -313,10 +313,15 @@ class ApiQueryCategoryMembers extends ApiQueryGeneratorBase {
                                )
                        ),
                        'dir' => array(
-                               ApiBase::PARAM_DFLT => 'asc',
+                               ApiBase::PARAM_DFLT => 'ascending',
                                ApiBase::PARAM_TYPE => array(
                                        'asc',
-                                       'desc'
+                                       'desc',
+                                       // Normalising with other modules
+                                       'ascending',
+                                       'descending',
+                                       'newer',
+                                       'older',
                                )
                        ),
                        'start' => array(