RCFilters: Treat saved query with multiple spaces as empty
authorMoriel Schottlender <moriel@gmail.com>
Fri, 12 May 2017 00:52:45 +0000 (17:52 -0700)
committerMoriel Schottlender <moriel@gmail.com>
Fri, 12 May 2017 00:52:45 +0000 (17:52 -0700)
Because it is empty, even if there's multiple spaces. Also, if the
input is invalid and we didn't save the query, don't close the
popup.

Bug: T165113
Change-Id: I30e68b0b90e2a4077fb4068c1462d40b03cbfe8c

resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js

index 9b7a2fb..3f920f0 100644 (file)
@@ -39,7 +39,7 @@
                this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element );
 
                this.input = new OO.ui.TextInputWidget( {
-                       validate: 'non-empty'
+                       validate: /\S/
                } );
                layout = new OO.ui.FieldLayout( this.input, {
                        label: mw.msg( 'rcfilters-savedqueries-new-name-label' ),
                                widget.controller.saveCurrentQuery( label );
                                widget.input.setValue( this.input, '' );
                                widget.emit( 'saveCurrent' );
-                       } )
-                       .always( function () {
                                widget.popup.toggle( false );
                        } );
        };