(bug 23570) Fix an instance of a javascript: link in core

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index daa1a8e..69df146 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1676,7 +1676,7 @@ $wgCacheEpoch = '20030516000000';
  * to ensure that client-side caches do not keep obsolete copies of global
  * styles.
  */
-$wgStyleVersion = '284';
+$wgStyleVersion = '285';
 
 
 # Server-side caching:

diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index 0454bba..1bf36b8 100644 (file)
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -145,7 +145,9 @@ function showTocToggle() {
                var toggleLink = document.createElement( 'a' );
                toggleLink.id = 'togglelink';
                toggleLink.className = 'internal';
-               toggleLink.href = 'javascript:toggleToc()';
+               toggleLink.href = '#';
+               toggleLink.onclick = toggleToc;
+               
                toggleLink.appendChild( document.createTextNode( tocHideText ) );
 
                outerSpan.appendChild( document.createTextNode( '[' ) );
@@ -187,6 +189,7 @@ function toggleToc() {
                document.cookie = "hidetoc=1";
                tocmain.className = 'toc tochidden';
        }
+       return false;
 }
 
 var mwEditButtons = [];