Per Tim's comment on r49782 (and fix for that rev): put the $n assignment out of...

diff --git a/includes/Skin.php b/includes/Skin.php
index faad104..5d73f5b 100644 (file)
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -1018,17 +1018,19 @@ END;
                $action = $wgRequest->getVal( 'action', 'view' );
 
                if ( $wgUser->isAllowed( 'deletedhistory' ) &&
-                       ( $this->mTitle->getArticleId() == 0 || $action == 'history' ) &&
-                       $n = $this->mTitle->isDeleted() ) {
-                       if ( $wgUser->isAllowed( 'undelete' ) ) {
-                               $msg = 'thisisdeleted';
-                       } else {
-                               $msg = 'viewdeleted';
+                       ( $this->mTitle->getArticleId() == 0 || $action == 'history' ) ) {
+                       $n = $this->mTitle->isDeleted();
+                       if ( $n ) {
+                               if ( $wgUser->isAllowed( 'undelete' ) ) {
+                                       $msg = 'thisisdeleted';
+                               } else {
+                                       $msg = 'viewdeleted';
+                               }
+                               return wfMsg( $msg,
+                                       $this->makeKnownLinkObj(
+                                               SpecialPage::getTitleFor( 'Undelete', $this->mTitle->getPrefixedDBkey() ),
+                                               wfMsgExt( 'restorelink', array( 'parsemag', 'escape' ), $wgLang->formatNum( $n ) ) ) );
                        }
-                       return wfMsg( $msg,
-                               $this->makeKnownLinkObj(
-                                       SpecialPage::getTitleFor( 'Undelete', $this->mTitle->getPrefixedDBkey() ),
-                                       wfMsgExt( 'restorelink', array( 'parsemag', 'escape' ), $wgLang->formatNum( $n ) ) ) );
                }
                return '';
        }