Followup r80864: DatabaseSqlite exploded on installer page because it tried to open...

Even though it doesn't use $server, only call open() if it's set, like in the other constructors.

The amount of code duplication here is stupid.

diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php
index 4da6ecf..7afccaf 100644 (file)
--- a/includes/db/DatabaseSqlite.php
+++ b/includes/db/DatabaseSqlite.php
@@ -28,8 +28,10 @@ class DatabaseSqlite extends DatabaseBase {
                $this->mFlags = $flags;
                $this->mName = $dbName;
 
-               if ( $this->open( $server, $user, $password, $dbName ) && $wgSharedDB ) {
-                       $this->attachDatabase( $wgSharedDB );
+               if( $server ) {
+                       if ( $this->open( $server, $user, $password, $dbName ) && $wgSharedDB ) {
+                               $this->attachDatabase( $wgSharedDB );
+                       }
                }
        }