Add toggle checkboxes to action=history
authorLuke Faraone <luke@faraone.cc>
Tue, 19 Jan 2016 01:42:14 +0000 (01:42 +0000)
committerLuke Faraone <luke@faraone.cc>
Sun, 21 Feb 2016 20:34:42 +0000 (20:34 +0000)
This breaks out the toggle checkbox code into a separate class in
includes/ListToggle.php

Bug: T92230
Change-Id: I8d1aefb83008053e63d59abf8b8915b93e15fcc2

autoload.php
includes/ListToggle.php [new file with mode: 0644]
includes/actions/HistoryAction.php
includes/specials/SpecialLog.php

index 341cb90..23beaee 100644 (file)
@@ -703,6 +703,7 @@ $wgAutoloadLocalClasses = [
        'LinksDeletionUpdate' => __DIR__ . '/includes/deferred/LinksDeletionUpdate.php',
        'LinksUpdate' => __DIR__ . '/includes/deferred/LinksUpdate.php',
        'ListDuplicatedFilesPage' => __DIR__ . '/includes/specials/SpecialListDuplicatedFiles.php',
+       'ListToggle' => __DIR__ . '/includes/ListToggle.php',
        'ListVariants' => __DIR__ . '/maintenance/language/listVariants.php',
        'ListredirectsPage' => __DIR__ . '/includes/specials/SpecialListredirects.php',
        'LoadBalancer' => __DIR__ . '/includes/db/loadbalancer/LoadBalancer.php',
diff --git a/includes/ListToggle.php b/includes/ListToggle.php
new file mode 100644 (file)
index 0000000..dfa1763
--- /dev/null
@@ -0,0 +1,67 @@
+<?php
+/**
+ * Class for generating clickable toggle links for a list of checkboxes.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ */
+
+/**
+ * Class for generating clickable toggle links for a list of checkboxes.
+ *
+ * This is only supported on clients that have JavaScript enabled; it is hidden
+ * for clients that have it disabled.
+ *
+ * @since 1.27
+ */
+class ListToggle {
+       /** @var OutputPage */
+       private $output;
+
+       public function __construct( OutputPage $output ) {
+               $this->output = $output;
+
+               $output->addModules( 'mediawiki.checkboxtoggle' );
+               $output->addModuleStyles( 'mediawiki.checkboxtoggle.styles' );
+       }
+
+       private function checkboxLink( $checkboxType ) {
+               return Html::element(
+                       'a', [ 'href' => '#', 'class' => 'mw-checkbox-' . $checkboxType ],
+                       $this->output->msg( 'checkbox-' . $checkboxType )->text()
+               );
+       }
+
+       /**
+        * @return string
+        */
+       public function getHTML() {
+               // Select: All, None, Invert
+               $links = [];
+               $links[] = $this->checkboxLink( 'all' );
+               $links[] = $this->checkboxLink( 'none' );
+               $links[] = $this->checkboxLink( 'invert' );
+
+               return Html::rawElement( 'div',
+                       [
+                               'class' => 'mw-checkbox-toggle-controls'
+                       ],
+                       $this->output->msg( 'checkbox-select' )
+                               ->rawParams( $this->output->getLanguage()->commaList( $links ) )->escaped()
+               );
+       }
+}
index 073b3ca..6f1f3e8 100644 (file)
@@ -517,6 +517,11 @@ class HistoryPager extends ReverseChronologicalPager {
                        $this->buttons .= Xml::tags( 'div', [ 'class' =>
                                'mw-history-revisionactions' ], $actionButtons );
                }
+
+               if ( $user->isAllowed( 'deleterevision' ) || $this->showTagEditUI ) {
+                       $this->buttons .= ( new ListToggle( $this->getOutput() ) )->getHTML();
+               }
+
                $this->buttons .= '</div>';
 
                $s .= $this->buttons;
index bec871b..d4c7c6a 100644 (file)
@@ -259,31 +259,7 @@ class SpecialLog extends SpecialPage {
                        ) . "\n";
                }
 
-               // Select: All, None, Invert
-               $links = [];
-               $links[] = Html::element(
-                       'a', [ 'href' => '#', 'class' => 'mw-checkbox-all' ],
-                       $this->msg( 'checkbox-all' )->text()
-               );
-               $links[] = Html::element(
-                       'a', [ 'href' => '#', 'class' => 'mw-checkbox-none' ],
-                       $this->msg( 'checkbox-none' )->text()
-               );
-               $links[] = Html::element(
-                       'a', [ 'href' => '#', 'class' => 'mw-checkbox-invert' ],
-                       $this->msg( 'checkbox-invert' )->text()
-               );
-
-               $buttons .= Html::rawElement( 'p',
-                       [
-                               'class' => "mw-checkbox-toggle-controls"
-                       ],
-                       $this->msg( 'checkbox-select' )
-                               ->rawParams( $this->getLanguage()->commaList( $links ) )->escaped()
-               );
-
-               $this->getOutput()->addModules( 'mediawiki.checkboxtoggle' );
-               $this->getOutput()->addModuleStyles( 'mediawiki.checkboxtoggle.styles' );
+               $buttons .= ( new ListToggle( $this->getOutput() ) )->getHTML();
 
                $s .= $buttons . $formcontents . $buttons;
                $s .= Html::closeElement( 'form' );