Remove TODO for unblockself
authorDavid Barratt <dbarratt@wikimedia.org>
Fri, 19 Jul 2019 18:12:06 +0000 (14:12 -0400)
committerDavid Barratt <dbarratt@wikimedia.org>
Sat, 27 Jul 2019 00:58:28 +0000 (20:58 -0400)
It is impossible to reach the unblockself code if someone is anonymous, so
there is no need to check that the block applies to that permission.

Bug: T228538
Change-Id: Ie7b1e0f37363cc9e75ee2c871c06cefdfb2eb1d1

includes/specials/SpecialBlock.php

index ea4f18d..13e4609 100644 (file)
@@ -1130,8 +1130,6 @@ class SpecialBlock extends FormSpecialPage {
                if ( $performer->getBlock() ) {
                        if ( $target instanceof User && $target->getId() == $performer->getId() ) {
                                # User is trying to unblock themselves
-                               // @TODO Ensure that the block does not apply to the `unblockself`
-                               //       right.
                                if ( $performer->isAllowed( 'unblockself' ) ) {
                                        return true;
                                        # User blocked themselves and is now trying to reverse it