Check for Wikidiff2 version 0.3 NOT for 0.3.0
authorTobias Gritschacher <tobias.gritschacher@wikimedia.de>
Mon, 4 Sep 2017 11:58:49 +0000 (13:58 +0200)
committerTobias Gritschacher <tobias.gritschacher@wikimedia.de>
Mon, 4 Sep 2017 11:58:49 +0000 (13:58 +0200)
version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check
for 0.3 since the Wikidiff2 version is defined as 0.3 in
https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h

Bug: T166571
Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e

includes/diff/DifferenceEngine.php

index 7f9af60..34f2852 100644 (file)
@@ -918,7 +918,7 @@ class DifferenceEngine extends ContextSource {
                        $wikidiff2Version = phpversion( 'wikidiff2' );
                        if (
                                $wikidiff2Version !== false &&
-                               version_compare( $wikidiff2Version, '0.3.0', '>=' )
+                               version_compare( $wikidiff2Version, '0.3', '>=' )
                        ) {
                                $text = wikidiff2_do_diff(
                                        $otext,