dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
(from parent 1:
b954e4f
)
Merge "Fix HeaderCallback failing on headers without a colon"
author
jenkins-bot
<jenkins-bot@gerrit.wikimedia.org>
Wed, 6 Mar 2019 17:45:51 +0000
(17:45 +0000)
committer
Gerrit Code Review
<gerrit@wikimedia.org>
Wed, 6 Mar 2019 17:45:51 +0000
(17:45 +0000)
includes/HeaderCallback.php
patch
|
blob
|
history
diff --git
a/includes/HeaderCallback.php
b/includes/HeaderCallback.php
index
b2ca673
..
650a3a8
100644
(file)
--- a/
includes/HeaderCallback.php
+++ b/
includes/HeaderCallback.php
@@
-22,8
+22,12
@@
class HeaderCallback {
// Prevent caching of responses with cookies (T127993)
$headers = [];
foreach ( headers_list() as $header ) {
- list( $name, $value ) = explode( ':', $header, 2 );
- $headers[strtolower( trim( $name ) )][] = trim( $value );
+ $header = explode( ':', $header, 2 );
+
+ // Note: The code below (currently) does not care about value-less headers
+ if ( isset( $header[1] ) ) {
+ $headers[ strtolower( trim( $header[0] ) ) ][] = trim( $header[1] );
+ }
}
if ( isset( $headers['set-cookie'] ) ) {