Do not use raw html for Special:ProtectedPages drop-down messages
authorBrian Wolff <bawolff+wn@gmail.com>
Sun, 17 Feb 2019 11:14:18 +0000 (11:14 +0000)
committerBrian Wolff <bawolff+wn@gmail.com>
Mon, 18 Feb 2019 11:12:15 +0000 (11:12 +0000)
The following messages are affected: protectedpages-indef,
protectedpages-cascade, protectedpages-noredirect.

This appear to be accidental. AFAIK nobody is using these messages
in a raw html fashion.

This change is to make phan-taint-check happier.

Bug: T216348
Change-Id: I0e038c2e01e2252be288b86950208510741efc67

includes/specials/SpecialProtectedpages.php

index 4b1b344..d99de1e 100644 (file)
@@ -110,10 +110,10 @@ class SpecialProtectedpages extends SpecialPage {
                                'class' => 'HTMLMultiSelectField',
                                'label' => $this->msg( 'protectedpages-filters' )->text(),
                                'flatlist' => true,
-                               'options' => [
-                                       $this->msg( 'protectedpages-indef' )->text() => 'indefonly',
-                                       $this->msg( 'protectedpages-cascade' )->text() => 'cascadeonly',
-                                       $this->msg( 'protectedpages-noredirect' )->text() => 'noredirect',
+                               'options-messages' => [
+                                       'protectedpages-indef' => 'indefonly',
+                                       'protectedpages-cascade' => 'cascadeonly',
+                                       'protectedpages-noredirect' => 'noredirect',
                                ],
                                'default' => $filters,
                        ],