Use wfEscapeShellArg() so that the script works correctly when paths contain whitespaces

diff --git a/maintenance/syntaxChecker.php b/maintenance/syntaxChecker.php
index 387b92a..90d1f87 100644 (file)
--- a/maintenance/syntaxChecker.php
+++ b/maintenance/syntaxChecker.php
@@ -125,7 +125,7 @@ class SyntaxChecker extends Maintenance {
         * @return boolean
         */
        private function checkFileWithCli( $file ) {
-               $res = exec( 'php -l ' . $file ); 
+               $res = exec( 'php -l ' . wfEscapeShellArg( $file ) ); 
                if( strpos( $res, 'No syntax errors detected' ) === false ) {
                        $this->mFailures[$file] = $res;
                        $this->output( $res . "\n" );