We already have an Article object, so no need to recreate another one.

Also removed some PHP4-ism.

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index f691062..222851c 100644 (file)
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -30,11 +30,11 @@ class ProtectionForm {
        var $mPermErrors = array();
        var $mApplicableTypes = array();
 
-       function __construct( &$article ) {
+       function __construct( Article $article ) {
                global $wgRequest, $wgUser;
                global $wgRestrictionTypes, $wgRestrictionLevels;
-               $this->mArticle =& $article;
-               $this->mTitle =& $article->mTitle;
+               $this->mArticle = $article;
+               $this->mTitle = $article->mTitle;
                $this->mApplicableTypes = $this->mTitle->exists() ? $wgRestrictionTypes : array('create');
 
                if( $this->mTitle ) {
@@ -95,8 +95,7 @@ class ProtectionForm {
                global $wgRequest, $wgOut;
                if( $wgRequest->wasPosted() ) {
                        if( $this->save() ) {
-                               $article = new Article( $this->mTitle );
-                               $q = $article->isRedirect() ? 'redirect=no' : '';
+                               $q = $this->mArticle->isRedirect() ? 'redirect=no' : '';
                                $wgOut->redirect( $this->mTitle->getFullUrl( $q ) );
                        }
                } else {