Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'
authorBartosz Dziewoński <matma.rex@gmail.com>
Wed, 9 May 2018 20:39:20 +0000 (22:39 +0200)
committerJforrester <jforrester@wikimedia.org>
Thu, 24 May 2018 21:20:50 +0000 (21:20 +0000)
commitc513ec19efa7d0b08552b8556a238fbcbc8783c1
treea4730a3f8154f65b55aca3a904b1df6bd6d47a7d
parentc932e28214ba95d279fd89a09e9025b5dc6e47d1
Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'

In change 4633f4d46a8db46721474e9ffa6a130d8b7a2404 it was changed
to an interface implemented by both PreferencesFormLegacy and
PreferencesFormOOUI so that existing typehints for some functions
parameter would accept them both. Replace those typehints to use
HTMLForm instead. There was really no guarantee in the past that
they would only be given PreferencesForm or its subclasses, either.

Because the typehint change affects some hooks, note it as a
deprecation in MW 1.31 and a breaking change in MW 1.32.

Also add @since tags and correct some typos in code comments.

Follow-up to 4633f4d46a8db46721474e9ffa6a130d8b7a2404.

Change-Id: I61749f1d864cf68afe90cd9e15ba2d7a74252501
13 files changed:
.phpcs.xml
RELEASE-NOTES-1.31
RELEASE-NOTES-1.32
autoload.php
docs/hooks.txt
includes/DefaultSettings.php
includes/Preferences.php
includes/preferences/DefaultPreferencesFactory.php
includes/specials/SpecialPreferences.php
includes/specials/forms/PreferencesForm.php [deleted file]
includes/specials/forms/PreferencesFormLegacy.php
includes/specials/forms/PreferencesFormOOUI.php
resources/src/mediawiki.legacy/oldshared.css