A few more DBLockManager fixes and cleanups
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Aug 2016 05:04:43 +0000 (22:04 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Aug 2016 05:05:47 +0000 (22:05 -0700)
commit8f47c177e3b3b454c84bff4259761b864118d9d8
tree23c8d38562c7e321a6105a38a6c8d66e45f4d0f4
parent345fcff394dbcfe0df9427c680bda0e1d080e330
A few more DBLockManager fixes and cleanups

* Do not do the connection init step if the same DB handle as
  wfGetDB( DB_MASTER ) is being used to avoid clobbering it.
* Remove begin(), since only one of the subclasses wants
  transactions. That one now uses startAtomic() now.
* Make getConnection() throw an error for bad config instead
  of return null, which was not documented or expected.

Change-Id: Ib09a7972d6569c29e83e329a8f7f9f47a393b896
includes/filebackend/lockmanager/DBLockManager.php
includes/filebackend/lockmanager/MySqlLockManager.php