resourceloader: Merge $fileCache conditional blocks
authorTimo Tijhof <krinklemail@gmail.com>
Thu, 25 Jul 2019 22:57:08 +0000 (23:57 +0100)
committerKrinkle <krinklemail@gmail.com>
Sat, 27 Jul 2019 14:29:37 +0000 (14:29 +0000)
commit69016bd2c3e3d2048dad3e245d9c24a38d43c208
tree53562314c5519efbd5a1640277d7c1c014717d74
parent167e6a449eec25faec036691e51788f467e34ac7
resourceloader: Merge $fileCache conditional blocks

Also avoid conditional existence of variables ($fileCache). This avoids
isset(), which means we won't hide problems during refactor.

Raised by Codehealth (sonarcloud.io) as Major Code Smell:

> Merge this if statement with the enclosing one.
> https://sonarcloud.io/organizations/wmftest/rules?open=php%3AS1066&rule_key=php%3AS1066

Change-Id: Iacebbe6a68dac46cdfd1415a33a547d105b24b98
includes/resourceloader/ResourceLoader.php