rdbms: clean up return values of IDatabase write methods
authorAaron Schulz <aschulz@wikimedia.org>
Fri, 26 Oct 2018 20:17:34 +0000 (13:17 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 30 Oct 2018 03:34:52 +0000 (03:34 +0000)
commit633eb437a3b808518469c6eaf4e86a436941d837
tree874f8e46372c6148728101868b9b777444af9432
parentc6ad2554f40f8ebbe9e38ac64ea933076f348729
rdbms: clean up return values of IDatabase write methods

Also improved the atomicity and affected row count logic for
insert/replace with sqlite.

Also remove unused "fileHandle" code from insert().

Change-Id: If7b9148fd44f3a958899885753c7c86ba66bf193
includes/db/DatabaseOracle.php
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabaseMssql.php
includes/libs/rdbms/database/DatabaseMysqlBase.php
includes/libs/rdbms/database/DatabasePostgres.php
includes/libs/rdbms/database/DatabaseSqlite.php
includes/libs/rdbms/database/IDatabase.php
tests/phpunit/includes/db/DatabaseTestHelper.php