test: Remove MagicVariableTest#testServernameFromDifferentProtocols
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 24 Jun 2014 19:20:01 +0000 (21:20 +0200)
committerTimo Tijhof <krinklemail@gmail.com>
Wed, 25 Jun 2014 10:08:48 +0000 (12:08 +0200)
commit0c2a013beb3933dd0475f1d34a7800372100ab1d
tree4fe6986075eba675f215b467b2acb1aa75ea2f14
parent480546006c1486edf763f600242868787a6af1da
test: Remove MagicVariableTest#testServernameFromDifferentProtocols

This test was causing failures locally when wgServer != localhost
because {{SERVERNAME}} is derived from wgServerName, not wgServer
and the test is only mocking wgServer.

> MagicVariableTest::testServername.. with data set #2 ('//localhost/')
> Magic servername should be <localhost:string>
> Failed asserting that two strings are identical.
> --- Expected
> +++ Actual
> @@ @@
> -localhost
> +krinkle.dev

This value is no longer derived by the Parser, but is instead
set using wfParserUrl in Setup.php.

Remove this obsolete test and add any missing test cases for
wgParserUrl to its test suite.

Change-Id: I7d7d201cb46841e63dac8ab9fd81b45b252264a3
tests/phpunit/includes/GlobalFunctions/wfParseUrlTest.php
tests/phpunit/includes/parser/MagicVariableTest.php