X-Git-Url: http://git.cyclocoop.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fresourceloader%2FMessageBlobStoreTest.php;h=4d98773890f16fd3b3e390f97d644f80430bcf68;hb=568ce02b434ef39a3269bf3d24a54f4b53c3cb12;hp=1f2c617e261730c37a45d33a8186972dc379f69c;hpb=f7e1770fb832aa77bf4e16ce8cc815f2b24dd10d;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
index 1f2c617e26..4d98773890 100644
--- a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
+++ b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
@@ -6,13 +6,15 @@ use Wikimedia\TestingAccessWrapper;
  * @group Cache
  * @covers MessageBlobStore
  */
-class MessageBlobStoreTest extends PHPUnit_Framework_TestCase {
+class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
+
+	use MediaWikiCoversValidator;
 
 	protected function setUp() {
 		parent::setUp();
 		// MediaWiki tests defaults $wgMainWANCache to CACHE_NONE.
 		// Use hash instead so that caching is observed
-		$this->wanCache = $this->getMockBuilder( 'WANObjectCache' )
+		$this->wanCache = $this->getMockBuilder( WANObjectCache::class )
 			->setConstructorArgs( [ [
 				'cache' => new HashBagOStuff(),
 				'pool' => 'test',
@@ -30,7 +32,7 @@ class MessageBlobStoreTest extends PHPUnit_Framework_TestCase {
 	}
 
 	protected function makeBlobStore( $methods = null, $rl = null ) {
-		$blobStore = $this->getMockBuilder( 'MessageBlobStore' )
+		$blobStore = $this->getMockBuilder( MessageBlobStore::class )
 			->setConstructorArgs( [ $rl ] )
 			->setMethods( $methods )
 			->getMock();
@@ -101,6 +103,11 @@ class MessageBlobStoreTest extends PHPUnit_Framework_TestCase {
 		$this->assertEquals( '{"foo":"Example"}', $blob, 'Generated blob' );
 	}
 
+	/**
+	 * Seems to fail sometimes (T176097).
+	 *
+	 * @group Broken
+	 */
 	public function testGetBlobCached() {
 		$module = $this->makeModule( [ 'example' ] );
 		$rl = new ResourceLoader();