X-Git-Url: http://git.cyclocoop.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fapi%2Fformat%2FApiFormatJsonTest.php;h=3dfcaf0fd7ec93a68002972e8fb265d78dacec53;hb=1c57794e371;hp=fc1f90217aac759a8e5b7e1de6aedc4c84e3a280;hpb=91b07c5e0950572fb41f7d8f466fb6b3bbe98be5;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/api/format/ApiFormatJsonTest.php b/tests/phpunit/includes/api/format/ApiFormatJsonTest.php
index fc1f90217a..3dfcaf0fd7 100644
--- a/tests/phpunit/includes/api/format/ApiFormatJsonTest.php
+++ b/tests/phpunit/includes/api/format/ApiFormatJsonTest.php
@@ -2,21 +2,109 @@
 
 /**
  * @group API
- * @group Database
- * @group medium
  * @covers ApiFormatJson
  */
 class ApiFormatJsonTest extends ApiFormatTestBase {
 
-	public function testValidSyntax( ) {
-		$data = $this->apiRequest( 'json', array( 'action' => 'query', 'meta' => 'siteinfo' ) );
+	protected $printerName = 'json';
 
-		$this->assertInternalType( 'array', json_decode( $data, true ) );
-		$this->assertGreaterThan( 0, count( (array)$data ) );
+	private static function addFormatVersion( $format, $arr ) {
+		foreach ( $arr as &$p ) {
+			if ( !isset( $p[2] ) ) {
+				$p[2] = array( 'formatversion' => $format );
+			} else {
+				$p[2]['formatversion'] = $format;
+			}
+		}
+		return $arr;
 	}
 
-	public function testJsonpInjection( ) {
-		$data = $this->apiRequest( 'json', array( 'action' => 'query', 'meta' => 'siteinfo', 'callback' => 'myCallback' ) );
-		$this->assertEquals( '/**/myCallback(', substr( $data, 0, 15 ) );
+	public static function provideGeneralEncoding() {
+		return array_merge(
+			self::addFormatVersion( 1, array(
+				// Basic types
+				array( array( null ), '[null]' ),
+				array( array( true ), '[""]' ),
+				array( array( false ), '[]' ),
+				array( array( true, ApiResult::META_BC_BOOLS => array( 0 ) ), '[true]' ),
+				array( array( false, ApiResult::META_BC_BOOLS => array( 0 ) ), '[false]' ),
+				array( array( 42 ), '[42]' ),
+				array( array( 42.5 ), '[42.5]' ),
+				array( array( 1e42 ), '[1.0e+42]' ),
+				array( array( 'foo' ), '["foo"]' ),
+				array( array( 'fóo' ), '["f\u00f3o"]' ),
+				array( array( 'fóo' ), '["fóo"]', array( 'utf8' => 1 ) ),
+
+				// Arrays and objects
+				array( array( array() ), '[[]]' ),
+				array( array( array( 1 ) ), '[[1]]' ),
+				array( array( array( 'x' => 1 ) ), '[{"x":1}]' ),
+				array( array( array( 2 => 1 ) ), '[{"2":1}]' ),
+				array( array( (object)array() ), '[{}]' ),
+				array( array( array( 1, ApiResult::META_TYPE => 'assoc' ) ), '[{"0":1}]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'array' ) ), '[[1]]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'kvp' ) ), '[{"x":1}]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'BCkvp', ApiResult::META_KVP_KEY_NAME => 'key' ) ),
+					'[[{"key":"x","*":1}]]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'BCarray' ) ), '[{"x":1}]' ),
+				array( array( array( 'a', 'b', ApiResult::META_TYPE => 'BCassoc' ) ), '[["a","b"]]' ),
+
+				// Content
+				array( array( 'content' => 'foo', ApiResult::META_CONTENT => 'content' ),
+					'{"*":"foo"}' ),
+
+				// BC Subelements
+				array( array( 'foo' => 'foo', ApiResult::META_BC_SUBELEMENTS => array( 'foo' ) ),
+					'{"foo":{"*":"foo"}}' ),
+
+				// Callbacks
+				array( array( 1 ), '/**/myCallback([1])', array( 'callback' => 'myCallback' ) ),
+
+				// Cross-domain mangling
+				array( array( '< Cross-Domain-Policy >' ), '["\u003C Cross-Domain-Policy \u003E"]' ),
+			) ),
+			self::addFormatVersion( 2, array(
+				// Basic types
+				array( array( null ), '[null]' ),
+				array( array( true ), '[true]' ),
+				array( array( false ), '[false]' ),
+				array( array( true, ApiResult::META_BC_BOOLS => array( 0 ) ), '[true]' ),
+				array( array( false, ApiResult::META_BC_BOOLS => array( 0 ) ), '[false]' ),
+				array( array( 42 ), '[42]' ),
+				array( array( 42.5 ), '[42.5]' ),
+				array( array( 1e42 ), '[1.0e+42]' ),
+				array( array( 'foo' ), '["foo"]' ),
+				array( array( 'fóo' ), '["fóo"]' ),
+				array( array( 'fóo' ), '["f\u00f3o"]', array( 'ascii' => 1 ) ),
+
+				// Arrays and objects
+				array( array( array() ), '[[]]' ),
+				array( array( array( 'x' => 1 ) ), '[{"x":1}]' ),
+				array( array( array( 2 => 1 ) ), '[{"2":1}]' ),
+				array( array( (object)array() ), '[{}]' ),
+				array( array( array( 1, ApiResult::META_TYPE => 'assoc' ) ), '[{"0":1}]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'array' ) ), '[[1]]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'kvp' ) ), '[{"x":1}]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'BCkvp', ApiResult::META_KVP_KEY_NAME => 'key' ) ),
+					'[{"x":1}]' ),
+				array( array( array( 'x' => 1, ApiResult::META_TYPE => 'BCarray' ) ), '[[1]]' ),
+				array( array( array( 'a', 'b', ApiResult::META_TYPE => 'BCassoc' ) ), '[{"0":"a","1":"b"}]' ),
+
+				// Content
+				array( array( 'content' => 'foo', ApiResult::META_CONTENT => 'content' ),
+					'{"content":"foo"}' ),
+
+				// BC Subelements
+				array( array( 'foo' => 'foo', ApiResult::META_BC_SUBELEMENTS => array( 'foo' ) ),
+					'{"foo":"foo"}' ),
+
+				// Callbacks
+				array( array( 1 ), '/**/myCallback([1])', array( 'callback' => 'myCallback' ) ),
+
+				// Cross-domain mangling
+				array( array( '< Cross-Domain-Policy >' ), '["\u003C Cross-Domain-Policy \u003E"]' ),
+			) )
+		);
 	}
+
 }