X-Git-Url: http://git.cyclocoop.org/?a=blobdiff_plain;f=includes%2Fconfig%2FServiceOptions.php;h=46f6689b8ea29d120d0176a4f6175c01b806e46f;hb=755ac5f3e91511ade53c8dd692fdcece60c35498;hp=6ae059ebff9780a426136101d7d7cb4805444e36;hpb=21a8c909ba31ae6c63fa04fe3cee0f42ce8a9c33;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/config/ServiceOptions.php b/includes/config/ServiceOptions.php index 6ae059ebff..46f6689b8e 100644 --- a/includes/config/ServiceOptions.php +++ b/includes/config/ServiceOptions.php @@ -13,12 +13,12 @@ use Wikimedia\Assert\Assert; * objects). * * Services that take this type as a parameter to their constructor should specify a list of the - * keys they expect to receive in an array. The convention is to make it a public static variable - * called $constructorOptions. (When we drop HHVM support -- see T192166 -- it should become a - * const.) In the constructor, they should call assertRequiredOptions() to make sure that they - * weren't passed too few or too many options. This way it's clear what each class depends on, and - * that it's getting passed the correct set of options. (This means there are no optional options. - * This makes sense for services, since they shouldn't be constructed by outside code.) + * keys they expect to receive in an array. The convention is to make it a public const called + * CONSTRUCTOR_OPTIONS. In the constructor, they should call assertRequiredOptions() to make sure + * that they weren't passed too few or too many options. This way it's clear what each class + * depends on, and that it's getting passed the correct set of options. (This means there are no + * optional options. This makes sense for services, since they shouldn't be constructed by + * outside code.) * * @since 1.34 */