X-Git-Url: http://git.cyclocoop.org/?a=blobdiff_plain;f=includes%2Fchanges%2FRCCacheEntryFactory.php;h=83720d345355881125048ae5455a7b37fa243ca7;hb=a99171228d167224e376cf584739daf624ebaf71;hp=2d60ca28f7c172318206f30b461e9280f4600769;hpb=243a466018d24415de27815cfae995865c45a66a;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/changes/RCCacheEntryFactory.php b/includes/changes/RCCacheEntryFactory.php
index 2d60ca28f7..83720d3453 100644
--- a/includes/changes/RCCacheEntryFactory.php
+++ b/includes/changes/RCCacheEntryFactory.php
@@ -20,6 +20,7 @@
  * @file
  */
 use MediaWiki\Linker\LinkRenderer;
+use MediaWiki\Revision\RevisionRecord;
 
 class RCCacheEntryFactory {
 
@@ -55,7 +56,6 @@ class RCCacheEntryFactory {
 	 */
 	public function newFromRecentChange( RecentChange $baseRC, $watched ) {
 		$user = $this->context->getUser();
-		$counter = $baseRC->counter;
 
 		$cacheEntry = RCCacheEntry::newFromParent( $baseRC );
 
@@ -72,14 +72,14 @@ class RCCacheEntryFactory {
 		// called too many times (50% of CPU time on RecentChanges!).
 		$showDiffLinks = $this->showDiffLinks( $cacheEntry, $user );
 
-		$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks, $counter );
-		$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks, $counter );
+		$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks );
+		$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks );
 		$cacheEntry->lastlink = $this->buildLastLink( $cacheEntry, $showDiffLinks );
 
 		// Make user links
 		$cacheEntry->userlink = $this->getUserLink( $cacheEntry );
 
-		if ( !ChangesList::isDeleted( $cacheEntry, Revision::DELETED_USER ) ) {
+		if ( !ChangesList::isDeleted( $cacheEntry, RevisionRecord::DELETED_USER ) ) {
 			$cacheEntry->usertalklink = Linker::userToolLinks(
 				$cacheEntry->mAttribs['rc_user'],
 				$cacheEntry->mAttribs['rc_user_text'],
@@ -104,15 +104,15 @@ class RCCacheEntryFactory {
 	 * @return bool
 	 */
 	private function showDiffLinks( RecentChange $cacheEntry, User $user ) {
-		return ChangesList::userCan( $cacheEntry, Revision::DELETED_TEXT, $user );
+		return ChangesList::userCan( $cacheEntry, RevisionRecord::DELETED_TEXT, $user );
 	}
 
 	/**
-	 * @param RecentChange $cacheEntry
+	 * @param RCCacheEntry $cacheEntry
 	 *
 	 * @return string
 	 */
-	private function buildCLink( RecentChange $cacheEntry ) {
+	private function buildCLink( RCCacheEntry $cacheEntry ) {
 		$type = $cacheEntry->mAttribs['rc_type'];
 
 		// New unpatrolled pages
@@ -181,11 +181,10 @@ class RCCacheEntryFactory {
 	/**
 	 * @param RecentChange $cacheEntry
 	 * @param bool $showDiffLinks
-	 * @param int $counter
 	 *
 	 * @return string
 	 */
-	private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
+	private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks ) {
 		$queryParams = $this->buildCurQueryParams( $cacheEntry );
 		$curMessage = $this->getMessage( 'cur' );
 		$logTypes = [ RC_LOG ];
@@ -216,11 +215,10 @@ class RCCacheEntryFactory {
 	/**
 	 * @param RecentChange $cacheEntry
 	 * @param bool $showDiffLinks
-	 * @param int $counter
 	 *
 	 * @return string
 	 */
-	private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
+	private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks ) {
 		$queryParams = $this->buildDiffQueryParams( $cacheEntry );
 		$diffMessage = $this->getMessage( 'diff' );
 		$logTypes = [ RC_NEW, RC_LOG ];
@@ -281,7 +279,7 @@ class RCCacheEntryFactory {
 	 * @return string
 	 */
 	private function getUserLink( RecentChange $cacheEntry ) {
-		if ( ChangesList::isDeleted( $cacheEntry, Revision::DELETED_USER ) ) {
+		if ( ChangesList::isDeleted( $cacheEntry, RevisionRecord::DELETED_USER ) ) {
 			$userLink = ' <span class="history-deleted">' .
 				$this->context->msg( 'rev-deleted-user' )->escaped() . '</span>';
 		} else {