X-Git-Url: http://git.cyclocoop.org/?a=blobdiff_plain;f=includes%2FLinkCache.php;h=4f74cdd70fcd172664f8891a12d5a58318218bde;hb=3141337d77504b52045406c540a371f3444d40fc;hp=55aaae8805df438631837d51ab6da2c93f7afd90;hpb=aed9d4b91218e361e9f6ff72886cd172147aadd3;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/LinkCache.php b/includes/LinkCache.php
index 55aaae8805..4f74cdd70f 100644
--- a/includes/LinkCache.php
+++ b/includes/LinkCache.php
@@ -1,15 +1,14 @@
 <?php
 /**
  * Cache for article titles (prefixed DB keys) and ids linked from one source
- * 
- * @addtogroup Cache
+ *
+ * @ingroup Cache
  */
 class LinkCache {
 	// Increment $mClassVer whenever old serialized versions of this class
 	// becomes incompatible with the new version.
 	/* private */ var $mClassVer = 4;
 
-	/* private */ var $mPageLinks;
 	/* private */ var $mGoodLinks, $mBadLinks;
 	/* private */ var $mForUpdate;
 
@@ -26,39 +25,34 @@ class LinkCache {
 
 	function __construct() {
 		$this->mForUpdate = false;
-		$this->mPageLinks = array();
 		$this->mGoodLinks = array();
 		$this->mGoodLinkFields = array();
 		$this->mBadLinks = array();
 	}
 
-	/* private */ function getKey( $title ) {
-		return wfMemcKey( 'lc', 'title', $title );
-	}
-
 	/**
 	 * General accessor to get/set whether SELECT FOR UPDATE should be used
 	 */
-	function forUpdate( $update = NULL ) {
+	public function forUpdate( $update = NULL ) {
 		return wfSetVar( $this->mForUpdate, $update );
 	}
 
-	function getGoodLinkID( $title ) {
+	public function getGoodLinkID( $title ) {
 		if ( array_key_exists( $title, $this->mGoodLinks ) ) {
 			return $this->mGoodLinks[$title];
 		} else {
 			return 0;
 		}
 	}
-	
+
 	/**
-	 * Get a field of a title object from cache. 
+	 * Get a field of a title object from cache.
 	 * If this link is not good, it will return NULL.
 	 * @param Title $title
 	 * @param string $field ('length','redirect')
 	 * @return mixed
 	 */
-	function getGoodLinkFieldObj( $title, $field ) {
+	public function getGoodLinkFieldObj( $title, $field ) {
 		$dbkey = $title->getPrefixedDbKey();
 		if ( array_key_exists( $dbkey, $this->mGoodLinkFields ) ) {
 			return $this->mGoodLinkFields[$dbkey][$field];
@@ -67,7 +61,7 @@ class LinkCache {
 		}
 	}
 
-	function isBadLink( $title ) {
+	public function isBadLink( $title ) {
 		return array_key_exists( $title, $this->mBadLinks );
 	}
 
@@ -78,45 +72,50 @@ class LinkCache {
 	 * @param int $len
 	 * @param int $redir
 	 */
-	function addGoodLinkObj( $id, $title, $len = -1, $redir = NULL ) {
+	public function addGoodLinkObj( $id, $title, $len = -1, $redir = NULL ) {
 		$dbkey = $title->getPrefixedDbKey();
 		$this->mGoodLinks[$dbkey] = $id;
 		$this->mGoodLinkFields[$dbkey] = array( 'length' => $len, 'redirect' => $redir );
-		$this->mPageLinks[$dbkey] = $title;
 	}
 
-	function addBadLinkObj( $title ) {
+	public function addBadLinkObj( $title ) {
 		$dbkey = $title->getPrefixedDbKey();
-		if ( ! $this->isBadLink( $dbkey ) ) {
+		if ( !$this->isBadLink( $dbkey ) ) {
 			$this->mBadLinks[$dbkey] = 1;
-			$this->mPageLinks[$dbkey] = $title;
 		}
 	}
 
-	function clearBadLink( $title ) {
+	public function clearBadLink( $title ) {
 		unset( $this->mBadLinks[$title] );
-		$this->clearLink( $title );
 	}
 
-	function clearLink( $title ) {
-		global $wgMemc, $wgLinkCacheMemcached;
-		if( $wgLinkCacheMemcached )
-			$wgMemc->delete( $this->getKey( $title ) );
+	public function clearLink( $title ) {
+		$dbkey = $title->getPrefixedDbKey();
+		if( isset($this->mBadLinks[$dbkey]) ) {
+			unset($this->mBadLinks[$dbkey]);
+		}
+		if( isset($this->mGoodLinks[$dbkey]) ) {
+			unset($this->mGoodLinks[$dbkey]);
+		}
+		if( isset($this->mGoodLinkFields[$dbkey]) ) {
+			unset($this->mGoodLinkFields[$dbkey]);
+		}
 	}
 
-	function getPageLinks() { return $this->mPageLinks; }
-	function getGoodLinks() { return $this->mGoodLinks; }
-	function getBadLinks() { return array_keys( $this->mBadLinks ); }
+	public function getGoodLinks() { return $this->mGoodLinks; }
+	public function getBadLinks() { return array_keys( $this->mBadLinks ); }
 
 	/**
 	 * Add a title to the link cache, return the page_id or zero if non-existent
 	 * @param $title String: title to add
+	 * @param $len int, page size
+	 * @param $redir bool, is redirect?
 	 * @return integer
 	 */
-	function addLink( $title ) {
+	public function addLink( $title, $len = -1, $redir = NULL ) {
 		$nt = Title::newFromDBkey( $title );
 		if( $nt ) {
-			return $this->addLinkObj( $nt );
+			return $this->addLinkObj( $nt, $len, $redir );
 		} else {
 			return 0;
 		}
@@ -125,82 +124,72 @@ class LinkCache {
 	/**
 	 * Add a title to the link cache, return the page_id or zero if non-existent
 	 * @param $nt Title to add.
+	 * @param $len int, page size
+	 * @param $redir bool, is redirect?
 	 * @return integer
 	 */
-	function addLinkObj( &$nt ) {
-		global $wgMemc, $wgLinkCacheMemcached, $wgAntiLockFlags;
-		$title = $nt->getPrefixedDBkey();
-		if ( $this->isBadLink( $title ) ) { return 0; }
-		$id = $this->getGoodLinkID( $title );
-		if ( 0 != $id ) { return $id; }
-
-		$fname = 'LinkCache::addLinkObj';
-		global $wgProfiler;
-		if ( isset( $wgProfiler ) ) {
-			$fname .= ' (' . $wgProfiler->getCurrentSection() . ')';
-		}
+	public function addLinkObj( &$nt, $len = -1, $redirect = NULL ) {
+		global $wgAntiLockFlags, $wgProfiler;
+		wfProfileIn( __METHOD__ );
 
-		wfProfileIn( $fname );
-
-		$ns = $nt->getNamespace();
-		$t = $nt->getDBkey();
+		$key = $nt->getPrefixedDBkey();
+		if ( $this->isBadLink( $key ) ) {
+			wfProfileOut( __METHOD__ );
+			return 0;
+		}
+		$id = $this->getGoodLinkID( $key );
+		if ( $id != 0 ) {
+			wfProfileOut( __METHOD__ );
+			return $id;
+		}
 
-		if ( '' == $title ) {
-			wfProfileOut( $fname );
+		if ( $key === '' ) {
+			wfProfileOut( __METHOD__ );
 			return 0;
 		}
-		# Some fields heavily used for linking...
-		$id = NULL;
-		$len = -1;
-		$redirect = NULL;
 		
-		if( $wgLinkCacheMemcached ) {
-			$id = $wgMemc->get( $key = $this->getKey( $title ) );
-		}
-		if( !is_integer( $id ) ) {
-			if ( $this->mForUpdate ) {
-				$db = wfGetDB( DB_MASTER );
-				if ( !( $wgAntiLockFlags & ALF_NO_LINK_LOCK ) ) {
-					$options = array( 'FOR UPDATE' );
-				} else {
-					$options = array();
-				}
+		# Some fields heavily used for linking...
+		if ( $this->mForUpdate ) {
+			$db = wfGetDB( DB_MASTER );
+			if ( !( $wgAntiLockFlags & ALF_NO_LINK_LOCK ) ) {
+				$options = array( 'FOR UPDATE' );
 			} else {
-				$db = wfGetDB( DB_SLAVE );
 				$options = array();
 			}
+		} else {
+			$db = wfGetDB( DB_SLAVE );
+			$options = array();
+		}
 
-			$s = $db->selectRow( 'page', 
-				array( 'page_id', 'page_len', 'page_is_redirect' ),
-				array( 'page_namespace' => $ns, 'page_title' => $t ),
-				$fname, $options );
-			# Set fields...
-			$id = $s ? $s->page_id : 0;
-			$len = $s ? $s->page_len : -1;
-			$redirect = $s ? $s->page_is_redirect : 0;
-
-			if( $wgLinkCacheMemcached ) {
-				$wgMemc->add( $key, $id, 3600*24 );
-			}
+		$s = $db->selectRow( 'page', 
+			array( 'page_id', 'page_len', 'page_is_redirect' ),
+			array( 'page_namespace' => $nt->getNamespace(), 'page_title' => $nt->getDBkey() ),
+			__METHOD__, $options );
+		# Set fields...
+		if ( $s !== false ) {
+			$id = $s->page_id;
+			$len = $s->page_len;
+			$redirect = $s->page_is_redirect;
+		} else {
+			$len = -1;
+			$redirect = 0;
 		}
 
-		if( 0 == $id ) {
+		if ( $id == 0 ) {
 			$this->addBadLinkObj( $nt );
 		} else {
 			$this->addGoodLinkObj( $id, $nt, $len, $redirect );
 		}
-		wfProfileOut( $fname );
+		wfProfileOut( __METHOD__ );
 		return $id;
 	}
 
 	/**
 	 * Clears cache
 	 */
-	function clear() {
-		$this->mPageLinks = array();
+	public function clear() {
 		$this->mGoodLinks = array();
 		$this->mGoodLinkFields = array();
 		$this->mBadLinks = array();
 	}
 }
-