Convert all array() syntax to []

[lhc/web/wiklou.git] / tests / phpunit / includes / RevisionStorageTest.php

diff --git a/tests/phpunit/includes/RevisionStorageTest.php b/tests/phpunit/includes/RevisionStorageTest.php
index 301ec5c..16d8c97 100644 (file)
--- a/tests/phpunit/includes/RevisionStorageTest.php
+++ b/tests/phpunit/includes/RevisionStorageTest.php
@@ -16,11 +16,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
         */
        private $the_page;
 
-       function __construct( $name = null, array $data = array(), $dataName = '' ) {
+       function __construct( $name = null, array $data = [], $dataName = '' ) {
                parent::__construct( $name, $data, $dataName );
 
                $this->tablesUsed = array_merge( $this->tablesUsed,
-                       array( 'page',
+                       [ 'page',
                                'revision',
                                'text',
 
@@ -34,7 +34,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                                'externallinks',
                                'imagelinks',
                                'templatelinks',
-                               'iwlinks' ) );
+                               'iwlinks' ] );
        }
 
        protected function setUp() {
@@ -76,7 +76,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
 
        protected function makeRevision( $props = null ) {
                if ( $props === null ) {
-                       $props = array();
+                       $props = [];
                }
 
                if ( !isset( $props['content'] ) && !isset( $props['text'] ) ) {
@@ -144,7 +144,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $orig = $this->makeRevision();
 
                $dbr = wfgetDB( DB_SLAVE );
-               $res = $dbr->select( 'revision', '*', array( 'rev_id' => $orig->getId() ) );
+               $res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
                $this->assertTrue( is_object( $res ), 'query failed' );
 
                $row = $res->fetchObject();
@@ -162,7 +162,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $orig = $this->makeRevision();
 
                $dbr = wfgetDB( DB_SLAVE );
-               $res = $dbr->select( 'revision', '*', array( 'rev_id' => $orig->getId() ) );
+               $res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
                $this->assertTrue( is_object( $res ), 'query failed' );
 
                $row = $res->fetchObject();
@@ -186,7 +186,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $page->doDeleteArticle( 'test Revision::newFromArchiveRow' );
 
                $dbr = wfgetDB( DB_SLAVE );
-               $res = $dbr->select( 'archive', '*', array( 'ar_rev_id' => $orig->getId() ) );
+               $res = $dbr->select( 'archive', '*', [ 'ar_rev_id' => $orig->getId() ] );
                $this->assertTrue( is_object( $res ), 'query failed' );
 
                $row = $res->fetchObject();
@@ -227,7 +227,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $res = Revision::fetchRevision( $page->getTitle() );
 
                # note: order is unspecified
-               $rows = array();
+               $rows = [];
                while ( ( $row = $res->fetchObject() ) ) {
                        $rows[$row->rev_id] = $row;
                }
@@ -266,7 +266,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
        public function testGetPage() {
                $page = $this->the_page;
 
-               $orig = $this->makeRevision( array( 'page' => $page->getId() ) );
+               $orig = $this->makeRevision( [ 'page' => $page->getId() ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( $page->getId(), $rev->getPage() );
@@ -278,7 +278,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
        public function testGetText() {
                $this->hideDeprecated( 'Revision::getText' );
 
-               $orig = $this->makeRevision( array( 'text' => 'hello hello.' ) );
+               $orig = $this->makeRevision( [ 'text' => 'hello hello.' ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( 'hello hello.', $rev->getText() );
@@ -288,11 +288,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
         * @covers Revision::getContent
         */
        public function testGetContent_failure() {
-               $rev = new Revision( array(
+               $rev = new Revision( [
                        'page' => $this->the_page->getId(),
                        'content_model' => $this->the_page->getContentModel(),
                        'text_id' => 123456789, // not in the test DB
-               ) );
+               ] );
 
                $this->assertNull( $rev->getContent(),
                        "getContent() should return null if the revision's text blob could not be loaded." );
@@ -306,7 +306,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
         * @covers Revision::getContent
         */
        public function testGetContent() {
-               $orig = $this->makeRevision( array( 'text' => 'hello hello.' ) );
+               $orig = $this->makeRevision( [ 'text' => 'hello hello.' ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( 'hello hello.', $rev->getContent()->getNativeData() );
@@ -318,7 +318,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
        public function testGetRawText() {
                $this->hideDeprecated( 'Revision::getRawText' );
 
-               $orig = $this->makeRevision( array( 'text' => 'hello hello raw.' ) );
+               $orig = $this->makeRevision( [ 'text' => 'hello hello raw.' ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( 'hello hello raw.', $rev->getRawText() );
@@ -334,8 +334,8 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        $this->markTestSkipped( '$wgContentHandlerUseDB is disabled' );
                }
 
-               $orig = $this->makeRevision( array( 'text' => 'hello hello.',
-                       'content_model' => CONTENT_MODEL_JAVASCRIPT ) );
+               $orig = $this->makeRevision( [ 'text' => 'hello hello.',
+                       'content_model' => CONTENT_MODEL_JAVASCRIPT ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( CONTENT_MODEL_JAVASCRIPT, $rev->getContentModel() );
@@ -351,11 +351,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        $this->markTestSkipped( '$wgContentHandlerUseDB is disabled' );
                }
 
-               $orig = $this->makeRevision( array(
+               $orig = $this->makeRevision( [
                        'text' => 'hello hello.',
                        'content_model' => CONTENT_MODEL_JAVASCRIPT,
                        'content_format' => CONTENT_FORMAT_JAVASCRIPT
-               ) );
+               ] );
                $rev = Revision::newFromId( $orig->getId() );
 
                $this->assertEquals( CONTENT_FORMAT_JAVASCRIPT, $rev->getContentFormat() );
@@ -461,20 +461,20 @@ class RevisionStorageTest extends MediaWikiTestCase {
        }
 
        public static function provideUserWasLastToEdit() {
-               return array(
-                       array( # 0
+               return [
+                       [ # 0
                                3, true, # actually the last edit
-                       ),
-                       array( # 1
+                       ],
+                       [ # 1
                                2, true, # not the current edit, but still by this user
-                       ),
-                       array( # 2
+                       ],
+                       [ # 2
                                1, false, # edit by another user
-                       ),
-                       array( # 3
+                       ],
+                       [ # 3
                                0, false, # first edit, by this user, but another user edited in the mean time
-                       ),
-               );
+                       ],
+               ];
        }
 
        /**
@@ -495,7 +495,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $ns = $this->getDefaultWikitextNS();
 
                $dbw = wfGetDB( DB_MASTER );
-               $revisions = array();
+               $revisions = [];
 
                // create revisions -----------------------------
                $page = WikiPage::factory( Title::newFromText(
@@ -503,7 +503,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                $page->insertOn( $dbw );
 
                # zero
-               $revisions[0] = new Revision( array(
+               $revisions[0] = new Revision( [
                        'page' => $page->getId(),
                        // we need the title to determine the page's default content model
                        'title' => $page->getTitle(),
@@ -512,11 +512,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        'text' => 'zero',
                        'content_model' => CONTENT_MODEL_WIKITEXT,
                        'summary' => 'edit zero'
-               ) );
+               ] );
                $revisions[0]->insertOn( $dbw );
 
                # one
-               $revisions[1] = new Revision( array(
+               $revisions[1] = new Revision( [
                        'page' => $page->getId(),
                        // still need the title, because $page->getId() is 0 (there's no entry in the page table)
                        'title' => $page->getTitle(),
@@ -525,11 +525,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        'text' => 'one',
                        'content_model' => CONTENT_MODEL_WIKITEXT,
                        'summary' => 'edit one'
-               ) );
+               ] );
                $revisions[1]->insertOn( $dbw );
 
                # two
-               $revisions[2] = new Revision( array(
+               $revisions[2] = new Revision( [
                        'page' => $page->getId(),
                        'title' => $page->getTitle(),
                        'timestamp' => '20120101000200',
@@ -537,11 +537,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        'text' => 'two',
                        'content_model' => CONTENT_MODEL_WIKITEXT,
                        'summary' => 'edit two'
-               ) );
+               ] );
                $revisions[2]->insertOn( $dbw );
 
                # three
-               $revisions[3] = new Revision( array(
+               $revisions[3] = new Revision( [
                        'page' => $page->getId(),
                        'title' => $page->getTitle(),
                        'timestamp' => '20120101000300',
@@ -549,11 +549,11 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        'text' => 'three',
                        'content_model' => CONTENT_MODEL_WIKITEXT,
                        'summary' => 'edit three'
-               ) );
+               ] );
                $revisions[3]->insertOn( $dbw );
 
                # four
-               $revisions[4] = new Revision( array(
+               $revisions[4] = new Revision( [
                        'page' => $page->getId(),
                        'title' => $page->getTitle(),
                        'timestamp' => '20120101000200',
@@ -561,7 +561,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
                        'text' => 'zero',
                        'content_model' => CONTENT_MODEL_WIKITEXT,
                        'summary' => 'edit four'
-               ) );
+               ] );
                $revisions[4]->insertOn( $dbw );
 
                // test it ---------------------------------