Fu r93351: remove extra space

[lhc/web/wiklou.git] / resources / mediawiki.special / mediawiki.special.recentchanges.js

diff --git a/resources/mediawiki.special/mediawiki.special.recentchanges.js b/resources/mediawiki.special/mediawiki.special.recentchanges.js
index 294417c..7e284fb 100644 (file)
--- a/resources/mediawiki.special/mediawiki.special.recentchanges.js
+++ b/resources/mediawiki.special/mediawiki.special.recentchanges.js
@@ -3,38 +3,37 @@
 
        var checkboxes = [ 'nsassociated', 'nsinvert' ];
 
-       mw.special.recentchanges = {
+       /**
+        * @var select {jQuery}
+        */
+       var $select = null;
 
-               /**
-                * @var select {jQuery}
-                */
-               $select: null,
-
-               init: function() {
-                       var rc = this;
-
-                       rc.$select = 
-                               $( 'select#namespace' )
-                                       .change( rc.updateCheckboxes )
-                                       // Trigger once set the initial statuses of the checkboxes.
-                                       .change();
-               },
+       var rc = mw.special.recentchanges = {
        
                /**
                 * Handler to disable/enable the namespace selector checkboxes when the
                 * special 'all' namespace is selected/unselected respectively.
                 */
                updateCheckboxes: function() {
-                       // The 'all' namespace is the FIRST in the list.
-                       var isAllNS = mw.special.recentchanges.$select.find( 'option' ).first().is( ':selected' );
+                       // The option element for the 'all' namespace has an empty value
+                       var isAllNS = ('' === $select.find('option:selected').val() );
 
                        // Iterates over checkboxes and propagate the selected option
-                       $.map( checkboxes, function( id ) {
-                               $( '#'+id ).attr( 'disabled', isAllNS );
+                       $.each( checkboxes, function( i, id ) {
+                               $( '#' + id ).attr( 'disabled', isAllNS );
                        });
                },
+
+               init: function() {
+                       // Populate
+                       $select = $( '#namespace' );
+
+                       // Bind to change event, and trigger once to set the initial state of the checkboxes.
+                       $select.change( rc.updateCheckboxes ).change();
+               }
        };
 
-       mw.special.recentchanges.init();
+       // Run when document is ready
+       $( rc.init );
 
 })( jQuery );