* (Bug 25451) Language::time() and ::date() misfunction when given timestamps in...

[lhc/web/wiklou.git] / maintenance / updateArticleCount.php

diff --git a/maintenance/updateArticleCount.php b/maintenance/updateArticleCount.php
index d2776e5..1e434eb 100644 (file)
--- a/maintenance/updateArticleCount.php
+++ b/maintenance/updateArticleCount.php
@@ -18,11 +18,12 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
+ * @file
  * @ingroup Maintenance
  * @author Rob Church <robchur@gmail.com>
  */
 
-require_once( dirname(__FILE__) . '/Maintenance.php' );
+require_once( dirname( __FILE__ ) . '/Maintenance.php' );
 
 class UpdateArticleCount extends Maintenance {
 
@@ -41,9 +42,9 @@ class UpdateArticleCount extends Maintenance {
                $this->output( "Counting articles..." );
                $result = $this->count();
        
-               if( $result !== false ) {
+               if ( $result !== false ) {
                        $this->output( "found {$result}.\n" );
-                       if( $this->hasOption( 'update' ) ) {
+                       if ( $this->hasOption( 'update' ) ) {
                                $this->output( "Updating site statistics table... " );
                                $dbw = wfGetDB( DB_MASTER );
                                $dbw->update( 'site_stats', array( 'ss_good_articles' => $result ), array( 'ss_row_id' => 1 ), __METHOD__ );
@@ -63,7 +64,7 @@ class UpdateArticleCount extends Maintenance {
         * @return string
         */
        private function makeNsSet() {
-               foreach( $this->namespaces as $namespace )
+               foreach ( $this->namespaces as $namespace )
                        $namespaces[] = intval( $namespace );
                return implode( ', ', $namespaces );
        }
@@ -77,7 +78,7 @@ class UpdateArticleCount extends Maintenance {
        private function makeSql( $dbr ) {
                list( $page, $pagelinks ) = $dbr->tableNamesN( 'page', 'pagelinks' );
                $nsset = $this->makeNsSet();
-               return "SELECT COUNT(DISTINCT page_namespace, page_title) AS pagecount " .
+               return "SELECT COUNT(DISTINCT page_id) AS pagecount " .
                        "FROM $page, $pagelinks " .
                        "WHERE pl_from=page_id and page_namespace IN ( $nsset ) " .
                        "AND page_is_redirect = 0 AND page_len > 0";
@@ -92,7 +93,6 @@ class UpdateArticleCount extends Maintenance {
                $dbr = wfGetDB( DB_SLAVE );
                $res = $dbr->query( $this->makeSql( $dbr ), __METHOD__ );
                $row = $dbr->fetchObject( $res );
-               $dbr->freeResult( $res );
                return $row ? $row->pagecount : false;
        }
 }