$tags = $params['tags'];
// Check if user can add tags
- if ( !is_null( $tags ) ) {
+ if ( $tags !== null ) {
$ableToTag = ChangeTags::canAddTagsAccompanyingChange( $tags, $pUser );
if ( !$ableToTag->isOK() ) {
$this->dieStatus( $ableToTag );
$r['user'] = $user->getName();
$r['userid'] = $user->getId();
list( $r['added'], $r['removed'] ) = $form->doSaveUserGroups(
+ // Don't pass null to doSaveUserGroups() for array params, cast to empty array
$user, (array)$add, (array)$params['remove'],
- $params['reason'], $tags, $groupExpiries
+ $params['reason'], (array)$tags, $groupExpiries
);
$result = $this->getResult();
$this->requireOnlyOneParameter( $params, 'user', 'userid' );
- $user = isset( $params['user'] ) ? $params['user'] : '#' . $params['userid'];
+ $user = $params['user'] ?? '#' . $params['userid'];
$form = $this->getUserRightsPage();
$form->setContext( $this->getContext() );