(bug 32412) TOC links on [[Special:EditWatchlist]] now points to the fieldset
[lhc/web/wiklou.git] / includes / User.php
index f86e112..229868f 100644 (file)
@@ -143,7 +143,6 @@ class User {
                'reupload',
                'reupload-shared',
                'rollback',
-               'selenium',
                'sendemail',
                'siteadmin',
                'suppressionlog',
@@ -169,7 +168,7 @@ class User {
        var $mId, $mName, $mRealName, $mPassword, $mNewpassword, $mNewpassTime,
                $mEmail, $mTouched, $mToken, $mEmailAuthenticated,
                $mEmailToken, $mEmailTokenExpires, $mRegistration, $mGroups, $mOptionOverrides,
-               $mCookiePassword;
+               $mCookiePassword, $mEditCount, $mAllowUsertalk;
        //@}
 
        /**
@@ -199,8 +198,8 @@ class User {
         * Lazy-initialized variables, invalidated with clearInstanceCache
         */
        var $mNewtalk, $mDatePreference, $mBlockedby, $mHash, $mRights,
-               $mBlockreason, $mEffectiveGroups, $mFormerGroups, $mBlockedGlobally,
-               $mLocked, $mHideName, $mOptions;
+               $mBlockreason, $mEffectiveGroups, $mImplicitGroups, $mFormerGroups, $mBlockedGlobally,
+               $mLocked, $mHideName, $mOptions, $mDisplayName;
 
        /**
         * @var WebRequest
@@ -211,6 +210,10 @@ class User {
         * @var Block
         */
        var $mBlock;
+
+       /**
+        * @var Block
+        */
        private $mBlockedFromCreateAccount = false;
 
        static $idCacheByName = array();
@@ -229,6 +232,9 @@ class User {
                $this->clearInstanceCache( 'defaults' );
        }
 
+       /**
+        * @return String
+        */
        function __toString(){
                return $this->getName();
        }
@@ -275,7 +281,7 @@ class User {
         * Load user table data, given mId has already been set.
         * @return Bool false if the ID does not exist, true otherwise
         */
-       private function loadFromId() {
+       public function loadFromId() {
                global $wgMemc;
                if ( $this->mId == 0 ) {
                        $this->loadDefaults();
@@ -438,13 +444,12 @@ class User {
 
        //@}
 
-
        /**
         * Get the username corresponding to a given user ID
         * @param $id Int User ID
-        * @return String The corresponding username
+        * @return String|false The corresponding username
         */
-       static function whoIs( $id ) {
+       public static function whoIs( $id ) {
                $dbr = wfGetDB( DB_SLAVE );
                return $dbr->selectField( 'user', 'user_name', array( 'user_id' => $id ), __METHOD__ );
        }
@@ -453,7 +458,7 @@ class User {
         * Get the real name of a user given their user ID
         *
         * @param $id Int User ID
-        * @return String The corresponding user's real name
+        * @return String|false The corresponding user's real name
         */
        public static function whoIsReal( $id ) {
                $dbr = wfGetDB( DB_SLAVE );
@@ -738,6 +743,8 @@ class User {
         *                - 'valid'      Valid for batch processes
         *                - 'usable'     Valid for batch processes and login
         *                - 'creatable'  Valid for batch processes, login and account creation
+        *
+        * @return bool|string
         */
        public static function getCanonicalName( $name, $validate = 'valid' ) {
                # Force usernames to capital
@@ -848,8 +855,10 @@ class User {
         *
         * @note This no longer clears uncached lazy-initialised properties;
         *       the constructor does that instead.
+        *
+        * @param $name string
         */
-       private function loadDefaults( $name = false ) {
+       public function loadDefaults( $name = false ) {
                wfProfileIn( __METHOD__ );
 
                $this->mId = 0;
@@ -1006,7 +1015,7 @@ class User {
         *
         * @return Bool True if the user exists, false if the user is anonymous
         */
-       private function loadFromDatabase() {
+       public function loadFromDatabase() {
                # Paranoia
                $this->mId = intval( $this->mId );
 
@@ -1043,6 +1052,8 @@ class User {
        public function loadFromRow( $row ) {
                $all = true;
 
+               $this->mGroups = null; // deferred
+
                if ( isset( $row->user_name ) ) {
                        $this->mName = $row->user_name;
                        $this->mFrom = 'name';
@@ -1066,19 +1077,26 @@ class User {
                        $all = false;
                }
 
+               if ( isset( $row->user_editcount ) ) {
+                       $this->mEditCount = $row->user_editcount;
+               } else {
+                       $all = false;
+               }
+
                if ( isset( $row->user_password ) ) {
                        $this->mPassword = $row->user_password;
                        $this->mNewpassword = $row->user_newpassword;
                        $this->mNewpassTime = wfTimestampOrNull( TS_MW, $row->user_newpass_time );
                        $this->mEmail = $row->user_email;
-                       $this->decodeOptions( $row->user_options );
-                       $this->mTouched = wfTimestamp(TS_MW,$row->user_touched);
+                       if ( isset( $row->user_options ) ) {
+                               $this->decodeOptions( $row->user_options );
+                       }
+                       $this->mTouched = wfTimestamp( TS_MW, $row->user_touched );
                        $this->mToken = $row->user_token;
                        $this->mEmailAuthenticated = wfTimestampOrNull( TS_MW, $row->user_email_authenticated );
                        $this->mEmailToken = $row->user_email_token;
                        $this->mEmailTokenExpires = wfTimestampOrNull( TS_MW, $row->user_email_token_expires );
                        $this->mRegistration = wfTimestampOrNull( TS_MW, $row->user_registration );
-                       $this->mEditCount = $row->user_editcount;
                } else {
                        $all = false;
                }
@@ -1150,6 +1168,7 @@ class User {
                                $log->addEntry( 'autopromote',
                                        $this->getUserPage(),
                                        '', // no comment
+                                       // These group names are "list to texted"-ed in class LogPage.
                                        array( implode( ', ', $oldGroups ), implode( ', ', $newGroups ) )
                                );
                        }
@@ -1159,7 +1178,7 @@ class User {
 
        /**
         * Clear various cached data stored in this object.
-        * @param $reloadFrom String Reload user and user_groups table data from a
+        * @param $reloadFrom bool|String Reload user and user_groups table data from a
         *   given source. May be "name", "id", "defaults", "session", or false for
         *   no reload.
         */
@@ -1170,7 +1189,9 @@ class User {
                $this->mHash = false;
                $this->mRights = null;
                $this->mEffectiveGroups = null;
+               $this->mImplicitGroups = null;
                $this->mOptions = null;
+               $this->mDisplayName = null;
 
                if ( $reloadFrom ) {
                        $this->mLoadedItems = array();
@@ -1197,6 +1218,14 @@ class User {
                }
                $defOpt['skin'] = $wgDefaultSkin;
 
+               // FIXME: Ideally we'd cache the results of this function so the hook is only run once,
+               // but that breaks the parser tests because they rely on being able to change $wgContLang
+               // mid-request and see that change reflected in the return value of this function.
+               // Which is insane and would never happen during normal MW operation, but is also not
+               // likely to get fixed unless and until we context-ify everything.
+               // See also https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101488#c25275
+               wfRunHooks( 'UserGetDefaultOptions', array( &$defOpt ) );
+
                return $defOpt;
        }
 
@@ -1248,7 +1277,7 @@ class User {
                # user is not immune to autoblocks/hardblocks, and they are the current user so we
                # know which IP address they're actually coming from
                if ( !$this->isAllowed( 'ipblock-exempt' ) && $this->getID() == $wgUser->getID() ) {
-                       $ip = wfGetIP();
+                       $ip = $this->getRequest()->getIP();
                } else {
                        $ip = null;
                }
@@ -1261,9 +1290,6 @@ class User {
                        $this->mBlockreason = $this->mBlock->mReason;
                        $this->mHideName = $this->mBlock->mHideName;
                        $this->mAllowUsertalk = !$this->mBlock->prevents( 'editownusertalk' );
-                       if ( $this->isLoggedIn() && $wgUser->getID() == $this->getID() ) {
-                               $this->spreadBlock();
-                       }
                }
 
                # Proxy blocking
@@ -1328,7 +1354,17 @@ class User {
 
                        foreach( (array)$bases as $base ) {
                                # Make hostname
-                               $host = "$ipReversed.$base";
+                               # If we have an access key, use that too (ProjectHoneypot, etc.)
+                               if( is_array( $base ) ) {
+                                       if( count( $base ) >= 2 ) {
+                                               # Access key is 1, base URL is 0
+                                               $host = "{$base[1]}.$ipReversed.{$base[0]}";
+                                       } else {
+                                               $host = "$ipReversed.{$base[0]}";
+                                       }
+                               } else {
+                                       $host = "$ipReversed.$base";
+                               }
 
                                # Send query
                                $ipList = gethostbynamel( $host );
@@ -1349,6 +1385,9 @@ class User {
 
        /**
         * Check if an IP address is in the local proxy list
+        *
+        * @param $ip string
+        *
         * @return bool
         */
        public static function isLocallyBlockedProxy( $ip ) {
@@ -1385,7 +1424,7 @@ class User {
         */
        public function isPingLimitable() {
                global $wgRateLimitsExcludedIPs;
-               if( in_array( wfGetIP(), $wgRateLimitsExcludedIPs ) ) {
+               if( in_array( $this->getRequest()->getIP(), $wgRateLimitsExcludedIPs ) ) {
                        // No other good way currently to disable rate limits
                        // for specific IPs. :P
                        // But this is a crappy hack and should die.
@@ -1426,7 +1465,7 @@ class User {
                $limits = $wgRateLimits[$action];
                $keys = array();
                $id = $this->getId();
-               $ip = wfGetIP();
+               $ip = $this->getRequest()->getIP();
                $userLimit = false;
 
                if( isset( $limits['anon'] ) && $id == 0 ) {
@@ -1500,8 +1539,18 @@ class User {
         * @return Bool True if blocked, false otherwise
         */
        public function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
+               return $this->getBlock( $bFromSlave ) instanceof Block && $this->getBlock()->prevents( 'edit' );
+       }
+
+       /**
+        * Get the block affecting the user, or null if the user is not blocked
+        *
+        * @param $bFromSlave Bool Whether to check the slave database instead of the master
+        * @return Block|null
+        */
+       public function getBlock( $bFromSlave = true ){
                $this->getBlockedStatus( $bFromSlave );
-               return $this->mBlock instanceof Block && $this->mBlock->prevents( 'edit' );
+               return $this->mBlock instanceof Block ? $this->mBlock : null;
        }
 
        /**
@@ -1573,7 +1622,7 @@ class User {
                if( IP::isIPAddress( $this->getName() ) ) {
                        $ip = $this->getName();
                } elseif( !$ip ) {
-                       $ip = wfGetIP();
+                       $ip = $this->getRequest()->getIP();
                }
                $blocked = false;
                wfRunHooks( 'UserIsBlockedGlobally', array( &$this, $ip, &$blocked ) );
@@ -1651,7 +1700,7 @@ class User {
                        $this->load();
                        if ( $this->mName === false ) {
                                # Clean up IPs
-                               $this->mName = IP::sanitizeIP( wfGetIP() );
+                               $this->mName = IP::sanitizeIP( $this->getRequest()->getIP() );
                        }
                        return $this->mName;
                }
@@ -1882,6 +1931,8 @@ class User {
        /**
         * Validate the cache for this account.
         * @param $timestamp String A timestamp in TS_MW format
+        *
+        * @return bool
         */
        public function validateCache( $timestamp ) {
                $this->load();
@@ -1910,6 +1961,8 @@ class User {
         *
         * @param $str String New password to set
         * @throws PasswordError on failure
+        *
+        * @return bool
         */
        public function setPassword( $str ) {
                global $wgAuth;
@@ -1974,7 +2027,7 @@ class User {
         * Set the random token (used for persistent authentication)
         * Called from loadDefaults() among other places.
         *
-        * @param $token String If specified, set the token to this value
+        * @param $token String|bool If specified, set the token to this value
         */
        public function setToken( $token = false ) {
                global $wgSecretKey, $wgProxyKey;
@@ -2083,6 +2136,32 @@ class User {
                $this->mRealName = $str;
        }
 
+       /**
+        * Return the name of this user we should used to display in the user interface
+        * @return String The user's display name
+        */
+       public function getDisplayName() {
+               global $wgRealNameInInterface;
+               if ( is_null( $this->mDisplayName ) ) {
+                       $displayName = null;
+                       
+                       // Allow hooks to set a display name
+                       wfRunHooks( 'UserDisplayName', array( $this, &$displayName ) );
+
+                       if ( is_null( $displayName ) && $wgRealNameInInterface && $this->getRealName() ) {
+                               // If $wgRealNameInInterface is true use the real name as the display name if it's set
+                               $displayName = $this->getRealName();
+                       }
+                       
+                       if ( is_null( $displayName ) ) {
+                               $displayName = $this->getName();
+                       }
+
+                       $this->mDisplayName = $displayName;
+               }
+               return $this->mDisplayName;
+       }
+
        /**
         * Get the user's current setting for a given option.
         *
@@ -2218,6 +2297,8 @@ class User {
 
        /**
         * Get the user preferred stub threshold
+        *
+        * @return int
         */
        public function getStubThreshold() {
                global $wgMaxArticleSize; # Maximum article size, in Kb
@@ -2264,6 +2345,7 @@ class User {
         */
        public function getGroups() {
                $this->load();
+               $this->loadGroups();
                return $this->mGroups;
        }
 
@@ -2277,22 +2359,44 @@ class User {
        public function getEffectiveGroups( $recache = false ) {
                if ( $recache || is_null( $this->mEffectiveGroups ) ) {
                        wfProfileIn( __METHOD__ );
-                       $this->mEffectiveGroups = $this->getGroups();
-                       $this->mEffectiveGroups[] = '*';
-                       if( $this->getId() ) {
-                               $this->mEffectiveGroups[] = 'user';
+                       $this->mEffectiveGroups = array_unique( array_merge(
+                               $this->getGroups(), // explicit groups
+                               $this->getAutomaticGroups( $recache ) // implicit groups
+                       ) );
+                       # Hook for additional groups
+                       wfRunHooks( 'UserEffectiveGroups', array( &$this, &$this->mEffectiveGroups ) );
+                       wfProfileOut( __METHOD__ );
+               }
+               return $this->mEffectiveGroups;
+       }
 
-                               $this->mEffectiveGroups = array_unique( array_merge(
-                                       $this->mEffectiveGroups,
+       /**
+        * Get the list of implicit group memberships this user has.
+        * This includes 'user' if logged in, '*' for all accounts,
+        * and autopromoted groups
+        * @param $recache Bool Whether to avoid the cache
+        * @return Array of String internal group names
+        */
+       public function getAutomaticGroups( $recache = false ) {
+               if ( $recache || is_null( $this->mImplicitGroups ) ) {
+                       wfProfileIn( __METHOD__ );
+                       $this->mImplicitGroups = array( '*' );
+                       if ( $this->getId() ) {
+                               $this->mImplicitGroups[] = 'user';
+
+                               $this->mImplicitGroups = array_unique( array_merge(
+                                       $this->mImplicitGroups,
                                        Autopromote::getAutopromoteGroups( $this )
                                ) );
-
-                               # Hook for additional groups
-                               wfRunHooks( 'UserEffectiveGroups', array( &$this, &$this->mEffectiveGroups ) );
+                       }
+                       if ( $recache ) {
+                               # Assure data consistency with rights/groups,
+                               # as getEffectiveGroups() depends on this function
+                               $this->mEffectiveGroups = null;
                        }
                        wfProfileOut( __METHOD__ );
                }
-               return $this->mEffectiveGroups;
+               return $this->mImplicitGroups;
        }
 
        /**
@@ -2409,8 +2513,11 @@ class User {
 
        /**
         * Check if user is allowed to access a feature / make an action
-        * @param varargs String permissions to test
+        *
+        * @internal param \String $varargs permissions to test
         * @return Boolean: True if user is allowed to perform *any* of the given actions
+        *
+        * @return bool
         */
        public function isAllowedAny( /*...*/ ){
                $permissions = func_get_args();
@@ -2423,7 +2530,8 @@ class User {
        }
 
        /**
-        * @param varargs String
+        *
+        * @internal param $varargs string
         * @return bool True if the user is allowed to perform *all* of the given actions
         */
        public function isAllowedAll( /*...*/ ){
@@ -2439,7 +2547,7 @@ class User {
        /**
         * Internal mechanics of testing a permission
         * @param $action String
-        * @paramn $ns int Namespace optional
+        * @param $ns int|null Namespace optional
         * @return bool
         */
        public function isAllowed( $action = '', $ns = null ) {
@@ -2529,6 +2637,14 @@ class User {
                $this->invalidateCache();
        }
 
+       /**
+        * Cleans up watchlist by removing invalid entries from it
+        */
+       public function cleanupWatchlist() {
+               $dbw = wfGetDB( DB_MASTER );
+               $dbw->delete( 'watchlist', array( 'wl_namespace < 0', 'wl_user' => $this->getId() ), __METHOD__ );
+       }
+
        /**
         * Clear the user's notification timestamp for the given title.
         * If e-notif e-mails are on, they will receive notification mails on
@@ -2616,6 +2732,8 @@ class User {
        /**
         * Set this user's options from an encoded string
         * @param $str String Encoded options to import
+        *
+        * @deprecated in 1.19 due to removal of user_options from the user table
         */
        private function decodeOptions( $str ) {
                if( !$str )
@@ -2712,7 +2830,7 @@ class User {
         * Clear the user's cookies and session, and reset the instance cache.
         * @see logout()
         */
-       private function doLogout() {
+       public function doLogout() {
                $this->clearInstanceCache( 'defaults' );
 
                $this->getRequest()->setSessionData( 'wsUserID', 0 );
@@ -2745,7 +2863,6 @@ class User {
                                'user_real_name' => $this->mRealName,
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
-                               'user_options' => '',
                                'user_touched' => $dbw->timestamp( $this->mTouched ),
                                'user_token' => $this->mToken,
                                'user_email_token' => $this->mEmailToken,
@@ -2813,7 +2930,6 @@ class User {
                        'user_email' => $user->mEmail,
                        'user_email_authenticated' => $dbw->timestampOrNull( $user->mEmailAuthenticated ),
                        'user_real_name' => $user->mRealName,
-                       'user_options' => '',
                        'user_token' => $user->mToken,
                        'user_registration' => $dbw->timestamp( $user->mRegistration ),
                        'user_editcount' => 0,
@@ -2847,7 +2963,6 @@ class User {
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
                                'user_real_name' => $this->mRealName,
-                               'user_options' => '',
                                'user_token' => $this->mToken,
                                'user_registration' => $dbw->timestamp( $this->mRegistration ),
                                'user_editcount' => 0,
@@ -2862,22 +2977,35 @@ class User {
        }
 
        /**
-        * If this (non-anonymous) user is blocked, block any IP address
-        * they've successfully logged in from.
+        * If this user is logged-in and blocked,
+        * block any IP address they've successfully logged in from.
+        * @return bool A block was spread
         */
-       public function spreadBlock() {
+       public function spreadAnyEditBlock() {
+               if ( $this->isLoggedIn() && $this->isBlocked() ) {
+                       return $this->spreadBlock();
+               }
+               return false;
+       }
+
+       /**
+        * If this (non-anonymous) user is blocked,
+        * block the IP address they've successfully logged in from.
+        * @return bool A block was spread
+        */
+       protected function spreadBlock() {
                wfDebug( __METHOD__ . "()\n" );
                $this->load();
                if ( $this->mId == 0 ) {
-                       return;
+                       return false;
                }
 
                $userblock = Block::newFromTarget( $this->getName() );
                if ( !$userblock ) {
-                       return;
+                       return false;
                }
 
-               $userblock->doAutoblock( wfGetIP() );
+               return (bool)$userblock->doAutoblock( $this->getRequest()->getIP() );
        }
 
        /**
@@ -2946,7 +3074,7 @@ class User {
                # blocked with createaccount disabled, prevent new account creation there even
                # when the user is logged in
                if( $this->mBlockedFromCreateAccount === false ){
-                       $this->mBlockedFromCreateAccount = Block::newFromTarget( null, wfGetIP() );
+                       $this->mBlockedFromCreateAccount = Block::newFromTarget( null, $this->getRequest()->getIP() );
                }
                return $this->mBlockedFromCreateAccount instanceof Block && $this->mBlockedFromCreateAccount->prevents( 'createaccount' )
                        ? $this->mBlockedFromCreateAccount
@@ -3043,6 +3171,9 @@ class User {
        /**
         * Check if the given clear-text password matches the temporary password
         * sent by e-mail for password reset operations.
+        *
+        * @param $plaintext string
+        *
         * @return Boolean: True if matches, false otherwise
         */
        public function checkTemporaryPassword( $plaintext ) {
@@ -3060,17 +3191,31 @@ class User {
                }
        }
 
+       /**
+        * Alias for getEditToken.
+        * @deprecated since 1.19, use getEditToken instead. 
+        * 
+        * @param $salt String|Array of Strings Optional function-specific data for hashing
+        * @param $request WebRequest object to use or null to use $wgRequest
+        * @return String The new edit token
+        */
+       public function editToken( $salt = '', $request = null ) {
+               return $this->getEditToken( $salt, $request );
+       }
+       
        /**
         * Initialize (if necessary) and return a session token value
         * which can be used in edit forms to show that the user's
         * login credentials aren't being hijacked with a foreign form
         * submission.
         *
+        * @since 1.19
+        *
         * @param $salt String|Array of Strings Optional function-specific data for hashing
         * @param $request WebRequest object to use or null to use $wgRequest
         * @return String The new edit token
         */
-       public function editToken( $salt = '', $request = null ) {
+       public function getEditToken( $salt = '', $request = null ) {
                if ( $request == null ) {
                        $request = $this->getRequest();
                }
@@ -3113,7 +3258,7 @@ class User {
         * @return Boolean: Whether the token matches
         */
        public function matchEditToken( $val, $salt = '', $request = null ) {
-               $sessionToken = $this->editToken( $salt, $request );
+               $sessionToken = $this->getEditToken( $salt, $request );
                if ( $val != $sessionToken ) {
                        wfDebug( "User::matchEditToken: broken session data\n" );
                }
@@ -3130,7 +3275,7 @@ class User {
         * @return Boolean: Whether the token matches
         */
        public function matchEditTokenNoSuffix( $val, $salt = '', $request = null ) {
-               $sessionToken = $this->editToken( $salt, $request );
+               $sessionToken = $this->getEditToken( $salt, $request );
                return substr( $sessionToken, 0, 32 ) == substr( $val, 0, 32 );
        }
 
@@ -3159,7 +3304,7 @@ class User {
 
                return $this->sendMail( wfMsg( 'confirmemail_subject' ),
                        wfMsg( $message,
-                               wfGetIP(),
+                               $this->getRequest()->getIP(),
                                $this->getName(),
                                $url,
                                $wgLang->timeanddate( $expiration, false ),
@@ -3197,7 +3342,7 @@ class User {
         * @note Call saveSettings() after calling this function to commit
         * this change to the database.
         *
-        * @param[out] &$expiration \mixed Accepts the expiration time
+        * @param &$expiration \mixed Accepts the expiration time
         * @return String New token
         */
        private function confirmationToken( &$expiration ) {
@@ -3233,7 +3378,7 @@ class User {
 
        /**
         * Internal function to format the e-mail validation/invalidation URLs.
-        * This uses $wgArticlePath directly as a quickie hack to use the
+        * This uses a quickie hack to use the
         * hardcoded English names of the Special: pages, for ASCII safety.
         *
         * @note Since these URLs get dropped directly into emails, using the
@@ -3246,18 +3391,17 @@ class User {
         * @return String Formatted URL
         */
        protected function getTokenUrl( $page, $token ) {
-               global $wgArticlePath;
-               return wfExpandUrl(
-                       str_replace(
-                               '$1',
-                               "Special:$page/$token",
-                               $wgArticlePath ) );
+               // Hack to bypass localization of 'Special:'
+               $title = Title::makeTitle( NS_MAIN, "Special:$page/$token" );
+               return $title->getCanonicalUrl();
        }
 
        /**
         * Mark the e-mail address confirmed.
         *
         * @note Call saveSettings() after calling this function to commit the change.
+        *
+        * @return true
         */
        public function confirmEmail() {
                $this->setEmailAuthenticationTimestamp( wfTimestampNow() );
@@ -3397,9 +3541,11 @@ class User {
         * Get the permissions associated with a given list of groups
         *
         * @param $groups Array of Strings List of internal group names
+        * @param $ns int
+        *
         * @return Array of Strings List of permission key names for given groups combined
         */
-       public static function getGroupPermissions( $groups, $ns = null ) {
+       public static function getGroupPermissions( array $groups, $ns = null ) {
                global $wgGroupPermissions, $wgRevokePermissions;
                $rights = array();
 
@@ -3423,8 +3569,8 @@ class User {
 
        /**
         * Helper for User::getGroupPermissions
-        * @param array $list
-        * @param int $ns
+        * @param $list array
+        * @param $ns int
         * @return array
         */
        private static function extractRights( $list, $ns ) {
@@ -3449,6 +3595,9 @@ class User {
         * Get all the groups who have a given permission
         *
         * @param $role String Role to check
+        * @param $ns int
+        *
+        *
         * @return Array of Strings List of internal group names with the given permission
         */
        public static function getGroupsWithPermission( $role, $ns = null ) {
@@ -3477,10 +3626,11 @@ class User {
         * Get the localized descriptive name for a member of a group, if it exists
         *
         * @param $group String Internal group name
+        * @param $username String Username for gender (since 1.19)
         * @return String Localized name for group member
         */
-       public static function getGroupMember( $group ) {
-               $msg = wfMessage( "group-$group-member" );
+       public static function getGroupMember( $group, $username = '#' ) {
+               $msg = wfMessage( "group-$group-member", $username );
                return $msg->isBlank() ? $group : $msg->text();
        }
 
@@ -3768,7 +3918,8 @@ class User {
         * Make a new-style password hash
         *
         * @param $password String Plain-text password
-        * @param $salt String Optional salt, may be random or the user ID.
+        * @param bool|string $salt Optional salt, may be random or the user ID.
+
         *                     If unspecified or false, will generate one automatically
         * @return String Password hash
         */
@@ -3796,8 +3947,9 @@ class User {
         *
         * @param $hash String Password hash
         * @param $password String Plain-text password to compare
-        * @param $userId String User ID for old-style password salt
-        * @return Boolean:
+        * @param $userId String|bool User ID for old-style password salt
+        *
+        * @return Boolean
         */
        public static function comparePasswords( $hash, $password, $userId = false ) {
                $type = substr( $hash, 0, 3 );
@@ -3826,7 +3978,7 @@ class User {
         * @param $byEmail Boolean: account made by email?
         * @param $reason String: user supplied reason
         *
-        * @return true
+        * @return int|bool True if not $wgNewUserLog; otherwise ID of log item or 0 on failure
         */
        public function addNewUserLogEntry( $byEmail = false, $reason = '' ) {
                global $wgUser, $wgContLang, $wgNewUserLog;
@@ -3848,13 +4000,12 @@ class User {
                        }
                }
                $log = new LogPage( 'newusers' );
-               $log->addEntry(
+               return (int)$log->addEntry(
                        $action,
                        $this->getUserPage(),
                        $reason,
                        array( $this->getId() )
                );
-               return true;
        }
 
        /**
@@ -3873,6 +4024,9 @@ class User {
                return true;
        }
 
+       /**
+        * @todo document
+        */
        protected function loadOptions() {
                $this->load();
                if ( $this->mOptionsLoaded || !$this->getId() )
@@ -3909,6 +4063,9 @@ class User {
                wfRunHooks( 'UserLoadOptions', array( $this, &$this->mOptions ) );
        }
 
+       /**
+        * @todo document
+        */
        protected function saveOptions() {
                global $wgAllowPrefChange;
 
@@ -3923,8 +4080,9 @@ class User {
 
                // Allow hooks to abort, for instance to save to a global profile.
                // Reset options to default state before saving.
-               if( !wfRunHooks( 'UserSaveOptions', array( $this, &$saveOptions ) ) )
+               if( !wfRunHooks( 'UserSaveOptions', array( $this, &$saveOptions ) ) ) {
                        return;
+               }
 
                foreach( $saveOptions as $key => $value ) {
                        # Don't bother storing default values
@@ -3949,10 +4107,8 @@ class User {
                        }
                }
 
-               $dbw->begin();
                $dbw->delete( 'user_properties', array( 'up_user' => $this->getId() ), __METHOD__ );
                $dbw->insert( 'user_properties', $insert_rows, __METHOD__ );
-               $dbw->commit();
        }
 
        /**