* (bug 8274) Wrap edit tools in a <div> with a specified class
[lhc/web/wiklou.git] / includes / EditPage.php
index 33db6fd..454b5fd 100644 (file)
@@ -43,10 +43,11 @@ class EditPage {
 
        # Placeholders for text injection by hooks (must be HTML)
        # extensions should take care to _append_ to the present value
-       var $editFormTextTop;
-       var $editFormTextAfterWarn;
-       var $editFormTextAfterTools;
-       var $editFormTextBottom;
+       public $editFormPageTop; // Before even the preview
+       public $editFormTextTop;
+       public $editFormTextAfterWarn;
+       public $editFormTextAfterTools;
+       public $editFormTextBottom;
 
        /**
         * @todo document
@@ -58,9 +59,10 @@ class EditPage {
                $this->mTitle =& $wgTitle;
 
                # Placeholders for text injection by hooks (empty per default)
-               $this->editFormTextTop = "";
-               $this->editFormTextAfterWarn = "";
-               $this->editFormTextAfterTools = "";
+               $this->editFormPageTop =
+               $this->editFormTextTop =
+               $this->editFormTextAfterWarn =
+               $this->editFormTextAfterTools =
                $this->editFormTextBottom = "";
        }
        
@@ -73,6 +75,7 @@ class EditPage {
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
                $preload = $wgRequest->getVal( 'preload' );
+               $undo = $wgRequest->getVal( 'undo' );
 
                wfProfileIn( __METHOD__ );
 
@@ -93,8 +96,42 @@ class EditPage {
                        // information.
                        
                        $text = $this->mArticle->getContent();
-                       
-                       if( $section != '' ) {
+
+                       if ( $undo > 0 ) {
+                               #Undoing a specific edit overrides section editing; section-editing
+                               # doesn't work with undoing.
+                               $undorev = Revision::newFromId($undo);
+
+                               #Sanity check, make sure it's the right page.
+                               # Otherwise, $text will be left as-is.
+                               if (!is_null($undorev) && $undorev->getPage() == $this->mArticle->getID()) {
+                                       $oldrev = $undorev->getPrevious();
+                                       $undorev_text = $undorev->getText();
+                                       $oldrev_text = $oldrev->getText();
+                                       $currev_text = $text;
+
+                                       #No use doing a merge if it's just a straight revert.
+                                       if ($currev_text != $undorev_text) {
+                                               $result = wfMerge($undorev_text, $oldrev_text, $currev_text, $text);
+                                       } else {
+                                               $result = true;
+                                       }
+       
+                                       if (!$result) {
+                                               #Undoing failed. Bailing out with regular revision text.
+                                               $text = $currev_text;
+
+                                               #Give a warning
+                                               $this->editFormPageTop .= "<h2>" . wfMsg('undofailed') . "</h2>\n" .
+                                                                       '<p><strong class="error">'.wfMsg('explainundofailed').'</strong></p>';
+                                       } else {
+                                               $this->editFormPageTop .= '<h2>'.wfMsg('undosucceeded')."</h2>\n" .
+                                                                               '<p>'.wfMsg('explainundosucceeded').'</p>';
+                                               $this->summary = wfMsgForContent('undo-summary', $undo, $undorev->getUserText());
+                                       }
+                               }
+                       }
+                       else if( $section != '' ) {
                                if( $section == 'new' ) {
                                        $text = $this->getPreloadedText( $preload );
                                } else {
@@ -524,8 +561,8 @@ class EditPage {
                global $wgUser;
                if( $wgUser->isAnon() ) {
                        # Anonymous users may not have a session
-                       # open. Don't tokenize.
-                       $this->mTokenOk = true;
+                       # open. Check for suffix anyway.
+                       $this->mTokenOk = ( EDIT_TOKEN_SUFFIX == $request->getVal( 'wpEditToken' ) );
                } else {
                        $this->mTokenOk = $wgUser->matchEditToken( $request->getVal( 'wpEditToken' ) );
                }
@@ -566,11 +603,18 @@ class EditPage {
                wfProfileIn( $fname );
                wfProfileIn( "$fname-checks" );
 
+               if( !wfRunHooks( 'EditPage::attemptSave', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'EditPage::attemptSave' aborted article saving" );
+                       return false;
+               }
+
                # Reintegrate metadata
                if ( $this->mMetaData != '' ) $this->textbox1 .= "\n" . $this->mMetaData ;
                $this->mMetaData = '' ;
 
                # Check for spam
+               $matches = array();
                if ( $wgSpamRegex && preg_match( $wgSpamRegex, $this->textbox1, $matches ) ) {
                        $this->spamPage ( $matches[0] );
                        wfProfileOut( "$fname-checks" );
@@ -651,6 +695,7 @@ class EditPage {
                # If article is new, insert it.
                $aid = $this->mTitle->getArticleID( GAID_FOR_UPDATE );
                if ( 0 == $aid ) {
+
                        // Late check for create permission, just in case *PARANOIA*
                        if ( !$this->mTitle->userCanCreate() ) {
                                wfDebug( "$fname: no create permission\n" );
@@ -815,8 +860,8 @@ class EditPage {
         */
        function initialiseForm() {
                $this->edittime = $this->mArticle->getTimestamp();
-               $this->textbox1 = $this->getContent();
                $this->summary = '';
+               $this->textbox1 = $this->getContent();
                if ( !$this->mArticle->exists() && $this->mArticle->mTitle->getNamespace() == NS_MEDIAWIKI )
                        $this->textbox1 = wfMsgWeirdKey( $this->mArticle->mTitle->getText() ) ;
                wfProxyCheck();
@@ -858,6 +903,7 @@ class EditPage {
                                        $s = wfMsg('editingcomment', $this->mTitle->getPrefixedText() );
                                } else {
                                        $s = wfMsg('editingsection', $this->mTitle->getPrefixedText() );
+                                       $matches = array();
                                        if( !$this->summary && !$this->preview && !$this->diff ) {
                                                preg_match( "/^(=+)(.+)\\1/mi",
                                                        $this->textbox1,
@@ -1019,6 +1065,8 @@ class EditPage {
 
                $checkboxhtml = $minoredithtml . $watchhtml;
 
+               $wgOut->addHTML( $this->editFormPageTop );
+
                if ( $wgUser->getOption( 'previewontop' ) ) {
 
                        if ( 'preview' == $this->formtype ) {
@@ -1195,7 +1243,10 @@ END
 </div><!-- editButtons -->
 </div><!-- editOptions -->");
 
+               $wgOut->addHtml( '<div class="editTools">' );
                $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
+               $wgOut->addHtml( '</div>' );
+
                $wgOut->addHTML( $this->editFormTextAfterTools );
 
                $wgOut->addHTML( "
@@ -1204,18 +1255,24 @@ END
 </div>
 " );
 
-               if ( $wgUser->isLoggedIn() ) {
-                       /**
-                        * To make it harder for someone to slip a user a page
-                        * which submits an edit form to the wiki without their
-                        * knowledge, a random token is associated with the login
-                        * session. If it's not passed back with the submission,
-                        * we won't save the page, or render user JavaScript and
-                        * CSS previews.
-                        */
+               /**
+                * To make it harder for someone to slip a user a page
+                * which submits an edit form to the wiki without their
+                * knowledge, a random token is associated with the login
+                * session. If it's not passed back with the submission,
+                * we won't save the page, or render user JavaScript and
+                * CSS previews.
+                *
+                * For anon editors, who may not have a session, we just
+                * include the constant suffix to prevent editing from
+                * broken text-mangling proxies.
+                */
+               if ( $wgUser->isLoggedIn() )
                        $token = htmlspecialchars( $wgUser->editToken() );
-                       $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
-               }
+               else
+                       $token = EDIT_TOKEN_SUFFIX;
+               $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
+
 
                # If a blank edit summary was previously provided, and the appropriate
                # user preference is active, pass a hidden tag here. This will stop the
@@ -1513,6 +1570,7 @@ END
                }
                $currentText = $currentRevision->getText();
 
+               $result = '';
                if( wfMerge( $baseText, $editText, $currentText, $result ) ){
                        $editText = $result;
                        wfProfileOut( $fname );
@@ -1588,15 +1646,15 @@ END
                 */
                $toolarray=array(
                        array(  'image'=>'button_bold.png',
-                                       'open'  =>      "\'\'\'",
-                                       'close' =>      "\'\'\'",
+                                       'open'  =>      '\\\'\\\'\\\'',
+                                       'close' =>      '\\\'\\\'\\\'',
                                        'sample'=>      wfMsg('bold_sample'),
                                        'tip'   =>      wfMsg('bold_tip'),
                                        'key'   =>      'B'
                                ),
                        array(  'image'=>'button_italic.png',
-                                       'open'  =>      "\'\'",
-                                       'close' =>      "\'\'",
+                                       'open'  =>      '\\\'\\\'',
+                                       'close' =>      '\\\'\\\'',
                                        'sample'=>      wfMsg('italic_sample'),
                                        'tip'   =>      wfMsg('italic_tip'),
                                        'key'   =>      'I'