3 * Holds tests for LBFactory abstract MediaWiki class.
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation; either version 2 of the License, or
8 * (at your option) any later version.
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
15 * You should have received a copy of the GNU General Public License along
16 * with this program; if not, write to the Free Software Foundation, Inc.,
17 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 * http://www.gnu.org/copyleft/gpl.html
21 * @author Antoine Musso
22 * @copyright © 2013 Antoine Musso
23 * @copyright © 2013 Wikimedia Foundation Inc.
26 use Wikimedia\Rdbms\LBFactorySimple
;
27 use Wikimedia\Rdbms\LBFactoryMulti
;
28 use Wikimedia\Rdbms\LoadBalancer
;
29 use Wikimedia\Rdbms\ChronologyProtector
;
30 use Wikimedia\Rdbms\DatabaseMysqli
;
31 use Wikimedia\Rdbms\MySQLMasterPos
;
32 use Wikimedia\Rdbms\DatabaseDomain
;
36 * @covers \Wikimedia\Rdbms\LBFactorySimple
37 * @covers \Wikimedia\Rdbms\LBFactoryMulti
39 class LBFactoryTest
extends MediaWikiTestCase
{
42 * @covers MWLBFactory::getLBFactoryClass
43 * @dataProvider getLBFactoryClassProvider
45 public function testGetLBFactoryClass( $expected, $deprecated ) {
46 $mockDB = $this->getMockBuilder( DatabaseMysqli
::class )
47 ->disableOriginalConstructor()
51 'class' => $deprecated,
52 'connection' => $mockDB,
53 # Various other parameters required:
56 'serverTemplate' => [],
59 $this->hideDeprecated( '$wgLBFactoryConf must be updated. See RELEASE-NOTES for details' );
60 $result = MWLBFactory
::getLBFactoryClass( $config );
62 $this->assertEquals( $expected, $result );
65 public function getLBFactoryClassProvider() {
67 # Format: new class, old class
68 [ Wikimedia\Rdbms\LBFactorySimple
::class, 'LBFactory_Simple' ],
69 [ Wikimedia\Rdbms\LBFactorySingle
::class, 'LBFactory_Single' ],
70 [ Wikimedia\Rdbms\LBFactoryMulti
::class, 'LBFactory_Multi' ],
71 [ Wikimedia\Rdbms\LBFactorySimple
::class, 'LBFactorySimple' ],
72 [ Wikimedia\Rdbms\LBFactorySingle
::class, 'LBFactorySingle' ],
73 [ Wikimedia\Rdbms\LBFactoryMulti
::class, 'LBFactoryMulti' ],
77 public function testLBFactorySimpleServer() {
78 global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir;
82 'host' => $wgDBserver,
83 'dbname' => $wgDBname,
85 'password' => $wgDBpassword,
87 'dbDirectory' => $wgSQLiteDataDir,
89 'flags' => DBO_TRX
// REPEATABLE-READ for consistency
93 $factory = new LBFactorySimple( [ 'servers' => $servers ] );
94 $lb = $factory->getMainLB();
96 $dbw = $lb->getConnection( DB_MASTER
);
97 $this->assertTrue( $dbw->getLBInfo( 'master' ), 'master shows as master' );
99 $dbr = $lb->getConnection( DB_REPLICA
);
100 $this->assertTrue( $dbr->getLBInfo( 'master' ), 'DB_REPLICA also gets the master' );
102 $factory->shutdown();
106 public function testLBFactorySimpleServers() {
107 global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir;
111 'host' => $wgDBserver,
112 'dbname' => $wgDBname,
114 'password' => $wgDBpassword,
116 'dbDirectory' => $wgSQLiteDataDir,
118 'flags' => DBO_TRX
// REPEATABLE-READ for consistency
121 'host' => $wgDBserver,
122 'dbname' => $wgDBname,
124 'password' => $wgDBpassword,
126 'dbDirectory' => $wgSQLiteDataDir,
128 'flags' => DBO_TRX
// REPEATABLE-READ for consistency
132 $factory = new LBFactorySimple( [
133 'servers' => $servers,
134 'loadMonitorClass' => LoadMonitorNull
::class
136 $lb = $factory->getMainLB();
138 $dbw = $lb->getConnection( DB_MASTER
);
139 $this->assertTrue( $dbw->getLBInfo( 'master' ), 'master shows as master' );
141 ( $wgDBserver != '' ) ?
$wgDBserver : 'localhost',
142 $dbw->getLBInfo( 'clusterMasterHost' ),
143 'cluster master set' );
145 $dbr = $lb->getConnection( DB_REPLICA
);
146 $this->assertTrue( $dbr->getLBInfo( 'replica' ), 'slave shows as slave' );
148 ( $wgDBserver != '' ) ?
$wgDBserver : 'localhost',
149 $dbr->getLBInfo( 'clusterMasterHost' ),
150 'cluster master set' );
152 $factory->shutdown();
156 public function testLBFactoryMulti() {
157 global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir;
159 $factory = new LBFactoryMulti( [
173 'serverTemplate' => [
174 'dbname' => $wgDBname,
176 'password' => $wgDBpassword,
178 'dbDirectory' => $wgSQLiteDataDir,
179 'flags' => DBO_DEFAULT
182 'test-db1' => $wgDBserver,
183 'test-db2' => $wgDBserver,
184 'test-db3' => $wgDBserver,
185 'test-db4' => $wgDBserver
187 'loadMonitorClass' => LoadMonitorNull
::class
189 $lb = $factory->getMainLB();
191 $dbw = $lb->getConnection( DB_MASTER
);
192 $this->assertTrue( $dbw->getLBInfo( 'master' ), 'master shows as master' );
194 $dbr = $lb->getConnection( DB_REPLICA
);
195 $this->assertTrue( $dbr->getLBInfo( 'replica' ), 'slave shows as slave' );
197 // Test that LoadBalancer instances made during commitMasterChanges() do not throw
198 // DBTransactionError due to transaction ROUND_* stages being mismatched.
199 $factory->beginMasterChanges( __METHOD__
);
200 $dbw->onTransactionPreCommitOrIdle( function () use ( $factory ) {
201 // Trigger s1 LoadBalancer instantiation during "finalize" stage.
202 // There is no s1wiki DB to select so it is not in getConnection(),
203 // but this fools getMainLB() at least.
204 $factory->getMainLB( 's1wiki' )->getConnection( DB_MASTER
);
206 $factory->commitMasterChanges( __METHOD__
);
209 $factory->forEachLB( function () use ( &$count ) {
212 $this->assertEquals( 2, $count );
214 // DBTransactionError should not be thrown
216 $dbw->onTransactionPreCommitOrIdle( function () use ( &$ran ) {
219 $factory->commitAll( __METHOD__
);
220 $this->assertEquals( 1, $ran );
222 $factory->shutdown();
223 $factory->closeAll();
227 * @covers \Wikimedia\Rdbms\ChronologyProtector
229 public function testChronologyProtector() {
230 $now = microtime( true );
232 // (a) First HTTP request
233 $m1Pos = new MySQLMasterPos( 'db1034-bin.000976/843431247', $now );
234 $m2Pos = new MySQLMasterPos( 'db1064-bin.002400/794074907', $now );
237 $mockDB1 = $this->getMockBuilder( DatabaseMysqli
::class )
238 ->disableOriginalConstructor()
240 $mockDB1->method( 'writesOrCallbacksPending' )->willReturn( true );
241 $mockDB1->method( 'lastDoneWrites' )->willReturn( $now );
242 $mockDB1->method( 'getMasterPos' )->willReturn( $m1Pos );
243 // Load balancer for master DB 1
244 $lb1 = $this->getMockBuilder( LoadBalancer
::class )
245 ->disableOriginalConstructor()
247 $lb1->method( 'getConnection' )->willReturn( $mockDB1 );
248 $lb1->method( 'getServerCount' )->willReturn( 2 );
249 $lb1->method( 'getAnyOpenConnection' )->willReturn( $mockDB1 );
250 $lb1->method( 'hasOrMadeRecentMasterChanges' )->will( $this->returnCallback(
251 function () use ( $mockDB1 ) {
253 $p |
= call_user_func( [ $mockDB1, 'writesOrCallbacksPending' ] );
254 $p |
= call_user_func( [ $mockDB1, 'lastDoneWrites' ] );
259 $lb1->method( 'getMasterPos' )->willReturn( $m1Pos );
260 $lb1->method( 'getServerName' )->with( 0 )->willReturn( 'master1' );
262 $mockDB2 = $this->getMockBuilder( DatabaseMysqli
::class )
263 ->disableOriginalConstructor()
265 $mockDB2->method( 'writesOrCallbacksPending' )->willReturn( true );
266 $mockDB2->method( 'lastDoneWrites' )->willReturn( $now );
267 $mockDB2->method( 'getMasterPos' )->willReturn( $m2Pos );
268 // Load balancer for master DB 2
269 $lb2 = $this->getMockBuilder( LoadBalancer
::class )
270 ->disableOriginalConstructor()
272 $lb2->method( 'getConnection' )->willReturn( $mockDB2 );
273 $lb2->method( 'getServerCount' )->willReturn( 2 );
274 $lb2->method( 'getAnyOpenConnection' )->willReturn( $mockDB2 );
275 $lb2->method( 'hasOrMadeRecentMasterChanges' )->will( $this->returnCallback(
276 function () use ( $mockDB2 ) {
278 $p |
= call_user_func( [ $mockDB2, 'writesOrCallbacksPending' ] );
279 $p |
= call_user_func( [ $mockDB2, 'lastDoneWrites' ] );
284 $lb2->method( 'getMasterPos' )->willReturn( $m2Pos );
285 $lb2->method( 'getServerName' )->with( 0 )->willReturn( 'master2' );
287 $bag = new HashBagOStuff();
288 $cp = new ChronologyProtector(
292 'agent' => "Totally-Not-FireFox"
296 $mockDB1->expects( $this->exactly( 1 ) )->method( 'writesOrCallbacksPending' );
297 $mockDB1->expects( $this->exactly( 1 ) )->method( 'lastDoneWrites' );
298 $mockDB2->expects( $this->exactly( 1 ) )->method( 'writesOrCallbacksPending' );
299 $mockDB2->expects( $this->exactly( 1 ) )->method( 'lastDoneWrites' );
301 // Nothing to wait for on first HTTP request start
304 // Record positions in stash on first HTTP request end
305 $cp->shutdownLB( $lb1 );
306 $cp->shutdownLB( $lb2 );
308 $cp->shutdown( null, 'sync', $cpIndex );
310 $this->assertEquals( 1, $cpIndex, "CP write index set" );
312 // (b) Second HTTP request
314 // Load balancer for master DB 1
315 $lb1 = $this->getMockBuilder( LoadBalancer
::class )
316 ->disableOriginalConstructor()
318 $lb1->method( 'getServerCount' )->willReturn( 2 );
319 $lb1->method( 'getServerName' )->with( 0 )->willReturn( 'master1' );
320 $lb1->expects( $this->once() )
321 ->method( 'waitFor' )->with( $this->equalTo( $m1Pos ) );
322 // Load balancer for master DB 2
323 $lb2 = $this->getMockBuilder( LoadBalancer
::class )
324 ->disableOriginalConstructor()
326 $lb2->method( 'getServerCount' )->willReturn( 2 );
327 $lb2->method( 'getServerName' )->with( 0 )->willReturn( 'master2' );
328 $lb2->expects( $this->once() )
329 ->method( 'waitFor' )->with( $this->equalTo( $m2Pos ) );
331 $cp = new ChronologyProtector(
335 'agent' => "Totally-Not-FireFox"
340 // Wait for last positions to be reached on second HTTP request start
343 // Shutdown (nothing to record)
344 $cp->shutdownLB( $lb1 );
345 $cp->shutdownLB( $lb2 );
347 $cp->shutdown( null, 'sync', $cpIndex );
349 $this->assertEquals( null, $cpIndex, "CP write index retained" );
352 private function newLBFactoryMulti( array $baseOverride = [], array $serverOverride = [] ) {
353 global $wgDBserver, $wgDBuser, $wgDBpassword, $wgDBname, $wgDBprefix, $wgDBtype;
354 global $wgSQLiteDataDir;
356 return new LBFactoryMulti( $baseOverride +
[
357 'sectionsByDB' => [],
363 'serverTemplate' => $serverOverride +
[
364 'dbname' => $wgDBname,
365 'tablePrefix' => $wgDBprefix,
367 'password' => $wgDBpassword,
369 'dbDirectory' => $wgSQLiteDataDir,
370 'flags' => DBO_DEFAULT
373 'test-db1' => $wgDBserver,
375 'loadMonitorClass' => LoadMonitorNull
::class,
376 'localDomain' => new DatabaseDomain( $wgDBname, null, $wgDBprefix )
380 public function testNiceDomains() {
383 if ( wfGetDB( DB_MASTER
)->databasesAreIndependent() ) {
384 self
::markTestSkipped( "Skipping tests about selecting DBs: not applicable" );
388 $factory = $this->newLBFactoryMulti(
392 $lb = $factory->getMainLB();
394 $db = $lb->getConnectionRef( DB_MASTER
);
401 /** @var Database $db */
402 $db = $lb->getConnection( DB_MASTER
, [], '' );
407 'Null domain ID handle used'
412 'Null domain ID handle used'
417 'Main domain ID handle used; prefix is empty though'
420 $this->quoteTable( $db, 'page' ),
421 $db->tableName( 'page' ),
422 "Correct full table name"
425 $this->quoteTable( $db, $wgDBname ) . '.' . $this->quoteTable( $db, 'page' ),
426 $db->tableName( "$wgDBname.page" ),
427 "Correct full table name"
430 $this->quoteTable( $db, 'nice_db' ) . '.' . $this->quoteTable( $db, 'page' ),
431 $db->tableName( 'nice_db.page' ),
432 "Correct full table name"
435 $lb->reuseConnection( $db ); // don't care
437 $db = $lb->getConnection( DB_MASTER
); // local domain connection
438 $factory->setDomainPrefix( 'my_' );
440 $this->assertEquals( $wgDBname, $db->getDBname() );
446 $this->quoteTable( $db, 'my_page' ),
447 $db->tableName( 'page' ),
448 "Correct full table name"
451 $this->quoteTable( $db, 'other_nice_db' ) . '.' . $this->quoteTable( $db, 'page' ),
452 $db->tableName( 'other_nice_db.page' ),
453 "Correct full table name"
456 $factory->closeAll();
460 public function testTrickyDomain() {
463 if ( wfGetDB( DB_MASTER
)->databasesAreIndependent() ) {
464 self
::markTestSkipped( "Skipping tests about selecting DBs: not applicable" );
468 $dbname = 'unittest-domain'; // explodes if DB is selected
469 $factory = $this->newLBFactoryMulti(
470 [ 'localDomain' => ( new DatabaseDomain( $dbname, null, '' ) )->getId() ],
472 'dbName' => 'do_not_select_me' // explodes if DB is selected
475 $lb = $factory->getMainLB();
476 /** @var Database $db */
477 $db = $lb->getConnection( DB_MASTER
, [], '' );
479 $this->assertEquals( '', $db->getDomainID(), "Null domain used" );
482 $this->quoteTable( $db, 'page' ),
483 $db->tableName( 'page' ),
484 "Correct full table name"
488 $this->quoteTable( $db, $dbname ) . '.' . $this->quoteTable( $db, 'page' ),
489 $db->tableName( "$dbname.page" ),
490 "Correct full table name"
494 $this->quoteTable( $db, 'nice_db' ) . '.' . $this->quoteTable( $db, 'page' ),
495 $db->tableName( 'nice_db.page' ),
496 "Correct full table name"
499 $lb->reuseConnection( $db ); // don't care
501 $factory->setDomainPrefix( 'my_' );
502 $db = $lb->getConnection( DB_MASTER
, [], "$wgDBname-my_" );
505 $this->quoteTable( $db, 'my_page' ),
506 $db->tableName( 'page' ),
507 "Correct full table name"
510 $this->quoteTable( $db, 'other_nice_db' ) . '.' . $this->quoteTable( $db, 'page' ),
511 $db->tableName( 'other_nice_db.page' ),
512 "Correct full table name"
515 $this->quoteTable( $db, 'garbage-db' ) . '.' . $this->quoteTable( $db, 'page' ),
516 $db->tableName( 'garbage-db.page' ),
517 "Correct full table name"
520 $lb->reuseConnection( $db ); // don't care
522 $factory->closeAll();
526 public function testInvalidSelectDB() {
527 $dbname = 'unittest-domain'; // explodes if DB is selected
528 $factory = $this->newLBFactoryMulti(
529 [ 'localDomain' => ( new DatabaseDomain( $dbname, null, '' ) )->getId() ],
531 'dbName' => 'do_not_select_me' // explodes if DB is selected
534 $lb = $factory->getMainLB();
535 /** @var Database $db */
536 $db = $lb->getConnection( DB_MASTER
, [], '' );
538 if ( $db->getType() === 'sqlite' ) {
539 $this->assertFalse( $db->selectDB( 'garbage-db' ) );
540 } elseif ( $db->databasesAreIndependent() ) {
543 $db->selectDB( 'garbage-db' );
544 } catch ( \Wikimedia\Rdbms\DBConnectionError
$e ) {
547 $this->assertInstanceOf( \Wikimedia\Rdbms\DBConnectionError
::class, $e );
548 $this->assertFalse( $db->isOpen() );
550 \Wikimedia\
suppressWarnings();
551 $this->assertFalse( $db->selectDB( 'garbage-db' ) );
552 \Wikimedia\restoreWarnings
();
556 private function quoteTable( Database
$db, $table ) {
557 if ( $db->getType() === 'sqlite' ) {
560 return $db->addIdentifierQuotes( $table );