Mark A. Hershberger [Sat, 10 May 2014 12:35:20 +0000 (08:35 -0400)]
Add deprecation notices to recent s/var/public/ property changes.
See change I309cf46891223c5f1520e97b04d4ed315a300e7a for more
information.
Change-Id: I9fe5270f490657450ba2fcdb329abf66736f38c3
jenkins-bot [Sat, 10 May 2014 12:07:36 +0000 (12:07 +0000)]
Merge "Remove useless variable from Title::newFromText()"
jenkins-bot [Sat, 10 May 2014 11:36:57 +0000 (11:36 +0000)]
Merge "Remove isset() check for $wgLocalTZoffset in Language.php"
Alexandre Emsenhuber [Sat, 10 May 2014 11:31:20 +0000 (13:31 +0200)]
Remove useless variable from Title::newFromText()
Instead of setting and returning it directly, we
might as well return null directly...
Change-Id: Icbde20fe0f6a064dd58018d6543b03def7203a84
physikerwelt (Moritz Schubotz) [Fri, 9 May 2014 10:08:55 +0000 (12:08 +0200)]
Fix PHPUnit version to 3.7.35
"MediaWiki tries to require PHPUnit files directly,
but the phpunit/phpunit PEAR channel now falls back to the PHAR
method (install a single file, /usr/bin/phpunit, with all classes
packed inside it)." (from the bug report)
Bug: 64597
Change-Id: Ib93b32473ab1a96ea97d90c15fd3675e8ec9843c
Alexandre Emsenhuber [Sat, 10 May 2014 11:19:58 +0000 (13:19 +0200)]
Remove isset() check for $wgLocalTZoffset in Language.php
Do not use isset() to check for null; furthermore this variable
can no longer be null at this point now, so the check is useless.
Also remove the initial defintion of $minDiff since this was the
only case where it could be not set afterwards and fix spacing
after the comment.
Change-Id: I6e62ce1217e6e8750acb411673903fc3bde57841
jenkins-bot [Sat, 10 May 2014 09:29:43 +0000 (09:29 +0000)]
Merge "Add space between two feed links"
umherirrender [Sat, 10 May 2014 09:19:46 +0000 (11:19 +0200)]
Add space between two feed links
When more than one feed link was given, the links was concat without a
space, which looks odd. Adding now a space, between each link in the
toolbox.
Bug: 36356
Change-Id: Iaf61c88dde0a92c475a60c005e13222eb7618eef
jenkins-bot [Sat, 10 May 2014 09:13:09 +0000 (09:13 +0000)]
Merge "Pass phpcs-strict on includes/resourceloader/"
jenkins-bot [Sat, 10 May 2014 09:11:52 +0000 (09:11 +0000)]
Merge "Pass phpcs-strict on includes/poolcounter/"
jenkins-bot [Sat, 10 May 2014 09:00:53 +0000 (09:00 +0000)]
Merge "Pass phpcs-strict on includes/rcfeed/"
Siebrand Mazeland [Sat, 10 May 2014 08:54:09 +0000 (10:54 +0200)]
Pass phpcs-strict on includes/poolcounter/
Change-Id: If10d03e66bf617f6eb2d9ec9f43d6d55c5c5d784
umherirrender [Mon, 5 May 2014 19:12:25 +0000 (21:12 +0200)]
Add $user param to SpecialPageFactory::getRestrictedPages
This avoids the use of $wgUser
Change-Id: I5cc85391710f6e6967d78825fc8a3eda0e15a1a1
Siebrand Mazeland [Sat, 10 May 2014 08:42:13 +0000 (10:42 +0200)]
Pass phpcs-strict on includes/rcfeed/
Change-Id: I197b4963a29fc5c13d71cd820ab780dedbc30b99
Siebrand Mazeland [Sat, 10 May 2014 08:39:37 +0000 (10:39 +0200)]
Pass phpcs-strict on includes/resourceloader/
Change-Id: I5c63e0612c2aae240abcdbf21da9cdadd80dee31
jenkins-bot [Sat, 10 May 2014 08:38:18 +0000 (08:38 +0000)]
Merge "Pass phpcs-strict on includes/upload"
jenkins-bot [Sat, 10 May 2014 08:37:59 +0000 (08:37 +0000)]
Merge "Pass phpcs-strict on includes/search/"
Siebrand Mazeland [Fri, 9 May 2014 17:56:05 +0000 (19:56 +0200)]
Pass phpcs-strict on includes/upload
Change-Id: I80eaa22398227a4edb7160d560b625102c7436ac
jenkins-bot [Sat, 10 May 2014 07:59:51 +0000 (07:59 +0000)]
Merge "Declare visibility on class properties of CdbPHP.php"
Jackmcbarn [Sat, 10 May 2014 03:04:31 +0000 (23:04 -0400)]
Fix incorrect comment
Fix a comment incorrectly referring to user pages instead of category
pages. Follow-up to Ic93616a54c8e98e3dc71daee3c92c466d64daffc
Change-Id: I74533658c32647f77e3d8d54a05e9835e1c37952
Brion VIBBER [Fri, 9 May 2014 23:14:28 +0000 (23:14 +0000)]
Merge "SpecialUserlogin: Error out when attempting to create a username with a '#'"
Bartosz Dziewoński [Fri, 9 May 2014 22:44:05 +0000 (00:44 +0200)]
SpecialUserlogin: Error out when attempting to create a username with a '#'
"Best practices"? Ain't never heard of it.
Bug: 64960
Change-Id: I88c479cea2bc9d2eab882e0ee8ebcbe2d1dd125e
Translation updater bot [Fri, 9 May 2014 22:20:43 +0000 (22:20 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I4ddccb026c78b4e0a7b29cda1d91ec7548f14cac
Brion VIBBER [Fri, 9 May 2014 21:50:47 +0000 (21:50 +0000)]
Merge "Allow mobile to reduce image quality"
jenkins-bot [Fri, 9 May 2014 20:41:06 +0000 (20:41 +0000)]
Merge "Add API action=watch 'entirewatchlist' param to bulk-clear watchlist."
Yuri Astrakhan [Fri, 9 May 2014 05:51:59 +0000 (01:51 -0400)]
Allow mobile to reduce image quality
http://www.mediawiki.org/wiki/Requests_for_comment/Reducing_image_quality_for_mobile
Per above RFC, this patch implements the core changes required to
specify quality reduction of JPEG via URL. To test, make sure your
setup uses 404-based thumb generation. Vagrant supports it by adding
"multimedia" role: $ vagrant add-role multimedia && vagrant provision
* Pick any thumbnail jpeg URL that exists on the test wiki, e.g.
http://.../images/thumb/4/49/Img.jpg/400px-Img.jpg
* check that basic scaling works by altering 400
* add quality parameter qlow- right before px:
http://.../images/thumb/4/49/Img.jpg/qlow-400px-Img.jpg
Change-Id: I930ea06be6d302ffc8832d12b251422a9f1b3e75
Siebrand Mazeland [Fri, 9 May 2014 20:32:17 +0000 (22:32 +0200)]
Pass phpcs-strict on includes/search/
Change-Id: Ia38af607b1f2a8e49f60f1a659a14b801e7dcda0
jenkins-bot [Fri, 9 May 2014 20:26:30 +0000 (20:26 +0000)]
Merge "Pass phpcs-strict on includes/site/"
jenkins-bot [Fri, 9 May 2014 20:26:10 +0000 (20:26 +0000)]
Merge "Ignore CodeSniffer checks on HTML template files"
Brion Vibber [Fri, 9 May 2014 10:22:45 +0000 (12:22 +0200)]
Add API action=watch 'entirewatchlist' param to bulk-clear watchlist.
Requested by bot runners, who often accumulate huge watchlists
and have trouble resetting them.
Requires POST and a token to prevent accidents or abuse.
Same token as individual or list watching.
Bug: 65058
Change-Id: Id8476a1ba8b2661cf6451cacf3121d5c2d0675cf
Siebrand Mazeland [Fri, 9 May 2014 19:54:07 +0000 (21:54 +0200)]
Pass phpcs-strict on includes/site/
Change-Id: Ibc3f29e21dd5bcfd5ea641a58f8d3f641948741d
Siebrand Mazeland [Fri, 9 May 2014 19:33:58 +0000 (21:33 +0200)]
Pass phpcs-strict on includes/specials/ (1/3)
Change-Id: Ib4522f22551ed5501e1ab7767b8f481fe6cd72d2
jenkins-bot [Fri, 9 May 2014 18:28:22 +0000 (18:28 +0000)]
Merge "ChangesListSpecialPage: Use Html instead of Xml in makeLegend()"
jenkins-bot [Fri, 9 May 2014 18:28:03 +0000 (18:28 +0000)]
Merge "ChangesListSpecialPage: Correctly show legend if patrolling of only new pages is enabled"
Siebrand Mazeland [Fri, 9 May 2014 18:10:35 +0000 (20:10 +0200)]
Ignore CodeSniffer checks on HTML template files
Change-Id: I3b671616c1b110258389b5ebe10b5c2ca8c5835f
Bartosz Dziewoński [Fri, 9 May 2014 18:04:35 +0000 (20:04 +0200)]
ChangesListSpecialPage: Use Html instead of Xml in makeLegend()
We're generating HTML here, not XML.
Also changed a silly variable name.
Change-Id: I3295fd6a515d7172d4c233d4698e7b50df1a722c
jenkins-bot [Fri, 9 May 2014 17:51:06 +0000 (17:51 +0000)]
Merge "RevisionDelete: Avoid SELECT *"
jenkins-bot [Fri, 9 May 2014 17:49:59 +0000 (17:49 +0000)]
Merge "Do title conversion on &action=edit if &redlink=1 exists"
umherirrender [Thu, 24 Apr 2014 08:20:17 +0000 (10:20 +0200)]
RevisionDelete: Avoid SELECT *
Use selectFields functions and a manually list of columsn to get all
fields instead of * in the sql.
It is good practice to name the selected fields
Change-Id: I9d6e5714d609bc8a7020c2b7610934b815563cff
Liangent [Thu, 5 Dec 2013 08:57:41 +0000 (08:57 +0000)]
Do title conversion on &action=edit if &redlink=1 exists
Bug: 33231
Change-Id: I33c3c9df4ff2215710bacb696b64bb4291dda24e
Alexandre Emsenhuber [Mon, 14 Apr 2014 18:22:21 +0000 (20:22 +0200)]
One more bump for 1.24
But this one is 1.22 -> 1.23!
Change-Id: I6acf7d8ecde6ef3cf8957bc5ac63ce5c979531e8
jenkins-bot [Fri, 9 May 2014 17:35:29 +0000 (17:35 +0000)]
Merge "Collation: Update comments about verified colations"
jenkins-bot [Fri, 9 May 2014 17:26:18 +0000 (17:26 +0000)]
Merge "Expand release notes for I82d26b64"
Bartosz Dziewoński [Fri, 9 May 2014 08:44:14 +0000 (10:44 +0200)]
Collation: Update comments about verified colations
…according to which ones are deployed on Wikimedia cluster.
Change-Id: I1c296c19ca80cab1c0f8fbaae9ce055facbfc85f
jenkins-bot [Fri, 9 May 2014 17:22:13 +0000 (17:22 +0000)]
Merge "Allow moving category pages"
jenkins-bot [Fri, 9 May 2014 17:22:11 +0000 (17:22 +0000)]
Merge "Add comment about desc message to $wgTrackingCategories"
Bartosz Dziewoński [Fri, 9 May 2014 17:19:07 +0000 (19:19 +0200)]
Expand release notes for I82d26b64
Change-Id: Idd8f5d260e649338cf7903c7a1c157abd23cebaa
Jackmcbarn [Mon, 5 May 2014 18:22:53 +0000 (14:22 -0400)]
Allow moving category pages
Allow category pages to be moved. This is to preserve attribution of the
page only and does not cause pages in the category to recategorize to the
new one. A warning explains this when such a move is attempted. The new
right move-categorypages is required to do this, which is assigned to user
and sysop by default (the same as other move-related rights). The message
category-move-redirect-override can be used to cause custom text to be
placed on the "old" category page in lieu of a redirect.
Bug: 28569
Bug: 5451
Change-Id: Ic93616a54c8e98e3dc71daee3c92c466d64daffc
umherirrender [Fri, 9 May 2014 16:59:01 +0000 (18:59 +0200)]
Add comment about desc message to $wgTrackingCategories
Change-Id: Idd33af96fb05282c3b12860f82004b7b840cf796
jenkins-bot [Fri, 9 May 2014 15:21:03 +0000 (15:21 +0000)]
Merge "Update formatting of includes/upload/"
jenkins-bot [Fri, 9 May 2014 15:06:25 +0000 (15:06 +0000)]
Merge "mediawiki.api: Don't log request error 'abort'"
Siebrand Mazeland [Fri, 9 May 2014 14:53:19 +0000 (16:53 +0200)]
Update formatting of includes/upload/
Change-Id: I8cf59cd3bb6dd8de2ed6509b7bc2ef9ff7c5caf1
jenkins-bot [Fri, 9 May 2014 14:19:50 +0000 (14:19 +0000)]
Merge "Add missing variantname messages for Uzbek"
robin [Fri, 9 May 2014 15:28:59 +0000 (17:28 +0200)]
Add missing variantname messages for Uzbek
Related to bug 42420 and bug 42397
Change-Id: If7c35e84e684c6e30438d0708683c15975b475cb
jenkins-bot [Fri, 9 May 2014 13:03:57 +0000 (13:03 +0000)]
Merge "Expose server name in rc feed"
Siebrand Mazeland [Fri, 9 May 2014 12:46:29 +0000 (14:46 +0200)]
Declare visibility on class properties of CdbPHP.php
Change-Id: Ie95e3b4222ad953db4d721d3149e1f587f0cde69
jenkins-bot [Fri, 9 May 2014 11:33:46 +0000 (11:33 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (
7b3672591f)"
jenkins-bot [Fri, 9 May 2014 11:29:31 +0000 (11:29 +0000)]
Merge "Fix Oracle 1.23 missing patches (rebase)"
James D. Forrester [Fri, 9 May 2014 11:27:09 +0000 (13:27 +0200)]
Update OOjs UI to v0.1.0-pre (
7b3672591f)
New changes:
5556abf demo: Make demo console more generic
142bd44 Dialog demos
6f65873 demo/widgets: Bring dev console back
32055e9 Minor refactor of widgets demo
d6b80e7 Watch dot files
7b36725 Localisation updates from https://translatewiki.net.
Change-Id: I1ea5c113b24c1c1a1d853cfda3fccfcfd13140cc
jenkins-bot [Fri, 9 May 2014 10:25:13 +0000 (10:25 +0000)]
Merge "Content: Deprecate and stop using getHighlightHtml()"
jenkins-bot [Fri, 9 May 2014 10:18:09 +0000 (10:18 +0000)]
Merge "Add $wgServerName"
Bartosz Dziewoński [Mon, 5 May 2014 15:59:54 +0000 (17:59 +0200)]
Content: Deprecate and stop using getHighlightHtml()
That function was clearly a bad idea, everyone should just use
getHtml() instead. It was supposed to allow extensions to extend
the content formatting process, but actually doesn't.
A better hook-based solution follows in separate commit I979e2438.
Split off from original I979e2438 and rebased with minor changes
(updated documentation comments, etc.).
Co-Authored-By: daniel <daniel.kinzler@wikimedia.de>
Co-Authored-By: Bartosz Dziewoński <matma.rex@gmail.com>
Change-Id: I76412f9d28bb145fb5975f59e538f6560e50472f
Ori Livneh [Tue, 6 May 2014 01:07:16 +0000 (18:07 -0700)]
Expose server name in rc feed
Reviewers of Id819246a9 (Tim, Timo, Chad) have commented that it
would be preferable to identify wikis by their canonical hostname
rather than the value of $wgDBname. Exposing it here so that
the rcstream server can filter subscriptions by it.
Change-Id: I503a0134a8613daddaae9d8df29a1e27fbfd93bc
Bartosz Dziewoński [Fri, 9 May 2014 09:54:26 +0000 (11:54 +0200)]
ChangesListSpecialPage: Correctly show legend if patrolling of only new pages is enabled
Change-Id: I3cf773c3b0d9b6e2d220c0f95ced35ef7fa4de2b
Ori Livneh [Tue, 6 May 2014 09:31:24 +0000 (02:31 -0700)]
Add $wgServerName
This partially reverts r73950 which removed $wgServerName on the ground that it
was only used for {{SERVERNAME}}. When it was pointed out that $wgServerName was
also used by several extensions, the response was not to restore the variable, but
to proceed to remove it from extensions as well.
It is a useful variable to have, as the discussion on Id819246a9 makes clear
(see Tim's comment on PS12 and Timo's reply). So let's reintroduce it, and expose
it in mw.config and ApiQuerySiteInfo as well.
Change-Id: I40a6fd427d38c64c628f70a2f407b145443ea204
jenkins-bot [Fri, 9 May 2014 09:13:15 +0000 (09:13 +0000)]
Merge "Add jQuery Migrate"
jenkins-bot [Fri, 9 May 2014 08:49:57 +0000 (08:49 +0000)]
Merge "ResourceLoaderModule: Add @since annotations to new methods"
Brian Wolff [Sun, 27 Oct 2013 20:18:06 +0000 (17:18 -0300)]
Throw an error if calling parser recursively
People accidentally (or sometimes intentionally) calling the
parser recursively has been a major source of bugs over the
years. I think its much better to fail suddenly, instead
of having unclear signs like UNIQ's all over the place.
Change-Id: I0e42aa69835c15a5df7aecb0dc5c3dec946bdf6a
Timo Tijhof [Mon, 5 May 2014 16:33:23 +0000 (18:33 +0200)]
Add jQuery Migrate
We're currently on jQuery v1.8.3. jQuery v1.9 introduces breaking
changes. The jQuery Migrate plugin adds a compatibility layer
that brings back most removed or altered functionality.
It can also be loaded on an older version of jQuery to make use
of the plugins' accessor tracking that helps finding code
that makes use of the deprecated functionality prior to upgrading.
Code:
http://code.jquery.com/jquery-migrate-1.2.1.js
Info:
http://blog.jquery.com/2013/01/15/jquery-1-9-final-jquery-2-0-beta-migrate-final-released/
http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
https://github.com/jquery/jquery-migrate/
> The plugin can be included with versions of jQuery as old as
> 1.6.4 to identify potential upgrade issues via its JQMIGRATE
> console warnings. However, the plugin is only required for
> version 1.9.0 or higher to restore deprecated and removed
> functionality.
Loading it alongside jquery.js should be harmless. However to
benefit performance, I'm only loading it in debug mode.
Plus, there's a small chance that it does actually change
functionality because of the way it is implemented. The plugin
always overloads the methods with compatibility versions, which
should effectively be a no-op on top of old version of jQuery
like ours (one that already has the old functionality), but it
feels too risky at this stage when our only intent is
instrumentation.
Bug: 44740
Change-Id: I468d6b45eae8368fac6af746bbb2ccb702f862ff
Addshore [Thu, 8 May 2014 23:41:01 +0000 (23:41 +0000)]
Merge "Fix CodeSniffer errors and warnings in includes/utils/"
Translation updater bot [Thu, 8 May 2014 20:44:47 +0000 (20:44 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I8b8596065dd60b84be5b34be6a2795d97b982da1
Bartosz Dziewoński [Thu, 8 May 2014 20:26:42 +0000 (22:26 +0200)]
ResourceLoaderModule: Add @since annotations to new methods
Change-Id: I91434fcdc87efdf6d49ec94348f26d20c840abad
jenkins-bot [Thu, 8 May 2014 20:03:10 +0000 (20:03 +0000)]
Merge "Fix declaration of ForeignDBFile::delete()"
Siebrand Mazeland [Thu, 8 May 2014 19:15:09 +0000 (21:15 +0200)]
Fix CodeSniffer errors and warnings in includes/utils/
Change-Id: I5e59dd8136fcbd8dc833d7c9f6288656e13df6e9
Faidon Liambotis [Wed, 7 May 2014 17:01:16 +0000 (20:01 +0300)]
img_auth: handle files in the transcoded zone
img_auth.php does not currently handle filepaths for transcoded videos
at all, and instead falls back attempting to open files out of the
public zone, which obviously fails as these files do not exist there.
Add a branch that handles transcoded containers in the same manner as
thumbs and thus allowing access to those files from private wiki.
Bug: 65007
Change-Id: I7182206ba09dd2466fc51aa1d51116dd13db980c
Timo Tijhof [Thu, 8 May 2014 11:03:30 +0000 (13:03 +0200)]
mediawiki.user.test: Remove dated comment about "qunit/index.html"
That file was removed in MediaWiki 1.20.
Change-Id: Iffeb039bbbc6843a83d3796541ebb1773281c01f
Siebrand Mazeland [Wed, 7 May 2014 12:37:59 +0000 (14:37 +0200)]
Fix i18n issue in Special:NewImages
As Rillke has reported in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Showhidebots/en
the text for the check box was incorrect. It turned out to be a strange
re-use of messages. Replaced it with a proper message.
No re-uses in core. Remaining re-use outside of core has been taken care of
in I4458ab7f6e53
Change-Id: I48042d0e60ce213db3db123179d9658cdd013a8f
umherirrender [Wed, 7 May 2014 17:42:35 +0000 (19:42 +0200)]
Fix declaration of ForeignDBFile::delete()
Strict Standards: Declaration of ForeignDBFile::delete() should be
compatible with that of LocalFile::delete()
Followed-Up: I60cab27e0708a818c77791cc89194b6dd726da0b
Change-Id: I11d32c0a529ec76978cde38c038b4984ca13e8ba
Siebrand Mazeland [Wed, 7 May 2014 12:16:24 +0000 (14:16 +0200)]
Convert leading spaces to tabs
Change-Id: I416376c861661fdd34ab42675e06c8c43041a978
Translation updater bot [Wed, 7 May 2014 19:53:34 +0000 (19:53 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie146731bd82d74d95820be5b8fc0df914f7f4abc
jenkins-bot [Wed, 7 May 2014 19:46:25 +0000 (19:46 +0000)]
Merge "mediawiki.page.watch.ajax: Don't use deprecated tooltipAccessKeyRegexp"
Timo Tijhof [Wed, 7 May 2014 17:58:56 +0000 (19:58 +0200)]
mediawiki.api: Don't log request error 'abort'
Not really an error, but that's outside of our control. This
change doesn't affect the actual Promise object. Callers will
still get this through the error handler.
If the request was aborted by the caller of mw.Api#ajax, there
is no need to log this to the console. Only pollutes it with
garbage.
This was rather visible when browsing with debug=true and e.g.
using search suggestions (and typing faster than requests are
dispatched and completed).
If a caller really wants to log this, they can easily do so from
their error handler.
Change-Id: I7797c833745b452109868675531f808c3d900534
Timo Tijhof [Wed, 7 May 2014 17:49:25 +0000 (19:49 +0200)]
mediawiki.page.watch.ajax: Don't use deprecated tooltipAccessKeyRegexp
Remove dependency on 'mediawiki.page.startup' since this is no
longer needed (it was there to ensure mw.util.init, which used to
populate mw.util.tooltipAccessKeyRegexp, ran first).
Change-Id: Iceecc228bce676de84de35220fa4d217be0f0b75
jenkins-bot [Wed, 7 May 2014 13:32:50 +0000 (13:32 +0000)]
Merge "Release notes for Ib5032e4e"
jenkins-bot [Wed, 7 May 2014 12:27:47 +0000 (12:27 +0000)]
Merge "mediawiki.action.edit.editWarning: Reuse jQuery collections"
Derk-Jan Hartman [Tue, 6 May 2014 11:25:57 +0000 (13:25 +0200)]
mediawiki.action.edit.editWarning: Reuse jQuery collections
Change-Id: I3084efe5962bb6a13700f95745c415fb074bc7bd
Bartosz Dziewoński [Wed, 7 May 2014 12:14:07 +0000 (14:14 +0200)]
Release notes for Ib5032e4e
Change-Id: I47899d0a8a6ae01fc71d76b9c913e170e87fa9c1
jenkins-bot [Wed, 7 May 2014 11:46:09 +0000 (11:46 +0000)]
Merge "resourceloader: Report problematic modules in only=styles as well"
Timo Tijhof [Tue, 6 May 2014 23:29:37 +0000 (01:29 +0200)]
mediawiki.toc: Clean up left overs
Follows-up
d7a40c8 which creates the mediawiki.toc module and
moved the tocToggle method from mediawiki.util.
The tocToggle callback used to be a public method and therefore
had two things about that that are obsolete:
* Taking the toggle as parameter.
This is a private method now, and we already have a reference
to the toggle.
* Asserting that the #toc has an <ul>.
There is no need to defer this check this far in, nor to repeat
it on each click. The old code checked it earlier was well, but
we used to repeat the check here as the method was public.
Now that it is a private helper method we can simply return
early before setting it all up in the first place.
Also:
* Removed jsduck-like construction. This file is being indexed,
as part of src/mediawiki/, but turning this into a class seems
odd. It doesn't really have any structure to it.
It's just UI glue. Turned it into an ignored file (no doc blocks).
Change-Id: I21d4f735032b96f00291502e06d9d35a74648143
jenkins-bot [Wed, 7 May 2014 02:38:09 +0000 (02:38 +0000)]
Merge "Clarify docs for wgCookieExpiration"
Matthew Flaschen [Wed, 7 May 2014 02:33:18 +0000 (22:33 -0400)]
Clarify docs for wgCookieExpiration
Change-Id: Ie6c77c5251e906dcee1650b3a4598da6adb30e30
Antoine Musso [Tue, 6 May 2014 19:28:22 +0000 (21:28 +0200)]
API: Expose git branch in siteinfo
For browser testing, I need a reliable way to determine the branch in use
on a target wiki. One could parse the generator name forged when
querying the siteinfo, but that yields:
MediaWiki 1.24alpha instead of master
MediaWiki 1.24wmf2 instead of wmf/1.24wmf2
I am not really willing to reverse engineer the version to figure out
the branch, instead just expose it over the API.
Bug: 62509
Change-Id: If3db8f480ce0d590522741d40fb8e43b753efb41
Fomafix [Tue, 6 May 2014 20:08:46 +0000 (20:08 +0000)]
mediawiki.toc: Hide toc without animation in initial collapsed state
Bug: 64927
Change-Id: I5b46390b3dc6e42031f636119673892507151f54
jenkins-bot [Tue, 6 May 2014 21:20:21 +0000 (21:20 +0000)]
Merge "Pass $user to LocalFileDeleteBatch"
jenkins-bot [Tue, 6 May 2014 20:32:48 +0000 (20:32 +0000)]
Merge "Make gallery properties publically accessible."
Translation updater bot [Tue, 6 May 2014 20:03:57 +0000 (20:03 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 6 May 2014 19:51:14 +0000 (19:51 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Ieca93135f7af56bc2079362cc763e7204a8024cb
umherirrender [Tue, 6 May 2014 19:03:45 +0000 (21:03 +0200)]
Pass $user to LocalFileDeleteBatch
This avoids the use of $wgUser
Change-Id: I60cab27e0708a818c77791cc89194b6dd726da0b
Bryan Davis [Tue, 6 May 2014 19:15:09 +0000 (13:15 -0600)]
Check for valid git repository in GitInfo::getHeadCommitDate
Ensure that GitInfo::getHead returns a valid value before attempting to
use the git binary to extract a commit date.
Bug: 64948
Change-Id: Ib0d245306842706dbb5d4b9522bb381a5f55526c
jenkins-bot [Tue, 6 May 2014 19:04:05 +0000 (19:04 +0000)]
Merge "Fix typo for system message name"