From: Jackmcbarn <jackmcbarn@gmail.com>
Date: Tue, 14 Oct 2014 00:48:46 +0000 (-0400)
Subject: Remove negative caching from Revision::getContentInternal
X-Git-Tag: 1.31.0-rc.0~13540^2
X-Git-Url: http://git.cyclocoop.org///%22%40url%40//%22?a=commitdiff_plain;h=e3c3e55b83dd1c9b53e1fdb8baed4b8aad33adc0;p=lhc%2Fweb%2Fwiklou.git

Remove negative caching from Revision::getContentInternal

Negative caching in Revision::getContent can cause race conditions, so
stop doing it.

Bug: 71545
Change-Id: Iac32b2d4f90c4c1ce37820288f757e47b6d895e7
---

diff --git a/includes/Revision.php b/includes/Revision.php
index 5b39a41b20..e81ed755f7 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -1060,8 +1060,6 @@ class Revision implements IDBAccessObject {
 				$format = $this->getContentFormat();
 
 				$this->mContent = $handler->unserializeContent( $this->mText, $format );
-			} else {
-				$this->mContent = false; // negative caching!
 			}
 		}