Roan Kattouw [Thu, 8 Sep 2011 13:49:48 +0000 (13:49 +0000)]
Add tests for r96562. HttpTest still has 5 failing test (which is why it's marked @broken) and per Chad on IRC most of this suite is pure evil
Roan Kattouw [Thu, 8 Sep 2011 13:48:11 +0000 (13:48 +0000)]
Move URL expansion from Http::request() (where it was put in r93820) to MWHttpRequest::__construct(). That should fix bug 30797 (UploadStash barfs on protocol-relative URLs)
Niklas Laxström [Thu, 8 Sep 2011 10:13:01 +0000 (10:13 +0000)]
Improve r96548: fixed one fatal, restored user tool links and removed a little duplication
Raimond Spekking [Thu, 8 Sep 2011 09:16:42 +0000 (09:16 +0000)]
Add a CSS class to the metadata/EXIF table row which shows the text 'Show extended details' and hide this row for printing. Useless because you cannot click on the paper :)
Niklas Laxström [Thu, 8 Sep 2011 09:15:59 +0000 (09:15 +0000)]
Update ChangesList and derivatives to use LogFormatter.
This diff is a bit ugly. There is lots of duplication in ChangesList code.
Hopefully it is little better now, when most of the formatting is in LogFormatter.
Niklas Laxström [Thu, 8 Sep 2011 09:09:38 +0000 (09:09 +0000)]
Enabled MoveLogFormatter
-> This brings better i18n even to existing move log entries
Fixed the class name from r96441, it's Move not Block
Added notes about new naming conventions to DefaultSettings.php
-> didn't bother the remain existing messages now, they will keep working
Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries.
Niklas Laxström [Thu, 8 Sep 2011 08:57:02 +0000 (08:57 +0000)]
Use LogFormatter to format log entries.
* Anonymous users now display correctly
This paves the way for new LogFormatters than enable proper i18n.
Each log type must be converted individually.
Niklas Laxström [Thu, 8 Sep 2011 08:51:32 +0000 (08:51 +0000)]
Split getTypeMenu into two functions:
* the current functions does the ugly thing extracting the current log type from array
* the new function just builds the selector, using XmlSelect - clearer and more flexible
Niklas Laxström [Thu, 8 Sep 2011 08:46:39 +0000 (08:46 +0000)]
Change LogEventsList to use query info from DatabaseLogEntry.
The only changes in the query are:
* New fields: log_user_text, user_id
* INNER JOIN on user table is changed to LEFT JOIN
* AND (user_id = log_user) is dropped from WHERE conditions (looks redundant, easy to add back if needed)
This means that log entries from anonymous users are not dropped anymore.
Those will actually get displayed correctly after the next commit.
It is also possible to use User::newFromRow for non-anonymous users now.
Niklas Laxström [Thu, 8 Sep 2011 08:22:10 +0000 (08:22 +0000)]
Deprecated showHeader and make it use the new methods. Only caller anymore is MetavidWiki - trying to find out what is going to be the fate of that extension.
Chad Horohoe [Thu, 8 Sep 2011 03:13:31 +0000 (03:13 +0000)]
Rm old options from commandLine.inc days
Chad Horohoe [Thu, 8 Sep 2011 01:54:27 +0000 (01:54 +0000)]
Stupid merge conflicts, fix r96537
Chad Horohoe [Thu, 8 Sep 2011 01:52:36 +0000 (01:52 +0000)]
Last fix for r96529, I swear...only CommonSettings.php needs interpretPath(). Core loadSettings() already returns LocalSettings with $IP prefixed.
Chad Horohoe [Thu, 8 Sep 2011 00:59:58 +0000 (00:59 +0000)]
Another fix for r96529: using MW_CONFIG_CALLBACK should halt normal settings file loading. Broke command-line installer
Chad Horohoe [Thu, 8 Sep 2011 00:35:16 +0000 (00:35 +0000)]
Tweaks to WikimediaMaintenance:
* Rename Site to WMFSite, less likely to conflict
* Create generic inclusion point for these scripts, so they don't have to duplicate the $IP detection
* Make them all subclass WikimediaMaintenance and move some of the wmf-specific hacks out of core -- almost resolved this crap :D
* Fix rebuildInterwiki to be protocol-relative (like r96139)
* By the way: rebuildInterwiki and dumpInterwiki seem awfully alike...maybe we can merge the two :)
Aaron Schulz [Wed, 7 Sep 2011 23:41:12 +0000 (23:41 +0000)]
Reverted r88023 per CR
Sam Reed [Wed, 7 Sep 2011 23:21:41 +0000 (23:21 +0000)]
Merge r90266 to trunk
Fixes fixme on r75341, r75343
Russ Nelson [Wed, 7 Sep 2011 22:57:05 +0000 (22:57 +0000)]
split out the inside of File::transform() to avoid copying all of transform for SwiftMedia
Brion Vibber [Wed, 7 Sep 2011 22:03:16 +0000 (22:03 +0000)]
Followup to r86108, r86854, r96384: table sorter fetch of 'data-sort-value' attribute failed on IE 6/7 due to directly using DOM methods not available in those browsers.
hasAttribute and getAttribute don't appear until IE 8 in Microsoft-land; switching to jQuery's .attr() resolves this nicely.
Sam Reed [Wed, 7 Sep 2011 21:14:55 +0000 (21:14 +0000)]
Fix whitespace
Swap xor for ^
Documentation
Sam Reed [Wed, 7 Sep 2011 20:50:40 +0000 (20:50 +0000)]
Followup r96479, move files to WikimediaMaintenance
Added missing svn:eol-style native
Files still need updating to point back to the MW maintenance dir
Sam Reed [Wed, 7 Sep 2011 20:40:42 +0000 (20:40 +0000)]
Move addWiki, dumpInterwiki, ourusers, rebuildInterwiki, renameWiki and Site to WikimediaMaintenance "extension"
Antoine Musso [Wed, 7 Sep 2011 20:28:49 +0000 (20:28 +0000)]
complement r96386 tests
Ariel Glenn [Wed, 7 Sep 2011 20:21:52 +0000 (20:21 +0000)]
get rid of duplication, remove unused function rename(), add documentation as per comments on r95260
Sam Reed [Wed, 7 Sep 2011 19:55:38 +0000 (19:55 +0000)]
Bug 30806 - Userrights-notallowed message inaccurate
Message updated, not exactly per example given
Ben Hartshorne [Wed, 7 Sep 2011 19:46:18 +0000 (19:46 +0000)]
adding tools to parse the output of storageTypeStats.php
Raimond Spekking [Wed, 7 Sep 2011 19:15:44 +0000 (19:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Brian Wolff [Wed, 7 Sep 2011 19:14:06 +0000 (19:14 +0000)]
$wgOverrideSiteFeed was double escaping urls (noticed in bug 30621).
(aka it was giving things with & in them :s )
Aaron Schulz [Wed, 7 Sep 2011 17:55:37 +0000 (17:55 +0000)]
For r91123:
* Moved generateReason() to WikiPage. This fixes the PureWikiDeletion ext too.
* Make Checkpoint ext call getRawText() as doEdit() does. Aalso, WikiPage doesn't have fetchContent().
* Call getAutosummary() statically in doEdit().
* Fixed outdated code comment.
* Fixed title used in unit test.
Siebrand Mazeland [Wed, 7 Sep 2011 17:25:52 +0000 (17:25 +0000)]
Ran stylize.php. Required manual corrections:
* $params[$index-1] was changed to $params[$index -1] instead of $params[$index - 1]
* ///!< @var string was changed to /// !< @var string, but should have remain unchanged.
Siebrand Mazeland [Wed, 7 Sep 2011 17:11:15 +0000 (17:11 +0000)]
Follow-up CR comment by Nikerabbit on r96433: Do not rely on implicit conversion of message object to string; explicit parse().
Siebrand Mazeland [Wed, 7 Sep 2011 17:00:46 +0000 (17:00 +0000)]
Mark userLink, userTalkLink, blockLink() and emailLink() as public static per CR comment on r96420 by Nikerabbit.
He suggested protected, because of the @private comment, but as we have made more methods public static in the Linker class recently, this seems appropriate.
Niklas Laxström [Wed, 7 Sep 2011 16:20:23 +0000 (16:20 +0000)]
RecentChange::notifyMove* have no callers. Everything uses ::notifyLog or ::newLogEntry.
Niklas Laxström [Wed, 7 Sep 2011 16:11:37 +0000 (16:11 +0000)]
Ffixes to r96443 and r96441
Niklas Laxström [Wed, 7 Sep 2011 16:09:24 +0000 (16:09 +0000)]
Validate log type here, and moved showHeader to the special page where it belongs.
LogEventsList::showHeader still kept, because one extension calls it.
Niklas Laxström [Wed, 7 Sep 2011 15:39:01 +0000 (15:39 +0000)]
Load edit count separately. The logging system batch queries it for the user tool links, which uses it for coloring.
Niklas Laxström [Wed, 7 Sep 2011 15:32:37 +0000 (15:32 +0000)]
Committing my new logging classes for review. Will later commit changes that use these classes.
Roan Kattouw [Wed, 7 Sep 2011 14:17:42 +0000 (14:17 +0000)]
Followup r96437: actually define PROTO_INTERNAL
Roan Kattouw [Wed, 7 Sep 2011 14:15:03 +0000 (14:15 +0000)]
Actually fix bug 30792, despite my earlier claims. SquidUpdate::purge('//upload.wikimedia.org/foo') would return 'commons.wikimedia.org//upload.wikimedia.org/foo'
Introduce PROTO_INTERNAL much like PROTO_CANONICAL, and use it in SquidUpdate::purge()
Robin Pepermans [Wed, 7 Sep 2011 14:04:37 +0000 (14:04 +0000)]
Correct fallback from Malayalam (ml) to Malay (ms) for Dusun (dtp) spoken in Malaysia
Siebrand Mazeland [Wed, 7 Sep 2011 13:52:43 +0000 (13:52 +0000)]
Follow-up r96429: use wfMessage() to make it work properly. Previously $userToolLinks was escaped.
Siebrand Mazeland [Wed, 7 Sep 2011 13:35:01 +0000 (13:35 +0000)]
Follow-up r96420: correct casing for special page to prevent "PHP Notice: Found alias defined for Emailuser when searching for special page aliases for EmailUser. Case mismatch?".
Siebrand Mazeland [Wed, 7 Sep 2011 13:30:07 +0000 (13:30 +0000)]
Add "send e-mail" link on Special:Userrights and replace the "manual" tool links in the process.
Chad Horohoe [Wed, 7 Sep 2011 13:04:40 +0000 (13:04 +0000)]
rv r96424, Roan had his fun
Raimond Spekking [Wed, 7 Sep 2011 12:56:06 +0000 (12:56 +0000)]
Fix r95655 per Formfix's CR:
* use getCanonicalURL() - this part should be deployed to 1.17wmf1
* Do not show &oldid= in case of nonexisting pages, incl. file description pages from InstantCommons files
Roan Kattouw [Wed, 7 Sep 2011 12:54:57 +0000 (12:54 +0000)]
Some comment and whitespace fixes
Roan Kattouw [Wed, 7 Sep 2011 12:48:51 +0000 (12:48 +0000)]
Break some tests intentionally to see how Jenkins displays that
Siebrand Mazeland [Wed, 7 Sep 2011 12:12:24 +0000 (12:12 +0000)]
Add constant Linker::TOOL_LINKS_EMAIL to allow adding a "send e-mail" link from Linker::
Add "send e-mail" link in user tools for developer details (Special:Code/Project/author/authorname) in CodeReview.
Sam Reed [Wed, 7 Sep 2011 12:00:58 +0000 (12:00 +0000)]
Documentation
Add explicit member variables
Trim trailing whitespace
Niklas Laxström [Wed, 7 Sep 2011 09:21:16 +0000 (09:21 +0000)]
Removed old constants: 1) not used 2) because of autoloader, they have not necessarily even been available for long time.
Alexandre Emsenhuber [Wed, 7 Sep 2011 08:29:18 +0000 (08:29 +0000)]
Pass the context to the HTMLForm object
Alexandre Emsenhuber [Wed, 7 Sep 2011 08:18:51 +0000 (08:18 +0000)]
Use local context instead of global variables
Robin Pepermans [Wed, 7 Sep 2011 05:23:16 +0000 (05:23 +0000)]
Per Krinke on r91772, do not use general float/align classes. I removed them in shared.css because they are recent and not widely used yet.
(I removed the vertical-align:bottom; because it is added by css for .collection-creatorbox-row img)
Robin Pepermans [Wed, 7 Sep 2011 04:05:37 +0000 (04:05 +0000)]
Per r90858 CR, throw MW exception on missing title context
Daniel Friesen [Wed, 7 Sep 2011 03:46:05 +0000 (03:46 +0000)]
Move h1-5 bottom margins to commonElements, common generic siteNotice styles and firstHeading to commonInterface.
Daniel Friesen [Wed, 7 Sep 2011 03:25:11 +0000 (03:25 +0000)]
Move the vector styles for the user login form into commonContent.css
The vector styles are very generic and fit well as the common style. With a minor tweak to MonoBook (which actually partially fixes a bug in the signup form on Wikipedia) this style fits in perfectly without conflicting with MonoBook's styles.
Russ Nelson [Wed, 7 Sep 2011 02:31:55 +0000 (02:31 +0000)]
restore proper operation of getArchive{Path|Url}
Daniel Friesen [Wed, 7 Sep 2011 01:12:00 +0000 (01:12 +0000)]
Followup r96217, slight regression use rawElement not element, accidentally caused the <a> to be htmlescaped.
Russ Nelson [Wed, 7 Sep 2011 01:09:23 +0000 (01:09 +0000)]
purgeThumbList() needn't always delete all the files in the thumb dir
Daniel Friesen [Wed, 7 Sep 2011 00:37:44 +0000 (00:37 +0000)]
Followup r92054, these should use css classes not ids.
Ben Hartshorne [Tue, 6 Sep 2011 23:21:39 +0000 (23:21 +0000)]
changed help text to indicate an optional port if nonstandard
Aaron Schulz [Tue, 6 Sep 2011 23:15:42 +0000 (23:15 +0000)]
Fixed typo in ipv6 private IP range list and added test (bug 30739)
Krinkle [Tue, 6 Sep 2011 23:09:04 +0000 (23:09 +0000)]
jquery.tablesorter.test: Add tests for data-sort-value
* Follows-up r86108
Roan Kattouw [Tue, 6 Sep 2011 22:17:01 +0000 (22:17 +0000)]
Fix parse error in r96275
Russ Nelson [Tue, 6 Sep 2011 21:51:25 +0000 (21:51 +0000)]
delete now-empty archived thumb directories
Chad Horohoe [Tue, 6 Sep 2011 21:01:42 +0000 (21:01 +0000)]
(bug 30192) Thumbnails of archived images don't get deleted. Patch by Russ and Sam, with minor tweaks by me.
Chad Horohoe [Tue, 6 Sep 2011 20:51:10 +0000 (20:51 +0000)]
Followup r96369: update child classes and a few callers
Chad Horohoe [Tue, 6 Sep 2011 20:44:03 +0000 (20:44 +0000)]
Fixme on r85888: boolean params are evil, use a nice simple string instead :)
Jeroen De Dauw [Tue, 6 Sep 2011 20:31:51 +0000 (20:31 +0000)]
doc fix
Raimond Spekking [Tue, 6 Sep 2011 20:24:15 +0000 (20:24 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Tue, 6 Sep 2011 19:28:27 +0000 (19:28 +0000)]
Fix trailing whitespaces
Sam Reed [Tue, 6 Sep 2011 19:20:20 +0000 (19:20 +0000)]
-rakkaus/#mediawiki-i18n- [06-Sep-2011 19:12:04] PHP Fatal error: Call to a member function titleAttrib() on a non-object in /www/w/includes/SkinTemplate.php on line 1538
Ryan Lane [Tue, 6 Sep 2011 18:45:36 +0000 (18:45 +0000)]
Set wsDomain based on the user's session, if domain is set in the session. When users use the password change function in their preferences a domain isn't passed, it's assumed to be in their session.
Aaron Schulz [Tue, 6 Sep 2011 18:11:53 +0000 (18:11 +0000)]
Cleanup to r84610 per CR: changed BeforeParserMakeImageLinkObj hook to use a RepoGroup style param array that also excepts a 'broken' parameter. This new parameter replaces the odd "use timestamp '0' to make a broken thumbnail' convention. No other callers are using this hook other than FR, so the old time/sha1 params where removed.
Aaron Schulz [Tue, 6 Sep 2011 18:02:44 +0000 (18:02 +0000)]
Sanity check report size to avoid division by zero
Max Semenik [Tue, 6 Sep 2011 16:47:05 +0000 (16:47 +0000)]
Fix for r96344: explicitly set $wgExtensionAssetsPath during tests
Sam Reed [Tue, 6 Sep 2011 15:45:43 +0000 (15:45 +0000)]
Followup r95458
Add a couple of bits of documentation
Removed an unused global
No need to 1.18 this
Daniel Friesen [Tue, 6 Sep 2011 15:27:42 +0000 (15:27 +0000)]
Small MonoBook cleanup:
* Eliminate the unnecessary ->skin and $skin, $this->skin is only used in one spot and we have getSkin()
* Linker::tooltipAndAccesskeyAttribs isn't &, don't + it to an empty array(), just use a short inline array instead of this var
* Elimiate all this unnecessary code in cactions and just use makeListItem. It's shorter, outputs everything this code does, AND it outputs rel="archive" on history which was missing from MonoBook.
Sam Reed [Tue, 6 Sep 2011 15:23:26 +0000 (15:23 +0000)]
Fix Undefined index: showSizeDiff in /www/w/includes/specials/SpecialContributions.php on line 129
Followup r96306
Max Semenik [Tue, 6 Sep 2011 15:20:07 +0000 (15:20 +0000)]
Even on Windows, some people have diff ;)
Chad Horohoe [Tue, 6 Sep 2011 14:46:58 +0000 (14:46 +0000)]
Merge ParserTestStaticParserHook into ParserTestParserHook since they practically do the same thing.
Robin Pepermans [Tue, 6 Sep 2011 14:08:13 +0000 (14:08 +0000)]
Add new messages of r96311 to messages.inc
Robin Pepermans [Tue, 6 Sep 2011 14:04:30 +0000 (14:04 +0000)]
Fix wording of r96312 and a few other release notes
Alexandre Emsenhuber [Tue, 6 Sep 2011 13:17:22 +0000 (13:17 +0000)]
Use $this->mAttribs['rc_old_len'] and $this->mAttribs['rc_new_len'] instead of $this->mExtra['oldSize'] and $this->mExtra['newSize']
Chad Horohoe [Tue, 6 Sep 2011 12:39:47 +0000 (12:39 +0000)]
Cleanup to r95402, r95474: "Not using CamelCase is so 2001."
Alexandre Emsenhuber [Tue, 6 Sep 2011 12:23:47 +0000 (12:23 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Niklas Laxström [Tue, 6 Sep 2011 11:14:34 +0000 (11:14 +0000)]
Generic class cannot really wrap around mysql method..
Robin Pepermans [Tue, 6 Sep 2011 00:04:02 +0000 (00:04 +0000)]
release notes for r96311
Robin Pepermans [Tue, 6 Sep 2011 00:01:06 +0000 (00:01 +0000)]
(bug 23057) Importers can 'edit' or 'create' a fully-protected page by importing a new revision into it
Krinkle [Mon, 5 Sep 2011 23:10:33 +0000 (23:10 +0000)]
mediawiki.html: Attribute values may also be numbers (rather than boolean or string). Just make sure that whatever is passed becomes a string (not using .toString as not everything has a toString method)
* Follows-up r96307
Krinkle [Mon, 5 Sep 2011 21:53:20 +0000 (21:53 +0000)]
release-notes for r96307
Krinkle [Mon, 5 Sep 2011 21:51:04 +0000 (21:51 +0000)]
mediawiki.html: mediawiki.html: Add support for numbers and booleans
* Tests introduced in r96305 work now
* (bug 30774) - mediawiki.html: Add support for numbers and booleans
--
* Removed unneeded value-attribute in one the tests
* Changed if-else intro a switch. (to avoid calling the typeof operator multiple times and making the code a bit more readable)
Roan Kattouw [Mon, 5 Sep 2011 21:47:28 +0000 (21:47 +0000)]
Revert r88008 (add size difference to Special:Contributions) and its large group of friends, they break Special:Contributions by joining against recentchanges and dropping any contribs that have fallen off RC. See also CR discussion at r95496, which was Sam's incomplete attempt at reverting this.
Follow-ups reverted: r88019, r88024, r88111, r88117, r88252, r96081. Left the parts of r88025 and r88026 (everything except the MessagesEn.php change) that disable the namespace filter in miser mode intact; that was a good change and not really related to the r88008 other than that it touched nearby code.
Krinkle [Mon, 5 Sep 2011 21:25:48 +0000 (21:25 +0000)]
mediawiki.html: Add broken tests for numbers and booleans
* The following are broken right now:
mw.html.element( 'p', {}, 500 );
> Error: mw.html.element: Invalid type of contents
(custom error by mw.html.element)
mw.html.element( 'option', { selected: foo === bar }, 'label' );
> TypeError: Undefined method .replace
(bug 30774) - mediawiki.html: Add support for numbers and booleans
Alexandre Emsenhuber [Mon, 5 Sep 2011 21:01:39 +0000 (21:01 +0000)]
Deleted incorrect svn:executable properties
Raimond Spekking [Mon, 5 Sep 2011 20:53:36 +0000 (20:53 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 5 Sep 2011 20:48:14 +0000 (20:48 +0000)]
Call Linker method statically; also changed it to linkKnown()
Daniel Friesen [Mon, 5 Sep 2011 19:30:11 +0000 (19:30 +0000)]
Another thing that's been bothering me, skins shouldn't have to access $wgSitenotice directly when we have a logopath.
Roan Kattouw [Mon, 5 Sep 2011 19:29:20 +0000 (19:29 +0000)]
Don't use $wgServer (potentially protocol-relative!) in the password reset e-mail. The documentation calls for $4 to be "the base URL of the wiki" and the code was using $wgServer . $wgScript which produces the URL to index.php , so I decided to use the URL to the Main Page instead. This avoids using globals and doesn't suffer from mixed URL structure issues on secure.wm.o
Robin Pepermans [Mon, 5 Sep 2011 18:37:50 +0000 (18:37 +0000)]
Partially revert/fix r96295: only use Gothic script per Siebrand