Translation updater bot [Wed, 23 Jul 2014 20:58:12 +0000 (20:58 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 23 Jul 2014 20:52:54 +0000 (20:52 +0000)]
Merge "Remove support for magic_quotes_gpc"
jenkins-bot [Wed, 23 Jul 2014 20:52:51 +0000 (20:52 +0000)]
Merge "resources: Switch oojs to the version optimised for environments with jQuery"
jenkins-bot [Wed, 23 Jul 2014 20:52:49 +0000 (20:52 +0000)]
Merge "Fix typo: MWExcepion -> MWException"
jenkins-bot [Wed, 23 Jul 2014 20:52:42 +0000 (20:52 +0000)]
Merge "Include ICU version in cache key for collation first letters"
jenkins-bot [Wed, 23 Jul 2014 20:38:32 +0000 (20:38 +0000)]
Merge "Fix documentation of HistoryPager::lastLink() and make code more readable"
Chad Horohoe [Wed, 9 Jul 2014 15:36:55 +0000 (08:36 -0700)]
Remove support for magic_quotes_gpc
This "feature" of PHP has been disabled by default for quite some
time, deprecated in 5.3 and removed entirely in 5.4.
See <http://www.php.net/manual/en/security.magicquotes.php> for
information on why this practice is bad and how to disable it.
For MediaWiki, the removed todo comment says it all. Doing this
messes with all of the super globals and makes embedding MediaWiki
inside another application problematic. It also increases our
memory footprint for every single request even when the data might
not be used.
Finally, it makes it possible to instantiate new WebRequest objects
pretty much whenever you want, so there's no reason for $wgRequest
to exist anymore.
Bug: 11558
Change-Id: I4bc0392276f454ceb966547c7fbd7c8190ebbc7c
Translation updater bot [Wed, 23 Jul 2014 20:37:20 +0000 (22:37 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I875fda4c74419c916f9c992c885234613c39272b
jenkins-bot [Wed, 23 Jul 2014 20:36:52 +0000 (20:36 +0000)]
Merge "Standardize @todo"
withoutaname [Mon, 21 Jul 2014 22:10:25 +0000 (15:10 -0700)]
Remove RequestContext from edit.php and fixDoubleRedirects.php
Change-Id: I9388e6b3fec3c8ea92099aeaf010dd067f62a20f
umherirrender [Wed, 23 Jul 2014 20:04:48 +0000 (22:04 +0200)]
Standardize @todo
Always use lowercase @todo
Changed some "@FIXME" to "@todo FIXME: "
Change-Id: I016d1f9511e6f3bbd22427f0fffeccd77ab5e0db
James D. Forrester [Wed, 23 Jul 2014 19:57:40 +0000 (12:57 -0700)]
resources: Switch oojs to the version optimised for environments with jQuery
Change-Id: Ic8cc04c2e89203825efe64ecc3c91d0cae0b2daa
umherirrender [Wed, 23 Jul 2014 19:55:22 +0000 (21:55 +0200)]
Fix typo: MWExcepion -> MWException
Change-Id: I3527eb8314ec577a118ed4fc897768224d63092a
jenkins-bot [Wed, 23 Jul 2014 18:33:31 +0000 (18:33 +0000)]
Merge "Add since to @deprecated in includes/site"
jenkins-bot [Wed, 23 Jul 2014 18:33:29 +0000 (18:33 +0000)]
Merge "Docs: {function} -> callable"
jenkins-bot [Wed, 23 Jul 2014 18:33:25 +0000 (18:33 +0000)]
Merge "Fixed some @params documentation (includes/utils)"
jenkins-bot [Wed, 23 Jul 2014 12:01:45 +0000 (12:01 +0000)]
Merge "api.php: Use $wgRequest to retrieve User-agent string"
jenkins-bot [Wed, 23 Jul 2014 11:35:47 +0000 (11:35 +0000)]
Merge "Provide namespace to ApiParse->getSectionContent"
jenkins-bot [Wed, 23 Jul 2014 06:59:31 +0000 (06:59 +0000)]
Merge "Shorten if/else to ternary expressions in WebStart.php"
jenkins-bot [Wed, 23 Jul 2014 05:36:24 +0000 (05:36 +0000)]
Merge "Remove deprecated class StubContLang"
withoutaname [Wed, 23 Jul 2014 05:07:04 +0000 (22:07 -0700)]
Remove deprecated class StubContLang
Change-Id: I4569f5d59018f0d5082888fdc737cf30370bcbdd
Brian Wolff [Mon, 21 Jul 2014 22:25:36 +0000 (19:25 -0300)]
Include ICU version in cache key for collation first letters
The cache key is only valid for specific versions of icu extension.
If you upgrade php, the cache key should get refreshed.
Note: Changing your version of icu (e.g. by upgrading php)
still requires updateCollation.php --force to be run. This
patch does nothing to change that.
Note: Have not tested on hhvm, which is what the original bug
report was about.
Bug: 68344
Change-Id: Ib5ac2adc34a5a120b916cebcf62ff3d6ee057403
jenkins-bot [Wed, 23 Jul 2014 01:57:04 +0000 (01:57 +0000)]
Merge "Call to a member function getText() on a non-object"
S Page [Wed, 23 Jul 2014 01:26:53 +0000 (18:26 -0700)]
Provide namespace to ApiParse->getSectionContent
Improves the "Sections are not supported by <PAGE>" error message when
it fails. Also add phpdoc comment
Bug: 68416
Change-Id: Iaa5d3a1f33b8a9c48263c2ce27cd3b4fe98fbf01
Roan Kattouw [Tue, 22 Jul 2014 23:50:10 +0000 (16:50 -0700)]
Update messages list for oojs-ui
In the recent window rewrite, some messages were added, removed or renamed.
Bug: 68327
Change-Id: Ib7104ef4d4f2282a2c9205b4b922e1678854d0a4
jenkins-bot [Tue, 22 Jul 2014 22:09:38 +0000 (22:09 +0000)]
Merge "Revert "maintenance: Update comment in the OOjs UI pull through script""
Roan Kattouw [Tue, 22 Jul 2014 21:59:46 +0000 (14:59 -0700)]
Update OOjs UI to v0.1.0-pre (
9cd400e3d5)
New changes:
6544476 Give MessageDialog actions 'action' properties
d10d0d9 Localisation updates from https://translatewiki.net.
91b11b4 Use native focus
f808d83 Add role attribute to a few widgets
8bd708b Special case for measuring clippableContainer == body
Change-Id: I56a21b2d652cc31748b369f26c0dc1cf5e0e81e2
Catrope [Tue, 22 Jul 2014 22:01:53 +0000 (22:01 +0000)]
Revert "maintenance: Update comment in the OOjs UI pull through script"
You can't put a comment in the middle of a command split
across multiple lines, it terminates the command.
This reverts commit
3cc4314faaf852417771a86380104bd68cc31b96.
Change-Id: If5889f84033366c62c4924511997b5e6a108cfab
withoutaname [Tue, 22 Jul 2014 21:07:03 +0000 (14:07 -0700)]
Shorten if/else to ternary expressions in WebStart.php
Change-Id: Ia12af16e1a6346fac169d5c2a2eee330050bd149
Translation updater bot [Tue, 22 Jul 2014 20:47:59 +0000 (22:47 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5e0139cfeee3143aa4926118cc89eef729f89e94
Kunal Mehta [Tue, 22 Jul 2014 20:36:55 +0000 (13:36 -0700)]
Fix documentation for UserMailer::send()
Change-Id: Ia1e793d96fa9d7c84c6b3c16090e7ffc13bf824a
jenkins-bot [Tue, 22 Jul 2014 20:25:02 +0000 (20:25 +0000)]
Merge "Remove two unused constants from EditPage.php"
Reedy [Tue, 22 Jul 2014 19:18:07 +0000 (20:18 +0100)]
Call to a member function getText() on a non-object
Bug: 68394
Change-Id: I78a9cd940fed9134263f086af89c15b5777b57fc
jenkins-bot [Tue, 22 Jul 2014 18:30:58 +0000 (18:30 +0000)]
Merge "Release notes for I050292dbb76821f66a15f937bf3aaf4defe67687"
jenkins-bot [Tue, 22 Jul 2014 18:11:40 +0000 (18:11 +0000)]
Merge "Make Special:Email an alias for Special:EmailUser"
Max Semenik [Tue, 22 Jul 2014 17:58:59 +0000 (10:58 -0700)]
Release notes for I050292dbb76821f66a15f937bf3aaf4defe67687
Change-Id: Ic1e4ffc2888c2381cfce13093af5120bea7c3354
jenkins-bot [Tue, 22 Jul 2014 17:56:52 +0000 (17:56 +0000)]
Merge "Change the default for wgThumbnailMinimumBucketDistance"
Gilles Dubuc [Tue, 22 Jul 2014 17:20:12 +0000 (13:20 -0400)]
Change the default for wgThumbnailMinimumBucketDistance
This has no effect while $wgThumbnailBuckets is null (the default),
but once buckets are enabled, 0 is a poor setting for the minimum
distance. 50 is arbitrary but definitely better than leaving it at 0.
Change-Id: I845af18cfd00627b26f6325c1d1a512a492a8f7c
jenkins-bot [Tue, 22 Jul 2014 16:58:07 +0000 (16:58 +0000)]
Merge "Fix race condition in wfShellExec()"
jenkins-bot [Tue, 22 Jul 2014 16:51:05 +0000 (16:51 +0000)]
Merge "Update jquery.ui Vector theme to 1.9.2"
jenkins-bot [Tue, 22 Jul 2014 16:40:40 +0000 (16:40 +0000)]
Merge "Wrapped the brackets of the collapse buttons with spans"
paladox [Tue, 15 Jul 2014 16:05:43 +0000 (16:05 +0000)]
Update jquery.ui Vector theme to 1.9.2
Follows-up
3cb2ccd87863abb8a99ed7d970730ae9e4138fcc.
Various structural changes were made in jQuery UI 1.9, and the Vector
theme was not updated to accommodate for those changes.
There have also been lots of small improvements to the base theme (which
is substituted inside the Vector theme) that were made over the past few
releases that weren't backported (such as Ib099282484b for bug 67243).
And there were two new modules in jQuery UI 1.9 (menu and spinner) that
were lacking Vector theme stylesheets.
Change-Id: I27accab309da063f4d7965a103951b152e77937d
jenkins-bot [Tue, 22 Jul 2014 15:55:38 +0000 (15:55 +0000)]
Merge "Preferences: Turn stubthreshold back into a combo box"
This, that and the other [Mon, 21 Jul 2014 07:38:39 +0000 (17:38 +1000)]
Preferences: Turn stubthreshold back into a combo box
Currently it's an insanely tall list box. All the other settings on this
page use combo boxes, so we should be consistent.
After it was changed from 'selectorother' to 'select' in I88212703
and support for 'size' in HTMLSelectField was enabled in I7ac345e1,
the size defines the height of the select box instead of the width of
the text input field.
Bug: 68313
Change-Id: Id42a62e78fc2fee741bb02b88dc14cbb1b63635a
Aaron Schulz [Tue, 15 Jul 2014 20:43:35 +0000 (13:43 -0700)]
Fixed JobQueueAggregatorRedis to handle empty collections
* Previously it would keep polling if the hash was empty since
empty and non-existing collections are the same in Redis.
* Also turned off the pointless PHP serialization.
* Bumped the cache version key; this change should be deployed
in all wikis at once, along with updating the runners.
Change-Id: I33dc55bc579bf678f14a5383e9e2c3c35231d599
jenkins-bot [Tue, 22 Jul 2014 15:06:15 +0000 (15:06 +0000)]
Merge "LessFileCompilationTest: Check $file during the test, not in constructor"
jenkins-bot [Tue, 22 Jul 2014 14:54:53 +0000 (14:54 +0000)]
Merge "Add tests for IE workarounds to ActionTest"
Bartosz Dziewoński [Tue, 22 Jul 2014 14:34:12 +0000 (16:34 +0200)]
LessFileCompilationTest: Check $file during the test, not in constructor
This will result in a neat little test failure instead of an
unreadable thirty-line traceback when the test fails.
Change-Id: Ie0b564a95586d72eb730ab8a70a6175eb3ae743d
jenkins-bot [Tue, 22 Jul 2014 14:26:47 +0000 (14:26 +0000)]
Merge "Add tests for NULL to ActionTest"
Hoo man [Tue, 22 Jul 2014 14:20:34 +0000 (14:20 +0000)]
Merge "Add tests for disabled actions in ActionTest"
This, that and the other [Mon, 21 Jul 2014 02:35:50 +0000 (12:35 +1000)]
No interlanguage links after local interwiki prefixes
This was noticed on enwiki after w: was marked as a local interwiki prefix
there. Links like [[w:de:Foo]] ought to act like [[:de:Foo]], not
[[de:Foo]].
Also adding a number of additional parser tests related to interwiki links.
Bug: 68085
Change-Id: If39af06edb4af2da85c9bcf43df7088181809fcf
Thiemo Mättig [Thu, 17 Jul 2014 08:14:29 +0000 (10:14 +0200)]
Add tests for IE workarounds to ActionTest
Change-Id: Iafaa3266e57f22f108c0253053103681bd88bd10
Thiemo Mättig [Thu, 17 Jul 2014 08:08:49 +0000 (10:08 +0200)]
Add tests for NULL to ActionTest
NULL should default to 'view'. But both the exists check and the
factory should fail when asked for a NULL action.
Change-Id: I5751489eed890bb44101f2a4ef73002bff68b207
Thiemo Mättig [Thu, 17 Jul 2014 07:42:19 +0000 (09:42 +0200)]
Add tests for disabled actions in ActionTest
Change-Id: I2c742fca0fa87604c1d503b938ecc495aafd8376
Thiemo Mättig [Thu, 17 Jul 2014 07:36:54 +0000 (09:36 +0200)]
Add more test cases to ActionTest
1. The 'dummy' test case already tested ucfirst(), but strtolower()
was not tested. The new 'DUMMY' tests fixes that.
2. Add a new test where the requested action is false.
3. Refactored the dummy builder a bit to make it easier to reuse.
Change-Id: Id7d9adac064b307b04bf6accb83ffd7f217a857c
Max Semenik [Fri, 18 Jul 2014 20:03:06 +0000 (13:03 -0700)]
Fix race condition in wfShellExec()
Especially when executing commands that return a relatively lot of data in stdout
quickly, proc_get_status() may return that command has terminated before everything
has been read from pipes. Handle this case by continuing to perform
non-blocking select on the process's streams until all remaining data has been
read.
Bug: 67870
Change-Id: I050292dbb76821f66a15f937bf3aaf4defe67687
withoutaname [Tue, 22 Jul 2014 00:50:47 +0000 (17:50 -0700)]
Remove two unused constants from EditPage.php
Specifically constants AS_USER_CANNOT_EDIT and AS_OK
Change-Id: I96b20962b7d4cab5c026a0f03abf9da066fbd9af
withoutaname [Sun, 13 Jul 2014 06:41:25 +0000 (23:41 -0700)]
Make if checks in RequestContext.php more concise
Change-Id: Ieb1eaeb595fc77ba926ba6ff96140dff44ba840f
Aaron Schulz [Mon, 21 Jul 2014 23:44:57 +0000 (16:44 -0700)]
Fixed column name typo
Change-Id: I30bc66c0fdd8c2f787b0796f7ecb00a6fea3a924
Leon Liesener [Mon, 21 Jul 2014 21:48:17 +0000 (23:48 +0200)]
Added me to credits
Added my name to CREDITS, as suggested by legoktm.
Change-Id: I9a197d345c74bb3fe274cf5eeb34b0716760e1c1
Leon Liesener [Sun, 20 Jul 2014 17:13:38 +0000 (19:13 +0200)]
Adjusted show/hide links
This change replaces checkboxes with show links for users
with the 'viewsuppressed' right assigned who cannot
hide/unhide suppressed revisions.
Change-Id: Id575b9830c84a17075ba6d10a5a305a38afd94e2
jenkins-bot [Mon, 21 Jul 2014 21:46:49 +0000 (21:46 +0000)]
Merge "maintenance/README: Remove importTextFile.php"
jenkins-bot [Mon, 21 Jul 2014 21:42:47 +0000 (21:42 +0000)]
Merge "Made ViewCountUpdate do the page table updates in auto-commit mode"
Kevin Israel [Mon, 21 Jul 2014 21:07:50 +0000 (17:07 -0400)]
maintenance/README: Remove importTextFile.php
Follows-up
14303bfea4fd.
Also corrected the capitalization of findHooks.php.
Change-Id: I6de35e368b8b091592b150a17cbce92b49c5ecf2
Marius Hoch [Mon, 21 Jul 2014 20:42:09 +0000 (22:42 +0200)]
Make sure $doUserRightsLogLike is set all the times
This fixes a PHP notice
Change-Id: I09b0b0c051b250b1e0a8e937948aaf2c48d17f7c
Bartosz Dziewoński [Sun, 20 Jul 2014 13:33:01 +0000 (15:33 +0200)]
Remove <div id="mw-js-message"> (again)
It has been previously removed in
d4d519c4, then accidentally readded
in
a96afeb2.
Change-Id: I23d228bf05ad8c632da38c4a194981044af6cc6b
umherirrender [Mon, 21 Jul 2014 19:38:56 +0000 (21:38 +0200)]
Docs: {function} -> callable
Change-Id: Iab0760ce5c518854a127330d3e0c0ee7ed0c526c
Translation updater bot [Mon, 21 Jul 2014 19:26:22 +0000 (21:26 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2dd8d41e3ea4e38a4afd4dd6f59ddab83cb81edd
umherirrender [Mon, 21 Jul 2014 19:19:41 +0000 (21:19 +0200)]
Add since to @deprecated in includes/site
Follow-Up: I08ffa6a97093abbe85169f664b97498c5f39bf8e
Change-Id: I6c3e607a4f095ca0dcd2f240c0c483b90c16c13d
Aaron Schulz [Thu, 6 Mar 2014 23:01:35 +0000 (15:01 -0800)]
Redo WhatLinksHere query and add a *_from_namespace field to link tables
* Also tweaked the query so MySQL avoids doing a page_name
index scan when it should start with the link table index
* Added population script (triggered by update.php)
* Also removed uniqueness from some indexes where it is redundant
* Renamed two confusing variables
Bug: 60618
Change-Id: Icca99b6ae0ef76cb77695faf82c615516191da36
umherirrender [Mon, 21 Jul 2014 18:58:14 +0000 (20:58 +0200)]
Fixed some @params documentation (includes/utils)
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Change-Id: I9bd4ef370016cbbcce42d2612031a264eb3de61b
jenkins-bot [Mon, 21 Jul 2014 18:47:16 +0000 (18:47 +0000)]
Merge "Remove deprecated RawPage class"
jenkins-bot [Mon, 21 Jul 2014 18:39:20 +0000 (18:39 +0000)]
Merge "Allow wildcard searching in wiki IDs for interwiki user rights logs"
jenkins-bot [Mon, 21 Jul 2014 18:30:09 +0000 (18:30 +0000)]
Merge "Stop using a suboptimal structure for Vector's variants menu"
jenkins-bot [Mon, 21 Jul 2014 18:24:36 +0000 (18:24 +0000)]
Merge "WebInstaller::setVarsFromRequest() do not trim passwords"
Bartosz Dziewoński [Mon, 9 Jun 2014 16:55:24 +0000 (18:55 +0200)]
Stop using a suboptimal structure for Vector's variants menu
One label is enough.
We need to keep the styles and some inline hacks in the HTML for a
while to keep current CSS compatible with old HTML, which is cached in
WMF environment for up to 30 days.
Follow-up to clean up the mess: I2817c6e9eb52ffc785a04bb9d23b0802a553fd45.
Bug: 43406
Change-Id: Idf43d77dccff83ad81db776f3262e0ef12d25c92
jenkins-bot [Mon, 21 Jul 2014 18:22:23 +0000 (18:22 +0000)]
Merge "Remove Fallback::iconv()"
jenkins-bot [Mon, 21 Jul 2014 18:20:49 +0000 (18:20 +0000)]
Merge "Remove old maintenance script importTextFile.php"
jenkins-bot [Mon, 21 Jul 2014 18:17:41 +0000 (18:17 +0000)]
Merge "Reformat function chains in FileTest.php"
jenkins-bot [Mon, 21 Jul 2014 17:53:44 +0000 (17:53 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (
5ab041a801)"
withoutaname [Sun, 20 Jul 2014 04:09:26 +0000 (21:09 -0700)]
Remove old maintenance script importTextFile.php
Functionality is largely redundant to edit.php script.
Change-Id: Idca2d0e3c38dc000618be9176072dd13757920b2
jenkins-bot [Mon, 21 Jul 2014 17:23:25 +0000 (17:23 +0000)]
Merge "Support for enabling skins in the installer"
James D. Forrester [Sat, 12 Jul 2014 22:32:26 +0000 (15:32 -0700)]
maintenance: Update comment in the OOjs UI pull through script
Follows-up I05967ab7.
Change-Id: Ibbdb77f720a22cd087e3a1d18d92748bb63069e4
jenkins-bot [Mon, 21 Jul 2014 16:53:43 +0000 (16:53 +0000)]
Merge "oojs update scripts: Use quotes to prevent globbing and word splitting"
jenkins-bot [Mon, 21 Jul 2014 14:48:49 +0000 (14:48 +0000)]
Merge "Always return bool in BackupReader::handleUpload"
jenkins-bot [Mon, 21 Jul 2014 14:47:35 +0000 (14:47 +0000)]
Merge "Leave table names with numbers untouched in DatabaseBase::generalizeSQL"
jenkins-bot [Mon, 21 Jul 2014 14:47:06 +0000 (14:47 +0000)]
Merge "Remove check for wikimedia-mode file, which no longer exists"
jenkins-bot [Mon, 21 Jul 2014 12:29:59 +0000 (12:29 +0000)]
Merge "For xcf files, compose layers before scaling"
umherirrender [Mon, 21 Jul 2014 09:32:34 +0000 (11:32 +0200)]
Always return bool in BackupReader::handleUpload
Change-Id: I476a1668b3a1ff9148ff335c9d7c9aa0c8ca3d11
withoutaname [Wed, 16 Jul 2014 08:49:05 +0000 (01:49 -0700)]
Remove deprecated Title::userCanRead()
Change-Id: I574babf4534c849d1e1491724ea537d53ea1d1d5
withoutaname [Thu, 17 Jul 2014 08:01:51 +0000 (01:01 -0700)]
Remove deprecated RawPage class
Change-Id: I7a75a09de934250604317983a4446ecaa9fa6550
jenkins-bot [Mon, 21 Jul 2014 05:05:50 +0000 (05:05 +0000)]
Merge "Collation: Workaround for incorrect collation of Estonian"
withoutaname [Thu, 17 Jul 2014 08:10:50 +0000 (01:10 -0700)]
Remove deprecated HistoryPage class
Change-Id: I3db4d5a1a2c574a73e2fcfe1fd1da49f3570e4b6
Luis Felipe Schenone [Mon, 21 Jul 2014 04:51:33 +0000 (12:51 +0800)]
Wrapped the brackets of the collapse buttons with spans
To make them accessible via CSS, similarly to what has been done with
the brackets of the edit buttons.
Change-Id: I6b961b5f11f81e6e8ef768ba43fe7f20b886051a
Kevin Israel [Mon, 2 Jun 2014 05:30:21 +0000 (01:30 -0400)]
Remove Fallback::iconv()
The iconv fallback is, for the most part, a remnant of PHP 4 support.
Though iconv was not enabled by default in PHP 4, it is in PHP 5. This
is the case even for Windows builds, which use GNU libiconv.
As for the major Linux distributions:
* Debian, CentOS, Ubuntu -> always enabled
* Fedora, Slackware -> .so in the same package, enabled by default
* Arch -> .so in the same package, disabled by default
* openSUSE -> separate package
Change-Id: Ie1112a5742646a0e1f951e188480c23851859320
Max Semenik [Fri, 18 Jul 2014 19:35:43 +0000 (12:35 -0700)]
Mark relevant tests with @group GlobalFunctions
Change-Id: I4133ad7e5e042a8c24d4836ae2bf9f1880a56e70
jenkins-bot [Sun, 20 Jul 2014 23:02:22 +0000 (23:02 +0000)]
Merge "jquery.accessKeyLabel: Add missing word in inline comment"
Timo Tijhof [Sun, 20 Jul 2014 22:18:32 +0000 (00:18 +0200)]
jquery.accessKeyLabel: Add missing word in inline comment
Follows-up
6a81b0e5.
Change-Id: I4558a224746b416feca2de7afa159aa90b5dfc33
jenkins-bot [Sun, 20 Jul 2014 22:08:49 +0000 (22:08 +0000)]
Merge "Revert "Adding a bit more documentation to mw.loader.using""
Krinkle [Sun, 20 Jul 2014 22:03:28 +0000 (22:03 +0000)]
Revert "Adding a bit more documentation to mw.loader.using"
This isn't relevant or specific to mw.loader.using. All of ResourceLoader
revolves around this idea. If two separate modules have a common
dependency, that's not loaded twice either. Whether they were passed to
loader.using(), loader.load(), or as dependencies, it doesn't matter.
The callback executes when the requires modules are ready. The
documentation never said it would load them on demand, so this bit of
supposed clarification only leads functions as noise in my opinion.
Perhaps we need to clarify elsewhere in the documentation for mw.loader
as a whole this concept, but not in this method in this way.
This reverts commit
657fab8d8388a475d850d84d8244da5e0ccfa8e7.
Change-Id: I30b3d6769f72aaab47c0b987bbb58898612206bd