saper [Sun, 8 Dec 2013 22:18:20 +0000 (23:18 +0100)]
Let BlockTest.php respect database constraints
This is an attempt to make BlockTest not to fail
with database referential constraints enabled
(from I326bb4a189bf881299b9fb678033a927b916efac)
Bug: 58191
Change-Id: I45c2d466f77d4d0aa25e880b5bb7d1120c39a561
Sergio Santoro [Wed, 8 Oct 2014 15:36:17 +0000 (17:36 +0200)]
Remove broken parameter 'table' in wgObjectCaches for CACHE_DB
$wgObjectCaches in DefaultSettings.php had the useless
parameter 'table' for CACHE_DB.
SqlBagOStuff actually uses 'tableName' parameter, it
already defaults to 'objectcache' so there's no need
to write it again.
Change-Id: I5fe6b7c5f4d46cc8642c42861bc7078b795f5fb1
Timo Tijhof [Wed, 15 Oct 2014 01:45:51 +0000 (03:45 +0200)]
RequestContextTest: Distinguish initial test from restored test
Follows-up
f31a046. In failure it's hard to see whether it's the
first or third group of assertions as they were carying the same
name.
Change-Id: I5891754342400155759e797337f8509d4eca39ec
paladox [Sat, 6 Sep 2014 12:54:30 +0000 (12:54 +0000)]
Upgrade jStorage to v0.4.12
Project site
* http://www.jstorage.info/ and https://github.com/andris9/jStorage/tree/v0.4.12
jquery.jStorage.js file
* https://github.com/andris9/jStorage/blob/v0.4.12/jstorage.js
Author and contact
* Andris Reinman and email andris.reinman@gmail.com
README
* https://github.com/andris9/jStorage/blob/v0.4.12/README.md
Upgrading from 0.4.10 to 0.4.12.
Change-Id: I62899c8a2a7b9b2ae5b0f4b6ec06ee24cb966806
James D. Forrester [Wed, 15 Oct 2014 00:40:32 +0000 (17:40 -0700)]
Update OOjs UI to v0.1.0-pre (
d74a46ca6a)
New changes:
d74a46c Introduce oo-ui-window-inner-overlay
Change-Id: I3f325f3c514d334179de46d0ea092b48f13b9dfd
Timo Tijhof [Tue, 14 Oct 2014 21:39:31 +0000 (23:39 +0200)]
jquery.badge: Swap non-breaking space character for regular space
Follows-up
d453f81f4e. PHP's native json_encode requires input
being a UTF-8 string. For some reason MediaWiki, Git or OS X is
not reading jquery.badge.css as UTF-8 for me.
https://bugs.php.net/bug.php?id=51947
Due to json_encode rejecting the entire value and returning null
instead, the jquery.badge stylesheet was absent. load.php:
mw.loader.implement("jquery.badge",function, {"css":[null]} );
Change-Id: I84d2017a976249f55bdb269d2b9762db941292fe
jenkins-bot [Tue, 14 Oct 2014 20:51:17 +0000 (20:51 +0000)]
Merge "Make enhanced recent changes and extended watchlist default"
Translation updater bot [Tue, 14 Oct 2014 20:41:15 +0000 (22:41 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6ca4e358ecc0d008ae5f323b445d272f1f721a0b
jenkins-bot [Tue, 14 Oct 2014 19:39:54 +0000 (19:39 +0000)]
Merge "Add LinkBatch to Special:TrackingCategories"
umherirrender [Sat, 11 Oct 2014 19:11:57 +0000 (21:11 +0200)]
Break long lines
Change-Id: I8d4e883058c21023273df88439cd145888833115
jenkins-bot [Tue, 14 Oct 2014 18:31:20 +0000 (18:31 +0000)]
Merge "Create tooltip for "Page information" link"
jenkins-bot [Tue, 14 Oct 2014 18:28:57 +0000 (18:28 +0000)]
Merge "Deprecate ORMTable::getFieldPrefix"
umherirrender [Sat, 11 Oct 2014 18:30:23 +0000 (20:30 +0200)]
Create tooltip for "Page information" link
Added an empty accesskey message for consistency
Change-Id: Ie57d63718990eb6974808550622c3899a2b18d8f
Thiemo Mättig [Mon, 6 Oct 2014 16:04:40 +0000 (18:04 +0200)]
Deprecate ORMTable::getFieldPrefix
Internal calls to this method show up in my XDebug profiling as
the second most called method (after array_key_exists). Called
10000 times. Sure, it's very cheap and clearly not a bottleneck.
But just not necesarry to have a method for that. The benefit of
having a method is to have a dynamic prefix that can change
depending on other things in an object. But I think this is not
a good idea for a prefix.
Since this is protected it is part of the contract of this class.
I already cleaned known subclasses. Should be @deprecated for
some time and can be removed later.
Change-Id: I46a0d7e072d0a69e9aef5f77e92044b62e3d0ce7
jenkins-bot [Tue, 14 Oct 2014 01:05:21 +0000 (01:05 +0000)]
Merge "Set default for unused variable in ApiFormatBase"
jenkins-bot [Tue, 14 Oct 2014 01:01:43 +0000 (01:01 +0000)]
Merge "Add mediawiki.userSuggest to Special:NewPages"
jenkins-bot [Tue, 14 Oct 2014 01:00:05 +0000 (01:00 +0000)]
Merge "Update MessagesEn.php::$preloadedMessages"
jenkins-bot [Tue, 14 Oct 2014 00:58:31 +0000 (00:58 +0000)]
Merge "Add mediawiki.userSuggest to Special:[Deleted]Contributions"
Marius Hoch [Tue, 14 Oct 2014 00:57:32 +0000 (02:57 +0200)]
Set default for unused variable in ApiFormatBase
So that it can be left out when calling.
Change-Id: I6137f5d57a12c0e52ad12b84428a82e8befae0c9
jenkins-bot [Tue, 14 Oct 2014 00:52:59 +0000 (00:52 +0000)]
Merge "Create tooltip for "create account" link"
Brad Jorsch [Wed, 17 Sep 2014 19:43:31 +0000 (15:43 -0400)]
API: Clean up and internationalize pretty-printed output
The syntax highlighting applied to the XML format is not all that great,
and applying it to other formats is just wrong. Instead of doing it
ourselves, let's just add a hook and let Extension:SyntaxHighlight_GeSHi
do it for us.
But for that to work, we have to add RL support to the pretty-printed
output, which means OutputPage. At the same time, lets internationalize
the header.
Bug: 65403
Change-Id: I04b1a3842abdf1fb360c54aa7164fc7cd2e50f4b
Brad Jorsch [Wed, 6 Aug 2014 08:56:53 +0000 (09:56 +0100)]
API: Add "batchcomplete" to simplified continuation result
With the query-continue style of continuation, it's easy for the client
to know when a batch of pages from the generator is complete. The
simplified continuation should support this too, and without requiring
the client to parse the "continue" result property.
Change-Id: Ie407e2e27c017e8813143859cc58674553bc641b
jenkins-bot [Mon, 13 Oct 2014 22:22:10 +0000 (22:22 +0000)]
Merge "API: Make jsonfm the default output format"
jenkins-bot [Mon, 13 Oct 2014 22:19:47 +0000 (22:19 +0000)]
Merge "API: HTMLize and internationalize the help, add Special:ApiHelp"
Brad Jorsch [Tue, 16 Sep 2014 20:45:09 +0000 (16:45 -0400)]
API: Make jsonfm the default output format
Now that action=help isn't requiring xmlfm for sane display, make jsonfm
the default.
Change-Id: I515c322f31243081ed1315a17befe9792237eeaa
Translation updater bot [Mon, 13 Oct 2014 19:23:03 +0000 (21:23 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I54fc400a4eb31d5701ce9b402a6595ea0ca3ae90
physikerwelt (Moritz Schubotz) [Mon, 13 Oct 2014 13:22:35 +0000 (15:22 +0200)]
Fix strict warning in FakeDatabasUpdater::setAppliedUpdates
Follows-up
ccd051bc44.
To be consistent with DatabaseUpdater::setAppliedUpdates
the second arg $updates is now optional.
Change-Id: Ida2adfe30099ea4c65f0c16fafc4eae6603fc93a
umherirrender [Fri, 10 Oct 2014 13:50:24 +0000 (15:50 +0200)]
Add mediawiki.userSuggest to Special:ListFiles
This gives a suggestion list when typing a username on that special page
Bug: 48240
Change-Id: I9960325f27eddb6ea0b3317b00996ccb91c51994
Prtksxna [Mon, 13 Oct 2014 04:42:46 +0000 (04:42 +0000)]
Merge "mediawiki.special.changeslist.legend: Match dt/dd line-height"
Translation updater bot [Sun, 12 Oct 2014 19:55:32 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6fc8199d579ccc94810b4c2d31a046aef8b804b2
Reedy [Sat, 11 Oct 2014 23:57:53 +0000 (00:57 +0100)]
Add 'name' back to wpLoginAttempt
Change-Id: I353ccb74e3572ab2e22a3803d0bc265be2ca2408
Kunal Mehta [Sat, 11 Oct 2014 23:41:51 +0000 (16:41 -0700)]
Fix session failure errors when trying to create an account
wpCreateaccount was no longer being passed in the POST request,
so the special page thought a login attempt was occurring rather
than an account creation attempt, so it checked against the wrong
token, resulting in session failure errors.
Bug: 71862
Change-Id: I9519cb264be9f587ef4354ba1fd03962a52755a2
Translation updater bot [Sat, 11 Oct 2014 20:02:13 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I386b19b8701f8826109919a1b5b3ebbb2a5c4977
umherirrender [Sat, 11 Oct 2014 17:56:14 +0000 (19:56 +0200)]
Update MessagesEn.php::$preloadedMessages
Some messages no longer exists, some were renamed.
Also added some messages which gets used for anons on page view.
Change-Id: Ia6cf0888b99d90c0810ce2afcffc95f2a9c66053
umherirrender [Sat, 11 Oct 2014 18:10:38 +0000 (20:10 +0200)]
Create tooltip for "create account" link
Added an empty accesskey message for consistency
Change-Id: I982f766cdcc8c172ebe4c12cf0f02ac641f5e5d5
jenkins-bot [Sat, 11 Oct 2014 17:23:21 +0000 (17:23 +0000)]
Merge "Revert "Make an empty "?action=" parameter default to "view"""
Brion VIBBER [Sat, 11 Oct 2014 17:15:49 +0000 (17:15 +0000)]
Revert "Make an empty "?action=" parameter default to "view""
Breaks all non-view actions on dev wikis, something's not right with the patch.
This reverts commit
a90b7ea969b4332a6229be1c4160190a3ec79200.
Change-Id: Ib9a5eb07ef48716df193fbb62a86c13e5c80dafd
umherirrender [Fri, 10 Oct 2014 14:07:32 +0000 (16:07 +0200)]
Add mediawiki.userSuggest to Special:[Deleted]Contributions
This gives a suggestion list when typing a username
Change-Id: I59ca64f21de3182adeb01fbea8dc13ebc0fc4367
Federico Leva [Mon, 7 Apr 2014 10:11:05 +0000 (12:11 +0200)]
Make enhanced recent changes and extended watchlist default
Wikimedia projects override submitted at I68ce04cd7 (
6eea7e4c9).
This previously submitted as I7c2a27b4d (
ffe3ca58582).
Bug: 35785
Change-Id: I0736f82ed8f74b7de64f2b1abdc6e5e12f2bf320
jenkins-bot [Sat, 11 Oct 2014 06:04:31 +0000 (06:04 +0000)]
Merge "MovePage: Properly return errors"
Kunal Mehta [Sat, 11 Oct 2014 01:39:24 +0000 (18:39 -0700)]
MovePage: Properly return errors
Probably a copy-paste mistake when converting this function
to use Status instead of error arrays.
Change-Id: I796fc66ee637dd7d914a4182fe56992e59b90aba
James D. Forrester [Sat, 11 Oct 2014 01:05:44 +0000 (18:05 -0700)]
Update OOjs UI to v0.1.0-pre (
837b2f733e)
New changes:
d40dd30 build: Update grunt-contrib-uglify to v0.6.0
0d89c99 test: Load a theme for the test HTML file so the tests don't fail
f245aa4 Element: Remove test for deprecated onDOMEvent()
cd15f18 Follow-up I730e3d7d: Tab not spaces
a923881 build: Use Karma instead of grunt-contrib-qunit
381864c build: Use Chrome and Firefox for tests instead of PhantomJS
044faa5 Follow-up If2da01a2: Fix grunt watch
d6e7af8 Adding OO.ui.TitledElement as mixin to label widget
6385af7 MediaWiki theme: Add filled white background to toolbars
837b2f7 Revert "Try to stop user from tabbing outside of open dialog box"
Change-Id: I63d51311f73d1295a2a35ebadf7d9ac835dec5c7
jenkins-bot [Sat, 11 Oct 2014 00:36:58 +0000 (00:36 +0000)]
Merge "Add test for canUseWikiPage special case to ActionTest"
jenkins-bot [Sat, 11 Oct 2014 00:36:10 +0000 (00:36 +0000)]
Merge "Make an empty "?action=" parameter default to "view""
Thiemo Mättig [Tue, 22 Jul 2014 12:28:12 +0000 (14:28 +0200)]
Add test for canUseWikiPage special case to ActionTest
Change-Id: I6b037d4aa9101a3a416cdf3bd1e26f14b056b4f7
jenkins-bot [Fri, 10 Oct 2014 21:34:23 +0000 (21:34 +0000)]
Merge "PrefixSearch: Enforce including the exact match as first result"
jenkins-bot [Fri, 10 Oct 2014 20:31:35 +0000 (20:31 +0000)]
Merge "API: Fix ApiQueryBacklinks redirlinks"
Thiemo Mättig [Thu, 17 Jul 2014 08:27:38 +0000 (10:27 +0200)]
Make an empty "?action=" parameter default to "view"
When no action is given, e.g. in
https://en.wikipedia.org/wiki/URL
the action defaults to "view". Just like you called
https://en.wikipedia.org/wiki/URL?action=view
But when the action is empty, e.g.
https://en.wikipedia.org/wiki/URL?action=
you get an error message telling you that "the action specified"
can not be "recognized". Wait. I did not "specified" an action.
That's why I left the parameter empty. It doesn't make much sense
to have an empty action name that's different from the "view"
default, right? From the users point of view I expect the empty
string to behave like null/undefined.
Change-Id: I331924d9223e597293bc8285f0c330edf08e429b
Translation updater bot [Fri, 10 Oct 2014 19:39:06 +0000 (21:39 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib6290d03982df0ef0249d4a7acfb2f8e36e2c9cb
Timo Tijhof [Wed, 17 Sep 2014 23:24:41 +0000 (16:24 -0700)]
PrefixSearch: Enforce including the exact match as first result
The default search backend implements proper prefix search and
does this naturally. But extensions providing search backends
like Lucene and CirrusSearch actually fail to implement proper
prefix searching and instead use their search engine ranking for
prefix search as well. Thus often the exact match is not on top
or is not even in the first 10 results at all.
On en.wikipedia.org:
> Example
1. "Example (musician)"
2. "Example"
3. "Example.com"
> John ive
1. "John Ives"
2. "John Ivey"
3. "John Ive"
> Foo
1. "Football (soccer)"
2. "Football League Cup"
3. "Foot (length)"
"Foo" exists but is NOT among the returned results.
Bug: 70958
Change-Id: I78d419424baf43d38beeb6dabfc347f430fa45f6
Brad Jorsch [Fri, 10 Oct 2014 19:22:35 +0000 (15:22 -0400)]
API: Fix ApiQueryBacklinks redirlinks
The fast case needs to pass the redirlinks subarray through array_values
and set an indexed tag name.
Bug: 71907
Change-Id: I865aad6485a2598c9e574ab5c38e8e0923d11ddd
umherirrender [Fri, 10 Oct 2014 19:16:29 +0000 (21:16 +0200)]
Add LinkBatch to Special:TrackingCategories
When building the table, each cat and message link results in a database
query. Avoid this by using a LinkBatch
Change-Id: If9e39a94c94b0c2e07822a3fa6cce3a22875d7cf
jenkins-bot [Fri, 10 Oct 2014 18:12:00 +0000 (18:12 +0000)]
Merge "Use config for $wgLanguageCode in OutputPage.php"
Fomafix [Sun, 5 Oct 2014 08:46:45 +0000 (08:46 +0000)]
Remove space from the begin and the end of the heading
Whitespaces between the opening tag <h1> and the content and
between the content and the closing tag </h1> gets converted to a space
when selecting the heading by a triple click and copying it to clipboard
See Ic9887a079734b28155f46ffaeedec02ff8ad81ca for skin Vector.
Change-Id: If90928b5f66dc10e3e8024e31d96be25462e446c
Stephan Gambke [Thu, 9 Oct 2014 13:56:31 +0000 (15:56 +0200)]
Add name of offensive hook function to error message
When a hook function is not callable an exception is thrown.
This patch adds the name of the offensive hook function to
the exception message to improve its informative value.
Change-Id: I376d7f5590099620a4c11ff9a4967d6d8f6560cc
Brad Jorsch [Tue, 16 Sep 2014 17:54:01 +0000 (13:54 -0400)]
API: HTMLize and internationalize the help, add Special:ApiHelp
The existing API help, formatted as basically a plain-text document
embedded in XML and with a little bolding and a few links
syntax-highlighted in after the fact, works ok for experienced programmers
but isn't at all newbie-friendly. Further, all the help is hard-coded in
English, which isn't very friendly to non-English speakers.
So let's rewrite it. The help text is now obtained from i18n messages
and output in HTML, with the default display consisting of help for a
single module with links to help for other modules. This, of course,
necessitates deprecating many of the existing help-related methods and
hooks and replacing them with new ones, but backwards compatibility is
maintained for almost everything.
At the same time, action=paraminfo also needs to support the
'description' and other help-related fields being output in wikitext or
HTML, and I11cb063d (to access all modules via the 'modules' parameter
instead of having 'modules', 'formatmodules', 'querymodules', and so on)
is folded in.
And we also add Special:ApiHelp. When directly accessed, it simply
redirects to api.php with appropriate parameters. But it's also
transcludable to allow up-to-date API help text to be included within
the on-wiki documentation.
Note this patch doesn't actually add i18n messages for any API modules
besides ApiMain and ApiHelp. That will come in a followup patch, but for
the moment the backwards-compatibility code handles them nicely.
While we're messing with the documentation, we may as well add the
"internal" flag requested in bug 62905 (although the 'includeinternal'
parameter it also requests doesn't make much sense anymore) and a
"deprecated" flag that's needed by several modules now.
Bug: 30936
Bug: 38126
Bug: 42343
Bug: 45641
Bug: 62905
Bug: 63211
Change-Id: Ib14c00df06d85c2f6364d83b2b10ce34c7f513cc
umherirrender [Fri, 10 Oct 2014 14:13:49 +0000 (16:13 +0200)]
Add mediawiki.userSuggest to Special:NewPages
This gives a suggestion list when typing a username
Change-Id: Ia3c8c99e5d78adbdc7ef8e7000ab454c8954ec46
umherirrender [Fri, 10 Oct 2014 13:37:58 +0000 (15:37 +0200)]
Set redirlinks indexed tag name on list=backlinks
Bug: 71907
Follow-Up: I32381c0f082d2f8e063af99ee353ae003c163c23
Change-Id: I4af6000c146e60cd6e3fbda42fcc7bef2952c4ba
umherirrender [Fri, 10 Oct 2014 12:58:03 +0000 (14:58 +0200)]
Use config for $wgLanguageCode in OutputPage.php
Follow-Up: I5e0ebc173631d1d1052de7ccee4ef839c7c1767f
Change-Id: Idd7fab9f8bf47fc303b5923327da67905e12e527
Aaron Schulz [Tue, 7 Oct 2014 21:15:57 +0000 (14:15 -0700)]
Made LocalFileMoveBatch::addOlds use SH locks instead of EX ones
Change-Id: I928f98deded6e71b4b1e63167ca8b565e39c6394
jenkins-bot [Thu, 9 Oct 2014 22:37:54 +0000 (22:37 +0000)]
Merge "Optimise checkboxes for Firefox mobile"
jenkins-bot [Thu, 9 Oct 2014 20:09:48 +0000 (20:09 +0000)]
Merge "Removed unused method"
Translation updater bot [Thu, 9 Oct 2014 18:55:10 +0000 (20:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1c73003833662553745e39f2b96484e391b1d182
jenkins-bot [Thu, 9 Oct 2014 18:42:50 +0000 (18:42 +0000)]
Merge "HTMLForm: Improve hidden field handling"
jenkins-bot [Thu, 9 Oct 2014 17:43:08 +0000 (17:43 +0000)]
Merge "OOUI: Switch Minerva skin from deprecated 'Minerva' theme to 'MediaWiki'"
Brad Jorsch [Thu, 9 Oct 2014 17:21:31 +0000 (13:21 -0400)]
HTMLForm: Improve hidden field handling
HTMLHiddenField is unable to output a non-default value, which makes it
unsuitable for actually persisting changes across multiple form
submissions. To preserve compatibility with forms that aren't expecting
persistence, fixing this requires a new parameter in the field
definition.
Also, due to the unusual way that hidden fields are added to the HTML
output, they are not being correctly handled by HTMLFormFieldCloner.
Special-case that.
Change-Id: I1fde7372401299b4432d28ac61982d47d5f3bbea
physikerwelt (Moritz Schubotz) [Sat, 20 Sep 2014 19:36:03 +0000 (12:36 -0700)]
Add counter to DatabaseUpdater::setAppliedUpdates
The key was constructed depending on the current time only.
This method fails, if multiple updates are performed
within one second.
Bug: 71087
Change-Id: Id7e30298729b3abb1501a34fcc1ba4e45d2172f0
jenkins-bot [Wed, 8 Oct 2014 23:26:42 +0000 (23:26 +0000)]
Merge "change [[Special:Block]] to destructive"
jenkins-bot [Wed, 8 Oct 2014 22:35:30 +0000 (22:35 +0000)]
Merge "Revert "buttons: Update focus state""
jenkins-bot [Wed, 8 Oct 2014 21:41:55 +0000 (21:41 +0000)]
Merge "Added a --type filter to showJobs.php"
jenkins-bot [Wed, 8 Oct 2014 21:40:32 +0000 (21:40 +0000)]
Merge "MediaWiki UI: Use em's for the button width"
Aaron Schulz [Wed, 8 Oct 2014 20:39:09 +0000 (13:39 -0700)]
Added a --type filter to showJobs.php
Change-Id: I43d2c9fb949d88364dd000e9892a60ac19412e31
Translation updater bot [Wed, 8 Oct 2014 18:55:44 +0000 (20:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4fce4df72f1585379212c1ff471cda0417212543
jdlrobson [Wed, 8 Oct 2014 18:20:57 +0000 (11:20 -0700)]
Optimise checkboxes for Firefox mobile
Bug: 71750
Change-Id: I19a6837423a2c9c9d3f758c7c6a869bd02c70460
Yuri Astrakhan [Wed, 8 Oct 2014 18:12:11 +0000 (14:12 -0400)]
Minor doc fix for wfShellExecWithStderr()
Change-Id: I9d5fe442c6e85d61c1cdec8c42caab06b37856b1
jenkins-bot [Wed, 8 Oct 2014 16:04:53 +0000 (16:04 +0000)]
Merge "Fix expires typo in comment"
Reedy [Wed, 8 Oct 2014 15:55:52 +0000 (16:55 +0100)]
Fix expires typo in comment
Change-Id: I4bb63f610ce0ec246c4aa7aef3d04f096fb3e564
Alex Monk [Wed, 8 Oct 2014 12:42:43 +0000 (13:42 +0100)]
Credits: Move Bartosz up from patch contributors to developers
Change-Id: I159325fa03a2c31d56ac14f06c09861aa488df84
Douglas Gardner [Tue, 7 Oct 2014 23:07:58 +0000 (00:07 +0100)]
change [[Special:Block]] to destructive
Bug: 66145
Change-Id: I1ae04e15ea8046d50a58952f627a3e7d8bd941a4
jdlrobson [Tue, 7 Oct 2014 22:40:03 +0000 (15:40 -0700)]
MediaWiki UI: Use em's for the button width
In mobile iOS this causes overlap of buttons with footer text
on our Wikigrok widget.
We use
em's to create a margin for the button but since the button is defined
in pixels when zooming out of the page this causes overlap.
Bug: 71577
Change-Id: I0332b925a3f09c7f924aa48bd636f7fb19743ff7
Jackmcbarn [Tue, 7 Oct 2014 22:31:42 +0000 (18:31 -0400)]
Fix fatal error in delayed parser tests
Change-Id: I93957bec3e33688b6cce6cb636ef685c8bae3b2f
dan-nl [Thu, 25 Sep 2014 04:46:37 +0000 (06:46 +0200)]
HttpTest: Update cURL constants array
The mediawiki-core-regression-hhvm-master test for I21747063 found
failures for some constants provided by the provideCurlConstants()
array.
https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-master/2072/console
I have commented out the failures that occur in the current mw
HHVM 3.3.0 environment in order for the test to pass. none of the
commented out constants appear in the mw core code.
PHP 5.6.0 removed several cURL constants http://php.net/manual/en/curl.constants.php.
I have commented out those constants and verified that they do not
exist in the mw core code.
Bug: 71729
Change-Id: I30c5e78eacf19071aaf44834ca188172f082e161
Translation updater bot [Tue, 7 Oct 2014 18:36:29 +0000 (20:36 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0ee5a6d4d1fa172ec0f99f183db933632432fa3f
jenkins-bot [Tue, 7 Oct 2014 17:52:49 +0000 (17:52 +0000)]
Merge "Deprecate OutputPage::rateLimited()"
jenkins-bot [Tue, 7 Oct 2014 17:52:46 +0000 (17:52 +0000)]
Merge "Deprecate OutputPage::readOnlyPage()"
jenkins-bot [Tue, 7 Oct 2014 14:08:07 +0000 (14:08 +0000)]
Merge "mediawiki.api: Remove check for callback in postWithToken"
jenkins-bot [Tue, 7 Oct 2014 12:41:08 +0000 (12:41 +0000)]
Merge "PrefixSearch: Add unit tests for StringPrefixSearch"
Fomafix [Mon, 6 Oct 2014 19:33:23 +0000 (19:33 +0000)]
mediawiki.api: Remove check for callback in postWithToken
Follows-up I0a650fdb4affd394ae419e21d54baf790116f6f7.
Change-Id: I178f68368cc1930e8b9f12afe5c6db7612235c40
Kevin Israel [Mon, 29 Sep 2014 04:01:30 +0000 (00:01 -0400)]
Deprecate OutputPage::rateLimited()
Change-Id: I140e6af9dde090b9f8611e7b53a650061f2e84eb
Kevin Israel [Mon, 29 Sep 2014 03:17:13 +0000 (23:17 -0400)]
Deprecate OutputPage::readOnlyPage()
Also, as this method is never called with an argument in any Gerrit-hosted
extension, shortened it to just `throw new ReadOnlyError;` on the assumption
that the removed portion was only left in for EditPage.
Change-Id: Icc2fc166b155eac548dfd5f3e67b0b1f92ef90d3
Matthew Flaschen [Tue, 7 Oct 2014 02:52:32 +0000 (22:52 -0400)]
MW UI: Show all permutations of checkboxes in Living Style Guide
* Regular unchecked
* Regular checked (added)
* Disabled unchecked
* Disabled checked
Although you can obviously check and uncheck it yourself, it's easier
for the user to show them the permutations on page load. Otherwise,
they might not even notice the special check mark image.
Also, fix a couple unrelated typos in buttons.less.
Change-Id: I17b63eeb424e23d1c3b9ce9ab8bfaa66b5bf4a46
jenkins-bot [Tue, 7 Oct 2014 06:57:49 +0000 (06:57 +0000)]
Merge "Updating style documentation for quiet anchors and quiet buttons"
jenkins-bot [Tue, 7 Oct 2014 06:49:20 +0000 (06:49 +0000)]
Merge "hash_equals(): Avoid division by zero when $known_string is empty"
kaldari [Tue, 7 Oct 2014 00:30:15 +0000 (17:30 -0700)]
Updating style documentation for quiet anchors and quiet buttons
See discussion on design-l for more context:
https://lists.wikimedia.org/pipermail/design/2014-October/002161.html
Change-Id: I1d958724d4222c95ad5ed52778d26228b09bd121
jenkins-bot [Tue, 7 Oct 2014 06:46:11 +0000 (06:46 +0000)]
Merge "UploadBaseTest: Use setMwGlobals() instead of juggling globals"
jenkins-bot [Tue, 7 Oct 2014 06:45:08 +0000 (06:45 +0000)]
Merge "MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity"
Kevin Israel [Tue, 24 Jun 2014 05:33:46 +0000 (01:33 -0400)]
hash_equals(): Avoid division by zero when $known_string is empty
Per Tim Starling's review of Icb239471, reverted back to the version of
the function from Patch Set 1 of Iece006ec, which did not have the bug.
This version does not attempt to minimize the inevitable leakage of the
string's length.
Also revised the doc comment to explain more effectively what the problem
with a normal (===) string comparison is for the use cases of this function.
Follows-up
b9e1d5f5c066.
Change-Id: I1b347e69b39af3d7d8ba6673af63f1a616befbdf
Tim Starling [Tue, 7 Oct 2014 05:24:45 +0000 (16:24 +1100)]
HashBagOStuff: use the value itself as the CAS token
Avoid an unnecessary serialize() call on get() requests, which makes it
faster and also happens to work around a nasty crash bug which is
causing lots of segfaults right now.
CAS semantics should be the same, if the caller handles a CAS token in
an opaque way and does not assume it is a string. I could only find one
caller of cas() in core and WMF deployed extensions, and that is
BagOStuff::mergeViaCas(), which does correctly handle CAS tokens of any
type.
Bug: 71724
Change-Id: I0b0b5f0157c005ec7f76210dfb8576c056314733
Timo Tijhof [Tue, 7 Oct 2014 03:22:02 +0000 (05:22 +0200)]
MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity
Follows-up
af66c04.
The tests depend indirectly on wgSecretKey (used by
MWCryptHKDF::generateHex). On test installs I tend to set this
to "example" or "***", which is less than 16 characters and thus
the unit tests failed with "MWCryptHKDF secret was too short".
Change-Id: I9a85fd9fbb345863e4837fed2910d60ebf1b0d83
Timo Tijhof [Tue, 7 Oct 2014 03:13:32 +0000 (05:13 +0200)]
UploadBaseTest: Use setMwGlobals() instead of juggling globals
Abstracts the logic for restoration into the built-in teardown()
handler.
Also purify the test configuration by setting wgHooks and
wgFileExtensions to otherwise empty arrays instead of extending
existing ones.
Change-Id: Ied65ee62f658dd650c603a54e72cd19965867a8f