Tim Starling [Tue, 20 Sep 2011 01:28:08 +0000 (01:28 +0000)]
Don't call Profiler::collateData() from ProfilerSimpleUDP, it destroys $this->mCollated which was filled by profileOut(), leading to a profile with only overhead entries. Call Profiler::close() instead, like what ProfilerSimpleText does.
Chad Horohoe [Mon, 19 Sep 2011 23:25:13 +0000 (23:25 +0000)]
Back-compat for $wgProfiler set as a class. Fix for r89206
Brion Vibber [Mon, 19 Sep 2011 23:14:52 +0000 (23:14 +0000)]
Add in a 'TestCanonicalRedirect' hook to be called when about to make a redirect to the canonical page form of a regular page view. Some extensions such as MobileProfile may need to modify this logic to prevent incorrect redirects, such as on alternate en.m.wikipedia.org domain, where we'd want to either skip it or rewrite to the alternate domain.
Support for resolving bug 31012.
Aaron Schulz [Mon, 19 Sep 2011 21:55:17 +0000 (21:55 +0000)]
Removed duplication in insertArticleLink
Brion Vibber [Mon, 19 Sep 2011 21:16:00 +0000 (21:16 +0000)]
* (bug 30977) Remove directions cruft, undo random limitation of input format for Special:Filepath
Reverts r43471 which forced Special:FilePath's input to not accept titles with the File: or Image: namespace on them, or otherwise requiring any normalization beyond space/underscore.
Also removes the extra line saying 'input the name without the file: prefix' which used the native namespace name, which prompted a question about its formatting in mixed-directionality contexts.
Sean Colombo [Mon, 19 Sep 2011 20:50:08 +0000 (20:50 +0000)]
Merged in change from Wikia which prevents an E_NOTICE on Special:FewestRevisions page.
Sam Reed [Mon, 19 Sep 2011 20:27:36 +0000 (20:27 +0000)]
Followup r97551, use isLocal, more dynamic!
Sam Reed [Mon, 19 Sep 2011 20:20:41 +0000 (20:20 +0000)]
Don't try and delete ForeignAPIFile or ForeignDBFile
Add a space before the error message so it's not cramped up next to the page name
Add a success error message (explicit is better than guessing)
Antoine Musso [Mon, 19 Sep 2011 20:08:27 +0000 (20:08 +0000)]
close <span> with </span> not </p>
follow up r97101
Brion Vibber [Mon, 19 Sep 2011 20:07:40 +0000 (20:07 +0000)]
Revert r97531 -- hook call added that uses undefined local variables, will spew E_NOTICE warnings when run.
Brion Vibber [Mon, 19 Sep 2011 20:00:49 +0000 (20:00 +0000)]
* (bug 31007) Fix regression in rebuildrecentchanges maintenance script
Was trying to save literal string 'NULL' into rc_old_len / rc_new_len fields due to a bug switching to database query builder methods in r77778.
Raimond Spekking [Mon, 19 Sep 2011 19:40:55 +0000 (19:40 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Mon, 19 Sep 2011 18:53:26 +0000 (18:53 +0000)]
Enable Server side searching on Doxygen
* (bug 31004) Class reference (Doxygen docs) should have a search
Sam Reed [Mon, 19 Sep 2011 18:46:57 +0000 (18:46 +0000)]
Simplify array( 'page_id IN (' . $dbw->makeList( $batch ) . ')' ), to array( 'page_id' => $batch ),
Alexandre Emsenhuber [Mon, 19 Sep 2011 18:38:38 +0000 (18:38 +0000)]
* Removed useless isset() check
* Added two spaces
Sean Colombo [Mon, 19 Sep 2011 18:36:35 +0000 (18:36 +0000)]
Merged in a fix from Wikia to make sure to call the ArticleDeleteComplete hook from deleteBatch (this is an existing hook that should be called on article deletion). Part of the diffs here: mediawiki.org/wiki/Wikia_code
Greg Sabino Mullane [Mon, 19 Sep 2011 18:28:35 +0000 (18:28 +0000)]
Put notes in host help about PostgreSQL via unix socket, as IP is not always enabled.
Sean Colombo [Mon, 19 Sep 2011 18:25:39 +0000 (18:25 +0000)]
Merged in a change which causes update.php to be gentler (tests slave-lag). Part of the many Wikia diffs: mediawiki.org/wiki/Wikia_code
Sam Reed [Mon, 19 Sep 2011 18:09:44 +0000 (18:09 +0000)]
Push r97515 into 1.18
Niklas Laxström [Mon, 19 Sep 2011 17:00:42 +0000 (17:00 +0000)]
* (bug 30846) New LanguageOs class
Niklas Laxström [Mon, 19 Sep 2011 14:21:05 +0000 (14:21 +0000)]
Converted patrol log to the new system
Sam Reed [Mon, 19 Sep 2011 13:47:15 +0000 (13:47 +0000)]
Fix assingment in conditionals
Remove unused globals/variables
Niklas Laxström [Mon, 19 Sep 2011 12:36:58 +0000 (12:36 +0000)]
My changes in r96548 were too radical, stripping of edit commits (oops!) and rollback links on some places.
Niklas Laxström [Mon, 19 Sep 2011 11:49:22 +0000 (11:49 +0000)]
Fixing bug 30973. Strip off subpages when determining the username who the current page belongs to.
Sam Reed [Mon, 19 Sep 2011 11:33:07 +0000 (11:33 +0000)]
Remove comment from r97469
Sam Reed [Mon, 19 Sep 2011 11:31:12 +0000 (11:31 +0000)]
Fix typo from r97461, was breaking unit tests
Niklas Laxström [Mon, 19 Sep 2011 11:21:59 +0000 (11:21 +0000)]
Committing another live hack for which I'm tired of getting conflicts.
Basically I'm overriding wfWikiID to run multiple instances on same database
but with different settings, and I don't want to them mess each others caches.
Niklas Laxström [Mon, 19 Sep 2011 11:05:10 +0000 (11:05 +0000)]
Committed a polished local hack I've been using.
At times useful to see if something is hogging much memory.
Didn't really want to add a new global for this.
Niklas Laxström [Mon, 19 Sep 2011 10:43:00 +0000 (10:43 +0000)]
* (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces
Niklas Laxström [Mon, 19 Sep 2011 09:04:39 +0000 (09:04 +0000)]
Partial solution for bug 30972 to avoid query flood.
There is still some, because the Parser doesn't use LinkBatch but does it own queries in LinkHolderArray - seriously WTF?
Raimond Spekking [Mon, 19 Sep 2011 06:24:06 +0000 (06:24 +0000)]
Fix per Krinkle's CR r97329: "There is and should be only one kind of #filetoc. Specifying a type here makes overriding it harder, no need to specify the tag name here"
Krinkle [Sun, 18 Sep 2011 23:21:46 +0000 (23:21 +0000)]
Minor whitespace fixes in GlobalFunctions.php
* And some adjustments to documentation (sentence ended with "use the wikis", adjusted to "use the wikis' content language")
[svnblameutil:] r97136,r88447,r86368,r81597,r72134,r2969
Platonides [Sun, 18 Sep 2011 20:36:35 +0000 (20:36 +0000)]
Restore ExifBitmapTest::tearDown removed in r97398
Raimond Spekking [Sun, 18 Sep 2011 19:42:47 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 18 Sep 2011 18:21:19 +0000 (18:21 +0000)]
Documentation
Fix whitespace
Set svn:eol-style native on Wikimania/README
Added 0.1 version number to Wikimania.php
Krinkle [Sun, 18 Sep 2011 17:48:58 +0000 (17:48 +0000)]
Modify 'image links' message used for the heading on the File-page showing entries in the mw_imagelinks table which contains pages that use/embed this file.
* Following the discussion on bug 30126. "File links" is confusing. Although developers will understand because of the table named 'imagelinks', other interfaces refer to this as 'usage' not a 'link'.
* Also updated message documentation
Krinkle [Sun, 18 Sep 2011 05:05:20 +0000 (05:05 +0000)]
Release-notes for bug 30843 / r97405 / r97406
Krinkle [Sun, 18 Sep 2011 05:03:03 +0000 (05:03 +0000)]
Fix lowercase test added in r97405
* (bug 30843) mediawiki.Title should not convert extensions (anything after the last full stop) to lower case
* Follows-up r97405
Krinkle [Sun, 18 Sep 2011 04:58:29 +0000 (04:58 +0000)]
Add extra unit test in Transformation for mediawiki.Title
* (bug 30843) mediawiki.Title should not convert extensions (anything after the last full stop) to lower case
* Patch my Michael M. slightly modified (moved to section "Transformation")
* Currently broken, will fix in next commit
Krinkle [Sun, 18 Sep 2011 04:50:47 +0000 (04:50 +0000)]
Move the mediawiki.test.bug30825.js helper script out of the /suites/ directory into /data/ and rename to be more re-usable.
(Follows-up r96680)
Brian Wolff [Sun, 18 Sep 2011 04:25:40 +0000 (04:25 +0000)]
(bug 18424) Clean up paging links on Special:allpages and special:prefixindex.
*Make them normal font size (my eyes! my eyes! with the tiny writing)
*Special:prefindex needs a paging link on the bottom like special:allpages (added a class name here, because I couldn't use the existing id on both)
*special:prefindex was doing $wgLang->pipeList( "full html table here", "next link here" ) which was giving bad output for the obvious reason.
Brian Wolff [Sun, 18 Sep 2011 03:32:43 +0000 (03:32 +0000)]
Make the phpunit old-style parserTest converter thingy not fall on its face if an extension registers a parserTests test file that has a period in it.
Brian Wolff [Sun, 18 Sep 2011 01:53:09 +0000 (01:53 +0000)]
Follow-up r92635 Make sure the Exif related tests handle not having the Exif extension available properly
This should fix issues reported in http://lists.wikimedia.org/pipermail/wikitech-l/2011-September/055212.html Lots of these tests loaded the exif extension dynamically, but then didn't reset $wgShowEXIF var properly.
Also change some of the markTestIncomplete to markTestSkipped as that seemed more correct.
Krinkle [Sat, 17 Sep 2011 20:21:40 +0000 (20:21 +0000)]
Revert r97386, way to soon. loader constructor has dependencies and assumptions about mw.log, mw.html and mw.messages
Krinkle [Sat, 17 Sep 2011 20:15:24 +0000 (20:15 +0000)]
[RL] Stand-alone ResourceLoader front-end
* In preparation of this, duplicating the entire file as-is in order to preserve svn history.
(Part of bug 30956)
Alexandre Emsenhuber [Sat, 17 Sep 2011 19:09:13 +0000 (19:09 +0000)]
Don't use isset() to check for null
Alexandre Emsenhuber [Sat, 17 Sep 2011 19:04:05 +0000 (19:04 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Krinkle [Sat, 17 Sep 2011 18:03:18 +0000 (18:03 +0000)]
Use Skin->getCategories() instead of Skin->getCategoryLinks() and manually wrapping the #catlinks element around it. This to use the centralized output control, no need to duplicate the IDs and class names here.
* Also removing the conditional addition of <br />, which is no longer needed since <div> is a block level element which downs;t need a line break to start on a new line (this <br />) hasn't been needed since it's an unordered list (r92054)
* Follows-up r92054 and it's CR
Krinkle [Sat, 17 Sep 2011 18:01:54 +0000 (18:01 +0000)]
Adding padding:0px to '.catlinks ul' (Follow-up r92054). Browsers sometimes have a default padding-left: 40px; which looks ugly if the <ul> is diplayed inline with a label in front of it. Before: i.imgur.com/JWJvp.png ; After: http://i.imgur.com/Vo1nN.png
Roan Kattouw [Sat, 17 Sep 2011 15:52:45 +0000 (15:52 +0000)]
Followup to r97150 per CR: use .children() instead of .find(), more efficient and prevents potential issues with nested tables.
Roan Kattouw [Sat, 17 Sep 2011 15:50:06 +0000 (15:50 +0000)]
Followup r95562: forgot to convert one case. Thanks to Nikerabbit for providing the line number
Sam Reed [Sat, 17 Sep 2011 11:49:10 +0000 (11:49 +0000)]
Revert r97257
Krinkle [Sat, 17 Sep 2011 02:42:34 +0000 (02:42 +0000)]
(bug 30940) Add a hook in User:getDefaultOptions.
Needs back porting to 1.18 in order to fix Gadgets in REL1_18
Krinkle [Sat, 17 Sep 2011 02:32:36 +0000 (02:32 +0000)]
[RL] pass 'media' property to <link> tags as well (in already did it for the <style> tags). Fixes debug-mode bug where print stylesheet were loaded in e.g. 'skins.modern'.
* (Follows-up r88053 c22683 CR)
* Whitespace fix in Resources.php
Sean Colombo [Fri, 16 Sep 2011 23:14:13 +0000 (23:14 +0000)]
Followup to r97342 to add docs for new hook.
Sam Reed [Fri, 16 Sep 2011 22:58:50 +0000 (22:58 +0000)]
Move 2 wikimedia specific files to WikimediaMaintenance
Sean Colombo [Fri, 16 Sep 2011 22:30:39 +0000 (22:30 +0000)]
Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here: mediawiki.org/wiki/Wikia_code
Sam Reed [Fri, 16 Sep 2011 21:54:35 +0000 (21:54 +0000)]
Fix another old constructor
Documentation
Sam Reed [Fri, 16 Sep 2011 21:50:30 +0000 (21:50 +0000)]
Code cleanup
Add README
Fix php4 style constructor in backup.inc
Raimond Spekking [Fri, 16 Sep 2011 20:51:04 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sean Colombo [Fri, 16 Sep 2011 20:31:37 +0000 (20:31 +0000)]
Additional register_globals vulnerability check. Merged in from big Wikia merge: mediawiki.org/wiki/Wikia_code
Raimond Spekking [Fri, 16 Sep 2011 20:27:09 +0000 (20:27 +0000)]
Remove the pseudo TOC, part of file descripton pages, from printing. Useless and confusing if a really TOC exists
Sam Reed [Fri, 16 Sep 2011 20:08:33 +0000 (20:08 +0000)]
Noticed in apache error logs (see below). If the length of the message is longer than the maximum length, only send what will fit
Sep 16 20:07:28 10.0.2.193 apache2[28441]: PHP Warning: socket_sendto() [<a href='function.socket-sendto'>function.socket-sendto</a>]: unable to write to socket [90]: Message too long in /home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464
Sep 16 20:07:29 10.0.2.193 apache2[26511]: PHP Warning: socket_sendto() [<a href='function.socket-sendto'>function.socket-sendto</a>]: unable to write to socket [90]: Message too long in /home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464
Alexandre Emsenhuber [Fri, 16 Sep 2011 19:39:53 +0000 (19:39 +0000)]
Removed useless check since the variable always exists and null would be catched by the second part
Alexandre Emsenhuber [Fri, 16 Sep 2011 19:35:14 +0000 (19:35 +0000)]
Call Linker methods statically
Sam Reed [Fri, 16 Sep 2011 19:03:47 +0000 (19:03 +0000)]
Fix extra brace
Alexandre Emsenhuber [Fri, 16 Sep 2011 18:50:13 +0000 (18:50 +0000)]
* Added HttpError exception as replacement for wfHttpError(); changed alls core calls to it except AjaxDispatcher.php
* Changed FeedUtils' call to it to be similar than feeds are completely disabled
* Use local context instead of global variables in Special:Userlogout
Sam Reed [Fri, 16 Sep 2011 18:28:24 +0000 (18:28 +0000)]
Refactor variables to give somewhat useful names
Sam Reed [Fri, 16 Sep 2011 18:25:02 +0000 (18:25 +0000)]
Add handling of format modules to ApiParamInfo
Sam Reed [Fri, 16 Sep 2011 18:11:47 +0000 (18:11 +0000)]
Give a list of modules to query and action into paraminfo
Sam Reed [Fri, 16 Sep 2011 17:58:50 +0000 (17:58 +0000)]
Moar documentations
Niklas Laxström [Fri, 16 Sep 2011 16:59:10 +0000 (16:59 +0000)]
Amend documentation for r97296
Sam Reed [Fri, 16 Sep 2011 16:55:39 +0000 (16:55 +0000)]
Revert r91561
Niklas Laxström [Fri, 16 Sep 2011 16:11:54 +0000 (16:11 +0000)]
* (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces
Chad Horohoe [Fri, 16 Sep 2011 15:21:06 +0000 (15:21 +0000)]
Don't attempt to get a request url from a FauxRequest
Sam Reed [Fri, 16 Sep 2011 13:32:40 +0000 (13:32 +0000)]
Followup r97264 move RELEASE-NOTES-1.19 to RELEASE-NOTES-1.18 from r97177 in trunk
Sam Reed [Fri, 16 Sep 2011 12:25:45 +0000 (12:25 +0000)]
* (bug 30927) Omission of MySQLField::maxLength
Sam Reed [Fri, 16 Sep 2011 11:35:56 +0000 (11:35 +0000)]
Fix indenting of a couple of braces
Rotem Liss [Fri, 16 Sep 2011 10:04:32 +0000 (10:04 +0000)]
Localization update for he.
Niklas Laxström [Fri, 16 Sep 2011 06:23:48 +0000 (06:23 +0000)]
Improve r97239 with comments from Aaron. Also fixed another typo that was lurking there.
Niklas Laxström [Fri, 16 Sep 2011 06:15:44 +0000 (06:15 +0000)]
* Fixed indentation
* Fixed assumption about message keys that was no longer true
* Ping r97207
* Clarified the part about null
Antoine Musso [Fri, 16 Sep 2011 06:13:57 +0000 (06:13 +0000)]
revert r97203
That code was not really meant to work :-D
Platonides [Thu, 15 Sep 2011 21:29:53 +0000 (21:29 +0000)]
Remove @param for argument removed in r97206.
Aaron Schulz [Thu, 15 Sep 2011 21:22:11 +0000 (21:22 +0000)]
RevisionDeleter::getChanges() documentation cleanup
Platonides [Thu, 15 Sep 2011 21:09:04 +0000 (21:09 +0000)]
Follow up r89706, building up on r97091.
I think this should fix the issues while
keeping bug 14404 solved.
We may need now a more advanced test than
ArticleTablesTest::testbug14404() thoigh.
Antoine Musso [Thu, 15 Sep 2011 20:57:43 +0000 (20:57 +0000)]
New hook RecentChangesListRecentChangesLine which let you customize an
entire recent changes line for user with 'Enhanced recent changes' option
It is equivalent to the existing hook OldChangesListRecentChangesLine
Reported by finlay on IRC.
Platonides [Thu, 15 Sep 2011 20:43:40 +0000 (20:43 +0000)]
buildMainQueryConds() (called by assertConditions) uses a wfGetDB( DB_SLAVE )
Although no data is transmitted to/from the server (create a DB_NONE?)
Aaron Schulz [Thu, 15 Sep 2011 19:36:12 +0000 (19:36 +0000)]
(bug 30903) Show diff size in contribution list. Works via batched query using rev_parent_id. This is the original change diff and won't the current "diff to previous rev according to rev_page,rev_timestamp" size for edge cases of selective undeletion (revdelete should be used instead anyway) or history merges.
Siebrand Mazeland [Thu, 15 Sep 2011 19:34:29 +0000 (19:34 +0000)]
Remove unused messages 'globalfileusage-of-file', 'globaltemplateusage-of-file' introduced in r95396.
Robin Pepermans [Thu, 15 Sep 2011 19:07:24 +0000 (19:07 +0000)]
Use wfSpecialList() so it displays properly when user direction != content direction, and call Linker function statically.
Siebrand Mazeland [Thu, 15 Sep 2011 18:14:14 +0000 (18:14 +0000)]
Follow-up r96979: one more message that needs to be worded consistenly.
Daniel Friesen [Thu, 15 Sep 2011 17:47:02 +0000 (17:47 +0000)]
Follow up r97179; Err... ;) you didn't see AutoLoader lines for half-finished code leak into my commit.
Daniel Friesen [Thu, 15 Sep 2011 17:42:17 +0000 (17:42 +0000)]
Separate RequestContext.php into separate files inside of context/
Update the AutoLoader too. This is also a follow up to r97161 since I forgot to add the AutoLoader line.
Ariel Glenn [Thu, 15 Sep 2011 17:18:13 +0000 (17:18 +0000)]
throw exception if rename of output file fails
Niklas Laxström [Thu, 15 Sep 2011 16:42:22 +0000 (16:42 +0000)]
* (bug 30817) Restored linktrail for kk (Kazakh)
Robin Pepermans [Thu, 15 Sep 2011 16:26:35 +0000 (16:26 +0000)]
Re-do reverted r96824, but in SpecialSearch first return if the title object is invalid.
Jeroen De Dauw [Thu, 15 Sep 2011 16:07:40 +0000 (16:07 +0000)]
Follow up to r97128;
Alexandre Emsenhuber [Thu, 15 Sep 2011 15:55:13 +0000 (15:55 +0000)]
* Factorise calls to get the User object
* Call Linker method statically
Daniel Friesen [Thu, 15 Sep 2011 15:47:15 +0000 (15:47 +0000)]
Implement DerivativeContext. Can be used to inherit context from another context while overriding only parts of the context.
Roan Kattouw [Thu, 15 Sep 2011 15:40:40 +0000 (15:40 +0000)]
Followup r93247: add apiScript as a property of a ResourceLoader source.