From: Shinjiman <shinjiman@users.mediawiki.org>
Date: Mon, 27 Apr 2009 13:00:40 +0000 (+0000)
Subject: * (bug 18593) Unify svn-revision references in Special:Version
X-Git-Tag: 1.31.0-rc.0~41973
X-Git-Url: http://git.cyclocoop.org//%27http:/jquery.khurshid.com/ifixpng.php/%27?a=commitdiff_plain;h=e30e8eb07cc3d11a011efd3e380233e9ccfe48ea;p=lhc%2Fweb%2Fwiklou.git

* (bug 18593) Unify svn-revision references in Special:Version
---

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 74b6c3c5db..228b2e42f8 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -115,7 +115,7 @@ class SpecialVersion extends SpecialPage {
 		global $wgVersion, $IP;
 		wfProfileIn( __METHOD__ );
 		$svn = self::getSvnRevision( $IP, false );
-		$version = $svn ? "$wgVersion (r$svn)" : $wgVersion;
+		$version = $svn ? $wgVersion . wfMsg( 'version-svn-revision', $svn ) : $wgVersion;
 		wfProfileOut( __METHOD__ );
 		return $version;
 	}
@@ -131,7 +131,7 @@ class SpecialVersion extends SpecialPage {
 		wfProfileIn( __METHOD__ );
 		$svn = self::getSvnRevision( $IP, false );
 		$viewvc = 'http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/?pathrev=';
-		$version = $svn ? "$wgVersion ([{$viewvc}{$svn} r$svn])" : $wgVersion;
+		$version = $svn ? $wgVersion . " [{$viewvc}{$svn} " . wfMsg( 'version-svn-revision', $svn ) . ']' : $wgVersion;
 		wfProfileOut( __METHOD__ );
 		return $version;
 	}
@@ -221,9 +221,10 @@ class SpecialVersion extends SpecialPage {
 	}
 
 	function formatCredits( $name, $version = null, $subVersion = null, $author = null, $url = null, $description = null, $descriptionMsg = null ) {
+		$viewvc = 'http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/?pathrev=';
 		$extension = isset( $url ) ? "[$url $name]" : $name;
 		$version = isset( $version ) ? wfMsg( 'version-version', $version ) : '';
-		$subVersion = isset( $subVersion ) ? wfMsg( 'version-svn-revision', $subVersion ) : '';
+		$subVersion = isset( $subVersion ) ? " [{$viewvc}{$subVersion} " . wfMsg( 'version-svn-revision', $subVersion ) . ']' : '';
 
 		# Look for a localized description
 		if( isset( $descriptionMsg ) ) {