Merge "Reject usernames with # as user-type API parameters"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 18 Apr 2016 15:16:58 +0000 (15:16 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 18 Apr 2016 15:16:58 +0000 (15:16 +0000)
includes/api/ApiBase.php

index 1c20229..da64c03 100644 (file)
@@ -1298,7 +1298,7 @@ abstract class ApiBase extends ContextSource {
         */
        private function validateUser( $value, $encParamName ) {
                $title = Title::makeTitleSafe( NS_USER, $value );
-               if ( $title === null ) {
+               if ( $title === null || $title->hasFragment() ) {
                        $this->dieUsage(
                                "Invalid value '$value' for user parameter $encParamName",
                                "baduser_{$encParamName}"