Fix "externalCluster" LBFactorySimple setting in LBFactoryMW

Fixes regression from d175b391ae2a

Change-Id: I4bbc875e2fcd021e342959a37475ec356cb58cce

diff --git a/includes/db/loadbalancer/LBFactoryMW.php b/includes/db/loadbalancer/LBFactoryMW.php
index e943a8a..f8647a3 100644 (file)
--- a/includes/db/loadbalancer/LBFactoryMW.php
+++ b/includes/db/loadbalancer/LBFactoryMW.php
@@ -94,8 +94,8 @@ abstract class LBFactoryMW {
                                }
                                $lbConf['servers'] = [ $server ];
                        }
-                       if ( !isset( $lbConf['externalServers'] ) ) {
-                               $lbConf['externalServers'] = $mainConfig->get( 'ExternalServers' );
+                       if ( !isset( $lbConf['externalClusters'] ) ) {
+                               $lbConf['externalClusters'] = $mainConfig->get( 'ExternalServers' );
                        }
                } elseif ( $lbConf['class'] === 'LBFactoryMulti' ) {
                        if ( isset( $lbConf['serverTemplate'] ) ) {

diff --git a/includes/libs/rdbms/lbfactory/LBFactorySimple.php b/includes/libs/rdbms/lbfactory/LBFactorySimple.php
index 0476cf2..0949092 100644 (file)
--- a/includes/libs/rdbms/lbfactory/LBFactorySimple.php
+++ b/includes/libs/rdbms/lbfactory/LBFactorySimple.php
@@ -87,7 +87,7 @@ class LBFactorySimple extends LBFactory {
         */
        protected function newExternalLB( $cluster, $domain = false ) {
                if ( !isset( $this->externalClusters[$cluster] ) ) {
-                       throw new InvalidArgumentException( __METHOD__ . ": Unknown cluster \"$cluster\"" );
+                       throw new InvalidArgumentException( __METHOD__ . ": Unknown cluster \"$cluster\"." );
                }
 
                return $this->newLoadBalancer( $this->externalClusters[$cluster] );