Merge "Use classes to apply the 'editfont' preference"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 28 Sep 2016 20:03:38 +0000 (20:03 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 28 Sep 2016 20:03:38 +0000 (20:03 +0000)
1  2 
includes/EditPage.php
resources/src/mediawiki.legacy/shared.css

diff --combined includes/EditPage.php
@@@ -21,7 -21,6 +21,7 @@@
   */
  
  use MediaWiki\Logger\LoggerFactory;
 +use MediaWiki\MediaWikiServices;
  
  /**
   * The edit page/HTML interface (split from Article)
@@@ -563,29 -562,16 +563,29 @@@ class EditPage 
  
                $revision = $this->mArticle->getRevisionFetched();
                // Disallow editing revisions with content models different from the current one
 -              if ( $revision && $revision->getContentModel() !== $this->contentModel ) {
 -                      $this->displayViewSourcePage(
 -                              $this->getContentObject(),
 -                              wfMessage(
 -                                      'contentmodelediterror',
 -                                      $revision->getContentModel(),
 -                                      $this->contentModel
 -                              )->plain()
 -                      );
 -                      return;
 +              // Undo edits being an exception in order to allow reverting content model changes.
 +              if ( $revision
 +                      && $revision->getContentModel() !== $this->contentModel
 +              ) {
 +                      $prevRev = null;
 +                      if ( $this->undidRev ) {
 +                              $undidRevObj = Revision::newFromId( $this->undidRev );
 +                              $prevRev = $undidRevObj ? $undidRevObj->getPrevious() : null;
 +                      }
 +                      if ( !$this->undidRev
 +                              || !$prevRev
 +                              || $prevRev->getContentModel() !== $this->contentModel
 +                      ) {
 +                              $this->displayViewSourcePage(
 +                                      $this->getContentObject(),
 +                                      $this->context->msg(
 +                                              'contentmodelediterror',
 +                                              $revision->getContentModel(),
 +                                              $this->contentModel
 +                                      )->plain()
 +                              );
 +                              return;
 +                      }
                }
  
                $this->isConflict = false;
                Hooks::run( 'EditPage::showReadOnlyForm:initial', [ $this, &$wgOut ] );
  
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
 -              $wgOut->setPageTitle( wfMessage(
 +              $wgOut->setPageTitle( $this->context->msg(
                        'viewsource-title',
                        $this->getContextTitle()->getPrefixedText()
                ) );
                $this->showTextbox( $text, 'wpTextbox1', [ 'readonly' ] );
                $wgOut->addHTML( $this->editFormTextAfterContent );
  
 -              $wgOut->addHTML( Html::rawElement( 'div', [ 'class' => 'templatesUsed' ],
 -                      Linker::formatTemplates( $this->getTemplates() ) ) );
 +              $wgOut->addHTML( $this->makeTemplatesOnThisPageList( $this->getTemplates() ) );
  
                $wgOut->addModules( 'mediawiki.action.edit.collapsibleFooter' );
  
                // May be overridden by revision.
                $this->contentFormat = $request->getText( 'format', $this->contentFormat );
  
 -              if ( !ContentHandler::getForModelID( $this->contentModel )
 -                      ->isSupportedFormat( $this->contentFormat )
 -              ) {
 +              try {
 +                      $handler = ContentHandler::getForModelID( $this->contentModel );
 +              } catch ( MWUnknownContentModelException $e ) {
 +                      throw new ErrorPageError(
 +                              'editpage-invalidcontentmodel-title',
 +                              'editpage-invalidcontentmodel-text',
 +                              [ $this->contentModel ]
 +                      );
 +              }
 +
 +              if ( !$handler->isSupportedFormat( $this->contentFormat ) ) {
                        throw new ErrorPageError(
                                'editpage-notsupportedcontentformat-title',
                                'editpage-notsupportedcontentformat-text',
                                                        $oldContent = $this->page->getContent( Revision::RAW );
                                                        $popts = ParserOptions::newFromUserAndLang( $wgUser, $wgContLang );
                                                        $newContent = $content->preSaveTransform( $this->mTitle, $wgUser, $popts );
 +                                                      if ( $newContent->getModel() !== $oldContent->getModel() ) {
 +                                                              // The undo may change content
 +                                                              // model if its reverting the top
 +                                                              // edit. This can result in
 +                                                              // mismatched content model/format.
 +                                                              $this->contentModel = $newContent->getModel();
 +                                                              $this->contentFormat = $oldrev->getContentFormat();
 +                                                      }
  
                                                        if ( $newContent->equals( $oldContent ) ) {
                                                                # Tell the user that the undo results in no change,
                                                                if ( $firstrev && $firstrev->getId() == $undo ) {
                                                                        $userText = $undorev->getUserText();
                                                                        if ( $userText === '' ) {
 -                                                                              $undoSummary = wfMessage(
 +                                                                              $undoSummary = $this->context->msg(
                                                                                        'undo-summary-username-hidden',
                                                                                        $undo
                                                                                )->inContentLanguage()->text();
                                                                        } else {
 -                                                                              $undoSummary = wfMessage(
 +                                                                              $undoSummary = $this->context->msg(
                                                                                        'undo-summary',
                                                                                        $undo,
                                                                                        $userText
                                                                        if ( $this->summary === '' ) {
                                                                                $this->summary = $undoSummary;
                                                                        } else {
 -                                                                              $this->summary = $undoSummary . wfMessage( 'colon-separator' )
 +                                                                              $this->summary = $undoSummary . $this->context->msg( 'colon-separator' )
                                                                                        ->inContentLanguage()->text() . $this->summary;
                                                                        }
                                                                        $this->undidRev = $undo;
                                        // Messages: undo-success, undo-failure, undo-norev, undo-nochange
                                        $class = ( $undoMsg == 'success' ? '' : 'error ' ) . "mw-undo-{$undoMsg}";
                                        $this->editFormPageTop .= $wgOut->parse( "<div class=\"{$class}\">" .
 -                                              wfMessage( 'undo-' . $undoMsg )->plain() . '</div>', true, /* interface */true );
 +                                              $this->context->msg( 'undo-' . $undoMsg )->plain() . '</div>', true, /* interface */true );
                                }
  
                                if ( $content === false ) {
                        $handler = ContentHandler::getForModelID( $this->contentModel );
  
                        return $handler->makeEmptyContent();
 -              } else {
 +              } elseif ( !$this->undidRev ) {
                        // Content models should always be the same since we error
 -                      // out if they are different before this point.
 +                      // out if they are different before this point (in ->edit()).
 +                      // The exception being, during an undo, the current revision might
 +                      // differ from the prior revision.
                        $logger = LoggerFactory::getInstance( 'editpage' );
                        if ( $this->contentModel !== $rev->getContentModel() ) {
                                $logger->warning( "Overriding content model from current edit {prev} to {new}", [
                                ] );
                                $this->contentFormat = $rev->getContentFormat();
                        }
 -
 -                      return $content;
                }
 +              return $content;
        }
  
        /**
                        // passed.
                        if ( $this->summary === '' ) {
                                $cleanSectionTitle = $wgParser->stripSectionName( $this->sectiontitle );
 -                              return wfMessage( 'newsectionsummary' )
 +                              return $this->context->msg( 'newsectionsummary' )
                                        ->rawParams( $cleanSectionTitle )->inContentLanguage()->text();
                        }
                } elseif ( $this->summary !== '' ) {
                        # This is a new section, so create a link to the new section
                        # in the revision summary.
                        $cleanSummary = $wgParser->stripSectionName( $this->summary );
 -                      return wfMessage( 'newsectionsummary' )
 +                      return $this->context->msg( 'newsectionsummary' )
                                ->rawParams( $cleanSummary )->inContentLanguage()->text();
                }
                return $this->summary;
                        } elseif ( !$wgUser->isAllowed( 'editcontentmodel' ) ) {
                                $status->setResult( false, self::AS_NO_CHANGE_CONTENT_MODEL );
                                return $status;
 -
                        }
 +                      // Make sure the user can edit the page under the new content model too
 +                      $titleWithNewContentModel = clone $this->mTitle;
 +                      $titleWithNewContentModel->setContentModel( $this->contentModel );
 +                      if ( !$titleWithNewContentModel->userCan( 'editcontentmodel', $wgUser )
 +                              || !$titleWithNewContentModel->userCan( 'edit', $wgUser )
 +                      ) {
 +                              $status->setResult( false, self::AS_NO_CHANGE_CONTENT_MODEL );
 +                              return $status;
 +                      }
 +
                        $changingContentModel = true;
                        $oldContentModel = $this->mTitle->getContentModel();
                }
                if ( $displayTitle === false ) {
                        $displayTitle = $contextTitle->getPrefixedText();
                }
 -              $wgOut->setPageTitle( wfMessage( $msg, $displayTitle ) );
 +              $wgOut->setPageTitle( $this->context->msg( $msg, $displayTitle ) );
                # Transmit the name of the message to JavaScript for live preview
                # Keep Resources.php/mediawiki.action.edit.preview in sync with the possible keys
                $wgOut->addJsConfigVars( [
                # Try to add a custom edit intro, or use the standard one if this is not possible.
                if ( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
                        $helpLink = wfExpandUrl( Skin::makeInternalOrExternalUrl(
 -                              wfMessage( 'helppage' )->inContentLanguage()->text()
 +                              $this->context->msg( 'helppage' )->inContentLanguage()->text()
                        ) );
                        if ( $wgUser->isLoggedIn() ) {
                                $wgOut->wrapWikiMsg(
                        . Html::rawElement(
                                'label',
                                [ 'for' => 'wpAntispam' ],
 -                              wfMessage( 'simpleantispam-label' )->parse()
 +                              $this->context->msg( 'simpleantispam-label' )->parse()
                        )
                        . Xml::element(
                                'input',
                                : 'confirmrecreate';
                        $wgOut->addHTML(
                                '<div class="mw-confirm-recreate">' .
 -                                      wfMessage( $key, $username, "<nowiki>$comment</nowiki>" )->parse() .
 -                              Xml::checkLabel( wfMessage( 'recreate' )->text(), 'wpRecreate', 'wpRecreate', false,
 +                                      $this->context->msg( $key, $username, "<nowiki>$comment</nowiki>" )->parse() .
 +                              Xml::checkLabel( $this->context->msg( 'recreate' )->text(), 'wpRecreate', 'wpRecreate', false,
                                        [ 'title' => Linker::titleAttrib( 'recreate' ), 'tabindex' => 1, 'id' => 'wpRecreate' ]
                                ) .
                                '</div>'
  
                $wgOut->addHTML( $this->editFormTextAfterTools . "\n" );
  
 -              $wgOut->addHTML( Html::rawElement( 'div', [ 'class' => 'templatesUsed' ],
 -                      Linker::formatTemplates( $this->getTemplates(), $this->preview, $this->section != '' ) ) );
 +              $wgOut->addHTML( $this->makeTemplatesOnThisPageList( $this->getTemplates() ) );
  
                $wgOut->addHTML( Html::rawElement( 'div', [ 'class' => 'hiddencats' ],
                        Linker::formatHiddenCategories( $this->page->getHiddenCategories() ) ) );
                                $this->showConflict();
                        } catch ( MWContentSerializationException $ex ) {
                                // this can't really happen, but be nice if it does.
 -                              $msg = wfMessage(
 +                              $msg = $this->context->msg(
                                        'content-failed-to-parse',
                                        $this->contentModel,
                                        $this->contentFormat,
  
        }
  
 +      /**
 +       * Wrapper around TemplatesOnThisPageFormatter to make
 +       * a "templates on this page" list.
 +       *
 +       * @param Title[] $templates
 +       * @return string HTML
 +       */
 +      protected function makeTemplatesOnThisPageList( array $templates ) {
 +              $templateListFormatter = new TemplatesOnThisPageFormatter(
 +                      $this->context, MediaWikiServices::getInstance()->getLinkRenderer()
 +              );
 +
 +              // preview if preview, else section if section, else false
 +              $type = false;
 +              if ( $this->preview ) {
 +                      $type = 'preview';
 +              } elseif ( $this->section != '' ) {
 +                      $type = 'section';
 +              }
 +
 +              return Html::rawElement( 'div', [ 'class' => 'templatesUsed' ],
 +                      $templateListFormatter->format( $templates, $type )
 +              );
 +
 +      }
 +
        /**
         * Extract the section title from current section text, if any.
         *
                if ( count( $editNotices ) ) {
                        $wgOut->addHTML( implode( "\n", $editNotices ) );
                } else {
 -                      $msg = wfMessage( 'editnotice-notext' );
 +                      $msg = $this->context->msg( 'editnotice-notext' );
                        if ( !$msg->isDisabled() ) {
                                $wgOut->addHTML(
                                        '<div class="mw-editnotice-notext">'
                                ]
                        );
                } else {
 -                      if ( !wfMessage( 'longpage-hint' )->isDisabled() ) {
 +                      if ( !$this->context->msg( 'longpage-hint' )->isDisabled() ) {
                                $wgOut->wrapWikiMsg( "<div id='mw-edit-longpage-hint'>\n$1\n</div>",
                                        [
                                                'longpage-hint',
         * subclasses may reorganize the form.
         * Note that you do not need to worry about the label's for=, it will be
         * inferred by the id given to the input. You can remove them both by
 -       * passing array( 'id' => false ) to $userInputAttrs.
 +       * passing [ 'id' => false ] to $userInputAttrs.
         *
         * @param string $summary The value of the summary input
         * @param string $labelText The html to place inside the label
         * @param array $inputAttrs Array of attrs to use on the input
         * @param array $spanLabelAttrs Array of attrs to use on the span inside the label
         *
 -       * @return array An array in the format array( $label, $input )
 +       * @return array An array in the format [ $label, $input ]
         */
        function getSummaryInput( $summary = "", $labelText = null,
                $inputAttrs = null, $spanLabelAttrs = null
                                return;
                        }
                }
 -              $labelText = wfMessage( $isSubjectPreview ? 'subject' : 'summary' )->parse();
 +              $labelText = $this->context->msg( $isSubjectPreview ? 'subject' : 'summary' )->parse();
                list( $label, $input ) = $this->getSummaryInput(
                        $summary,
                        $labelText,
                global $wgParser;
  
                if ( $isSubjectPreview ) {
 -                      $summary = wfMessage( 'newsectionsummary' )->rawParams( $wgParser->stripSectionName( $summary ) )
 +                      $summary = $this->context->msg( 'newsectionsummary' )
 +                              ->rawParams( $wgParser->stripSectionName( $summary ) )
                                ->inContentLanguage()->text();
                }
  
                $message = $isSubjectPreview ? 'subject-preview' : 'summary-preview';
  
 -              $summary = wfMessage( $message )->parse()
 +              $summary = $this->context->msg( $message )->parse()
                        . Linker::commentBlock( $summary, $this->mTitle, $isSubjectPreview );
                return Xml::tags( 'div', [ 'class' => 'mw-summary-preview' ], $summary );
        }
                        'id' => $name,
                        'cols' => $wgUser->getIntOption( 'cols' ),
                        'rows' => $wgUser->getIntOption( 'rows' ),
+                       // The following classes can be used here:
+                       // * mw-editfont-default
+                       // * mw-editfont-monospace
+                       // * mw-editfont-sans-serif
+                       // * mw-editfont-serif
+                       'class' => 'mw-editfont-' . $wgUser->getOption( 'editfont' ),
                        // Avoid PHP notices when appending preferences
                        // (appending allows customAttribs['style'] to still work).
                        'style' => ''
                        try {
                                $this->showDiff();
                        } catch ( MWContentSerializationException $ex ) {
 -                              $msg = wfMessage(
 +                              $msg = $this->context->msg(
                                        'content-failed-to-parse',
                                        $this->contentModel,
                                        $this->contentFormat,
                }
  
                if ( ( $oldContent && !$oldContent->isEmpty() ) || ( $newContent && !$newContent->isEmpty() ) ) {
 -                      $oldtitle = wfMessage( $oldtitlemsg )->parse();
 -                      $newtitle = wfMessage( 'yourtext' )->parse();
 +                      $oldtitle = $this->context->msg( $oldtitlemsg )->parse();
 +                      $newtitle = $this->context->msg( 'yourtext' )->parse();
  
                        if ( !$oldContent ) {
                                $oldContent = $newContent->getContentHandler()->makeEmptyContent();
         */
        protected function showHeaderCopyrightWarning() {
                $msg = 'editpage-head-copy-warn';
 -              if ( !wfMessage( $msg )->isDisabled() ) {
 +              if ( !$this->context->msg( $msg )->isDisabled() ) {
                        global $wgOut;
                        $wgOut->wrapWikiMsg( "<div class='editpage-head-copywarn'>\n$1\n</div>",
                                'editpage-head-copy-warn' );
        protected function showTosSummary() {
                $msg = 'editpage-tos-summary';
                Hooks::run( 'EditPageTosSummary', [ $this->mTitle, &$msg ] );
 -              if ( !wfMessage( $msg )->isDisabled() ) {
 +              if ( !$this->context->msg( $msg )->isDisabled() ) {
                        global $wgOut;
                        $wgOut->addHTML( '<div class="mw-tos-summary">' );
                        $wgOut->addWikiMsg( $msg );
        protected function showEditTools() {
                global $wgOut;
                $wgOut->addHTML( '<div class="mw-editTools">' .
 -                      wfMessage( 'edittools' )->inContentLanguage()->parse() .
 +                      $this->context->msg( 'edittools' )->inContentLanguage()->parse() .
                        '</div>' );
        }
  
         * @param string $format Output format, valid values are any function of a Message object
         * @return string
         */
 -      public static function getCopyrightWarning( $title, $format = 'plain' ) {
 +      public static function getCopyrightWarning( $title, $format = 'plain', $langcode = null ) {
                global $wgRightsText;
                if ( $wgRightsText ) {
                        $copywarnMsg = [ 'copyrightwarning',
                // Allow for site and per-namespace customization of contribution/copyright notice.
                Hooks::run( 'EditPageCopyrightWarning', [ $title, &$copywarnMsg ] );
  
 +              $msg = call_user_func_array( 'wfMessage', $copywarnMsg )->title( $title );
 +              if ( $langcode ) {
 +                      $msg->inLanguage( $langcode );
 +              }
                return "<div id=\"editpage-copywarn\">\n" .
 -                      call_user_func_array( 'wfMessage', $copywarnMsg )->$format() . "\n</div>";
 +                      $msg->$format() . "\n</div>";
        }
  
        /**
                if ( $cancel !== '' ) {
                        $cancel .= Html::element( 'span',
                                [ 'class' => 'mw-editButtons-pipe-separator' ],
 -                              wfMessage( 'pipe-separator' )->text() );
 +                              $this->context->msg( 'pipe-separator' )->text() );
                }
  
 -              $message = wfMessage( 'edithelppage' )->inContentLanguage()->text();
 +              $message = $this->context->msg( 'edithelppage' )->inContentLanguage()->text();
                $edithelpurl = Skin::makeInternalOrExternalUrl( $message );
                $attrs = [
                        'target' => 'helpwindow',
                        'href' => $edithelpurl,
                ];
 -              $edithelp = Html::linkButton( wfMessage( 'edithelp' )->text(),
 +              $edithelp = Html::linkButton( $this->context->msg( 'edithelp' )->text(),
                        $attrs, [ 'mw-ui-quiet' ] ) .
 -                      wfMessage( 'word-separator' )->escaped() .
 -                      wfMessage( 'newwindow' )->parse();
 +                      $this->context->msg( 'word-separator' )->escaped() .
 +                      $this->context->msg( 'newwindow' )->parse();
  
                $wgOut->addHTML( "      <span class='cancelLink'>{$cancel}</span>\n" );
                $wgOut->addHTML( "      <span class='editHelp'>{$edithelp}</span>\n" );
                        $de = $handler->createDifferenceEngine( $this->mArticle->getContext() );
                        $de->setContent( $content2, $content1 );
                        $de->showDiff(
 -                              wfMessage( 'yourtext' )->parse(),
 -                              wfMessage( 'storedversion' )->text()
 +                              $this->context->msg( 'yourtext' )->parse(),
 +                              $this->context->msg( 'storedversion' )->text()
                        );
  
                        $wgOut->wrapWikiMsg( '<h2>$1</h2>', "yourtext" );
  
                return Linker::linkKnown(
                        $this->getContextTitle(),
 -                      wfMessage( 'cancel' )->parse(),
 +                      $this->context->msg( 'cancel' )->parse(),
                        Html::buttonAttributes( $attrs, [ 'mw-ui-quiet' ] ),
                        $cancelParams
                );
                // Quick paranoid permission checks...
                if ( is_object( $data ) ) {
                        if ( $data->log_deleted & LogPage::DELETED_USER ) {
 -                              $data->user_name = wfMessage( 'rev-deleted-user' )->escaped();
 +                              $data->user_name = $this->context->msg( 'rev-deleted-user' )->escaped();
                        }
  
                        if ( $data->log_deleted & LogPage::DELETED_COMMENT ) {
 -                              $data->log_comment = wfMessage( 'rev-deleted-comment' )->escaped();
 +                              $data->log_comment = $this->context->msg( 'rev-deleted-comment' )->escaped();
                        }
                }
  
                                // string, which happens when you initially edit
                                // a category page, due to automatic preview-on-open.
                                $parsedNote = $wgOut->parse( "<div class='previewnote'>" .
 -                                      wfMessage( 'session_fail_preview_html' )->text() . "</div>", true, /* interface */true );
 +                                      $this->context->msg( 'session_fail_preview_html' )->text() . "</div>",
 +                                      true, /* interface */true );
                        }
                        $stats->increment( 'edit.failures.session_loss' );
                        return $parsedNote;
                        # provide a anchor link to the editform
                        $continueEditing = '<span class="mw-continue-editing">' .
                                '[[#' . self::EDITFORM_ID . '|' . $wgLang->getArrow() . ' ' .
 -                              wfMessage( 'continue-editing' )->text() . ']]</span>';
 +                              $this->context->msg( 'continue-editing' )->text() . ']]</span>';
                        if ( $this->mTriedSave && !$this->mTokenOk ) {
                                if ( $this->mTokenOkExceptSuffix ) {
 -                                      $note = wfMessage( 'token_suffix_mismatch' )->plain();
 +                                      $note = $this->context->msg( 'token_suffix_mismatch' )->plain();
                                        $stats->increment( 'edit.failures.bad_token' );
                                } else {
 -                                      $note = wfMessage( 'session_fail_preview' )->plain();
 +                                      $note = $this->context->msg( 'session_fail_preview' )->plain();
                                        $stats->increment( 'edit.failures.session_loss' );
                                }
                        } elseif ( $this->incompleteForm ) {
 -                              $note = wfMessage( 'edit_form_incomplete' )->plain();
 +                              $note = $this->context->msg( 'edit_form_incomplete' )->plain();
                                if ( $this->mTriedSave ) {
                                        $stats->increment( 'edit.failures.incomplete_form' );
                                }
                        } else {
 -                              $note = wfMessage( 'previewnote' )->plain() . ' ' . $continueEditing;
 +                              $note = $this->context->msg( 'previewnote' )->plain() . ' ' . $continueEditing;
                        }
  
                        # don't parse non-wikitext pages, show message about preview
                                # Messages: usercsspreview, userjspreview, sitecsspreview, sitejspreview
                                if ( $level && $format ) {
                                        $note = "<div id='mw-{$level}{$format}preview'>" .
 -                                              wfMessage( "{$level}{$format}preview" )->text() .
 +                                              $this->context->msg( "{$level}{$format}preview" )->text() .
                                                ' ' . $continueEditing . "</div>";
                                }
                        }
                        }
  
                } catch ( MWContentSerializationException $ex ) {
 -                      $m = wfMessage(
 +                      $m = $this->context->msg(
                                'content-failed-to-parse',
                                $this->contentModel,
                                $this->contentFormat,
  
                if ( $this->isConflict ) {
                        $conflict = '<h2 id="mw-previewconflict">'
 -                              . wfMessage( 'previewconflict' )->escaped() . "</h2>\n";
 +                              . $this->context->msg( 'previewconflict' )->escaped() . "</h2>\n";
                } else {
                        $conflict = '<hr />';
                }
  
                $previewhead = "<div class='previewnote'>\n" .
 -                      '<h2 id="mw-previewheader">' . wfMessage( 'preview' )->escaped() . "</h2>" .
 +                      '<h2 id="mw-previewheader">' . $this->context->msg( 'preview' )->escaped() . "</h2>" .
                        $wgOut->parse( $note, true, /* interface */true ) . $conflict . "</div>\n";
  
                $pageViewLang = $this->mTitle->getPageViewLanguage();
                // don't show the minor edit checkbox if it's a new page or section
                if ( !$this->isNew ) {
                        $checkboxes['minor'] = '';
 -                      $minorLabel = wfMessage( 'minoredit' )->parse();
 +                      $minorLabel = $this->context->msg( 'minoredit' )->parse();
                        if ( $wgUser->isAllowed( 'minoredit' ) ) {
                                $attribs = [
                                        'tabindex' => ++$tabindex,
 -                                      'accesskey' => wfMessage( 'accesskey-minoredit' )->text(),
 +                                      'accesskey' => $this->context->msg( 'accesskey-minoredit' )->text(),
                                        'id' => 'wpMinoredit',
                                ];
                                $minorEditHtml =
                        }
                }
  
 -              $watchLabel = wfMessage( 'watchthis' )->parse();
 +              $watchLabel = $this->context->msg( 'watchthis' )->parse();
                $checkboxes['watch'] = '';
                if ( $wgUser->isLoggedIn() ) {
                        $attribs = [
                                'tabindex' => ++$tabindex,
 -                              'accesskey' => wfMessage( 'accesskey-watch' )->text(),
 +                              'accesskey' => $this->context->msg( 'accesskey-watch' )->text(),
                                'id' => 'wpWatchthis',
                        ];
                        $watchThisHtml =
                } else {
                        $buttonLabelKey = !$this->mTitle->exists() ? 'savearticle' : 'savechanges';
                }
 -              $buttonLabel = wfMessage( $buttonLabelKey )->text();
 +              $buttonLabel = $this->context->msg( $buttonLabelKey )->text();
                $attribs = [
                        'id' => 'wpSave',
                        'name' => 'wpSave',
                        'name' => 'wpPreview',
                        'tabindex' => $tabindex,
                ] + Linker::tooltipAndAccesskeyAttribs( 'preview' );
 -              $buttons['preview'] = Html::submitButton( wfMessage( 'showpreview' )->text(),
 +              $buttons['preview'] = Html::submitButton( $this->context->msg( 'showpreview' )->text(),
                        $attribs );
                $buttons['live'] = '';
  
                        'name' => 'wpDiff',
                        'tabindex' => ++$tabindex,
                ] + Linker::tooltipAndAccesskeyAttribs( 'diff' );
 -              $buttons['diff'] = Html::submitButton( wfMessage( 'showdiff' )->text(),
 +              $buttons['diff'] = Html::submitButton( $this->context->msg( 'showdiff' )->text(),
                        $attribs );
  
                Hooks::run( 'EditPageBeforeEditButtons', [ &$this, &$buttons, &$tabindex ] );
        function noSuchSectionPage() {
                global $wgOut;
  
 -              $wgOut->prepareErrorPage( wfMessage( 'nosuchsectiontitle' ) );
 +              $wgOut->prepareErrorPage( $this->context->msg( 'nosuchsectiontitle' ) );
  
 -              $res = wfMessage( 'nosuchsectiontext', $this->section )->parseAsBlock();
 +              $res = $this->context->msg( 'nosuchsectiontext', $this->section )->parseAsBlock();
                Hooks::run( 'EditPageNoSuchSection', [ &$this, &$res ] );
                $wgOut->addHTML( $res );
  
                if ( is_array( $match ) ) {
                        $match = $wgLang->listToText( $match );
                }
 -              $wgOut->prepareErrorPage( wfMessage( 'spamprotectiontitle' ) );
 +              $wgOut->prepareErrorPage( $this->context->msg( 'spamprotectiontitle' ) );
  
                $wgOut->addHTML( '<div id="spamprotected">' );
                $wgOut->addWikiMsg( 'spamprotectiontext' );
        protected function safeUnicodeOutput( $text ) {
                return $this->checkUnicodeCompliantBrowser()
                        ? $text
 -                      : $this->makesafe( $text );
 +                      : $this->makeSafe( $text );
        }
  
        /**
@@@ -105,6 -105,25 +105,25 @@@ span.comment 
        clear: both;
  }
  
+ /* Edit font preference */
+ /* TODO: for 'default' on non-textareas we could compute the default font of textarea in the client */
+ .mw-editfont-default:not( textarea ) {
+       font-family: monospace;
+ }
+ /* Keep this rule separate from the :not rule above so it still works in older browsers */
+ .mw-editfont-monospace {
+       font-family: monospace;
+ }
+ .mw-editfont-sans-serif {
+       font-family: sans-serif;
+ }
+ .mw-editfont-serif {
+       font-family: serif;
+ }
  /**
   * rev_deleted stuff
   */
@@@ -162,7 -181,6 +181,7 @@@ input#wpSummary 
  
  .mw-input-with-label {
        white-space: nowrap;
 +      display: inline-block;
  }
  
  /**
@@@ -657,6 -675,33 +676,6 @@@ ol:lang(or) li 
        direction: ltr;
  }
  
 -/* tooltip styles */
 -.mw-help-field-hint {
 -      display: none;
 -      margin-left: 2px;
 -      margin-bottom: -8px;
 -      padding: 0 0 0 15px;
 -      background-image: url( images/help-question.gif );
 -      background-position: left center;
 -      background-repeat: no-repeat;
 -      cursor: pointer;
 -      font-size: .8em;
 -      text-decoration: underline;
 -      color: #0645ad;
 -}
 -
 -.mw-help-field-hint:hover {
 -      background-image: url( images/help-question-hover.gif );
 -}
 -
 -.mw-help-field-data {
 -      display: block;
 -      background-color: #d6f3ff;
 -      padding: 5px 8px 4px 8px;
 -      border: 1px solid #5dc9f4;
 -      margin-left: 20px;
 -}
 -
  #mw-clearyourcache,
  #mw-sitecsspreview,
  #mw-sitejspreview,