Merge "Add missing Title::newFromLinkTarget to api module compare"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 7 Jun 2019 08:11:27 +0000 (08:11 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 7 Jun 2019 08:11:27 +0000 (08:11 +0000)
includes/api/ApiComparePages.php

index 1eb5e8d..e096915 100644 (file)
@@ -562,7 +562,7 @@ class ApiComparePages extends ApiBase {
         */
        private function setVals( &$vals, $prefix, $rev ) {
                if ( $rev ) {
-                       $title = $rev->getPageAsLinkTarget();
+                       $title = Title::newFromLinkTarget( $rev->getPageAsLinkTarget() );
                        if ( isset( $this->props['ids'] ) ) {
                                $vals["{$prefix}id"] = $title->getArticleID();
                                $vals["{$prefix}revid"] = $rev->getId();
@@ -603,7 +603,7 @@ class ApiComparePages extends ApiBase {
                                                $vals["{$prefix}comment"] = $comment->text;
                                        }
                                        $vals["{$prefix}parsedcomment"] = Linker::formatComment(
-                                               $comment->text, Title::newFromLinkTarget( $title )
+                                               $comment->text, $title
                                        );
                                }
                        }