See Ia5b7a96 and the unrelated error raised there.
https://integration.wikimedia.org/ci/job/mwext-testextension-zend/19682/consoleFull
By writing this simple test I not only found one but two issues.
Bug: T123539
Change-Id: I17ed5b69992aa98ab2384b7a6aafc96b0fcba1ce
}
protected function optimalOrder() {
- return array( 'fifo' );
+ return 'fifo';
}
protected function doIsEmpty() {
if ( $init !== null ) {
self::$data[$this->type][$this->wiki][$field] = $init;
} else {
- return null;
+ return $init;
}
}
--- /dev/null
+<?php
+
+/**
+ * @covers JobQueueMemory
+ *
+ * @group JobQueue
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class JobQueueMemoryTest extends PHPUnit_Framework_TestCase {
+
+ public function testGetAllQueuedJobs() {
+ $instance = JobQueueMemoryDouble::newInstance( array(
+ 'wiki' => null,
+ 'type' => null,
+ ) );
+ $actual = $instance->getAllQueuedJobs();
+ $this->assertEquals( new ArrayIterator(), $actual );
+ }
+
+}
+
+class JobQueueMemoryDouble extends JobQueueMemory {
+
+ public static function newInstance( array $params ) {
+ return new self( $params );
+ }
+
+}