From ddb837a505b3d243c314128a71da1412cdd4fbe8 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Mon, 18 Jan 2010 12:56:44 +0000 Subject: [PATCH] Add bug # --- RELEASE-NOTES | 4 ++-- maintenance/install-utils.inc | 5 +++-- maintenance/syntaxChecker.php | 1 + 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 039ff8f037..7bec1e2383 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -715,8 +715,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN skin-specific JS pages * (bug 5061) Use the more precise thumbcaption thumbimage and thumbinner classes for image divs. -* IE50Fixes.css and IE55Fixes.css have been dropped from the Monobook and Chick - skins +* (bug 22096) IE50Fixes.css and IE55Fixes.css have been dropped from the Monobook + and Chick skins == API changes in 1.16 == diff --git a/maintenance/install-utils.inc b/maintenance/install-utils.inc index 1d018a606a..586e260c2d 100644 --- a/maintenance/install-utils.inc +++ b/maintenance/install-utils.inc @@ -48,8 +48,9 @@ function install_version_checks() { call_user_func_array( array( $test, 'test' ), array( &$ok ) ); if ( !$ok ) { echo "PHP " . phpversion() . " is not compatible with MediaWiki due to a bug involving\n" . - "reference parameters to __call. Upgrade to PHP 5.3.2, or downgrade\n" . - "to PHP 5.3.0. to fix this.\n" . + "reference parameters to __call in PHP versions 5.3.1, 5.2.12 and 5.2.11.\n" . + "Upgrade to PHP 5.3.2 (5.2.13 for 5.2 users), or downgrade\n" . + "to PHP 5.3.0 (5.2.10 for 5.2 users) to fix this.\n" . "ABORTING (see http://bugs.php.net/bug.php?id=50394 for details)\n"; die( 1 ); } diff --git a/maintenance/syntaxChecker.php b/maintenance/syntaxChecker.php index bbd968c24e..64f9a36a1e 100644 --- a/maintenance/syntaxChecker.php +++ b/maintenance/syntaxChecker.php @@ -274,6 +274,7 @@ class SyntaxChecker extends Maintenance { $this->checkRegex( $file, $text, '/^[\s\r\n]+<\?/', 'leading whitespace' ); $this->checkRegex( $file, $text, '/\?>[\s\r\n]*$/', 'trailing ?>' ); $this->checkRegex( $file, $text, '/^[\xFF\xFE\xEF]/', 'byte-order mark' ); + $this->checkRegex( $file, $text, '/\&\$this/', 'passing $this by reference' ); } private function checkRegex( $file, $text, $regex, $desc ) { -- 2.20.1